Hello & Welcome to our community. Is this your first visit? Register
Follow us on
Follow us on Facebook Follow us on Twitter Watch us on YouTube


MMOCoin

Likes Likes:  0
Results 1 to 5 of 5
  1. #1
    Contributor
    Cocain's Avatar
    Join Date
    Mar 2010
    Posts
    208
    Post Thanks / Like
    Rep Power
    16
    Reputation
    92

    [C++]ProcChance fix of several trinkets + Consecration fix - Swift Retribution.


    Register to remove this ad
    As this is a simple fix, I'm just releasing it here.

    Note : This are easy fixes. (Some of the trinkets get their credits given to Malacka from ShyEmu.)
    Me : Consecration patch & other trinkets



    Code:
    Index: src/arcemu-world/SpellFixes.cpp
    ===================================================================
    --- src/arcemu-world/SpellFixes.cpp
    +++ src/arcemu-world/SpellFixes.cpp
    @@ -7096,6 +7096,7 @@
             {
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_MELEE_ATTACK | PROC_ON_RANGED_ATTACK;
    +                sp->EffectTriggerSpell[1] = 37064;
             }
     
             // Forge Ember
    @@ -7104,6 +7105,7 @@
             {
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_CAST_SPELL;
    +                sp->EffectTriggerSpell[1] = 37660;
             }
     
             // Mirror of Truth
    @@ -7112,6 +7114,7 @@
             {
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_CRIT_ATTACK;
    +                sp->EffectTriggerSpell[1] = 40684;
             }
     
             // Majestic Dragon Figurine
    @@ -7119,6 +7122,7 @@
             if( sp != NULL )
             {
                     sp->procFlags = PROC_ON_CAST_SPELL;
    +                sp->EffectTriggerSpell[1] = 40430;
             }
     
             // Flow of Knowledge
    @@ -7127,6 +7131,8 @@
             {
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_CAST_SPELL;
    +                sp->EffectTriggerSpell[1] = 44912;
    +
             }
     
             // Embrace of the Spider
    @@ -7135,6 +7141,7 @@
             {
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_CAST_SPELL;
    +                sp->EffectTriggerSpell[1] = 39229;
             }
     
             // Anvil of Titans
    @@ -7143,6 +7150,7 @@
             {
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_MELEE_ATTACK | PROC_ON_RANGED_ATTACK;
    +                sp->EffectTriggerSpell[1] = 44914;
             }
     
             // Soul of the Dead
    @@ -7151,6 +7159,7 @@
             {
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_SPELL_CRIT_HIT;
    +                sp->EffectTriggerSpell[1] = 40382;
             }
     
             // Illustration of the Dragon Soul
    @@ -7158,6 +7167,7 @@
             if( sp != NULL )
             {
                 sp->procFlags = PROC_ON_CAST_SPELL;
    +            sp->EffectTriggerSpell[1] = 40432;
             }
     
             // Grim Toll
    @@ -7166,6 +7176,7 @@
             {
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_MELEE_ATTACK | PROC_ON_RANGED_ATTACK;
    +                sp->EffectTriggerSpell[1] = 40256;
             }
     
             // Fury of the Five Flights
    @@ -7173,6 +7184,7 @@
             if( sp != NULL )
             {
                 sp->procFlags = PROC_ON_MELEE_ATTACK | PROC_ON_RANGED_ATTACK;
    +            sp->EffectTriggerSpell[1] = 40431;
             }
     
             // Bandit's Insignia
    @@ -7181,6 +7193,7 @@
             {
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_MELEE_ATTACK | PROC_ON_RANGED_ATTACK;
    +                sp->EffectTriggerSpell[1] = 40371;
             }
     
             // Meteorite Whetstone
    @@ -7189,6 +7202,7 @@
             {
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_MELEE_ATTACK | PROC_ON_RANGED_ATTACK;
    +                sp->EffectTriggerSpell[1] = 37390;
             }
     
             // Sonic Booster
    @@ -7197,6 +7211,7 @@
             {
                     sp->proc_interval = 60000;
                     sp->procFlags = PROC_ON_MELEE_ATTACK;
    +                sp->EffectTriggerSpell[1] = 40767;
             }
     
             //Totem of the Third Wind - bad range
    Trinkets Proc Chance :
    Code:
    Index: SpellFixes.cpp
    ===================================================================
    --- SpellFixes.cpp    (revision 14)
    +++ SpellFixes.cpp    (working copy)
    @@ -7288,6 +7288,7 @@
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_CAST_SPELL;
                     sp->EffectTriggerSpell[1] = 37660;
    +                sp->procChance = 10;
             }
     
             // Mirror of Truth
    @@ -7297,6 +7298,7 @@
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_CRIT_ATTACK;
                     sp->EffectTriggerSpell[1] = 40684;
    +                sp->procChance = 10;
             }
     
             // Majestic Dragon Figurine
    @@ -7305,6 +7307,7 @@
             {
                     sp->procFlags = PROC_ON_CAST_SPELL;
                     sp->EffectTriggerSpell[1] = 40430;
    +                sp->procChance = 10;
             }
     
             // Flow of Knowledge
    @@ -7314,6 +7317,7 @@
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_CAST_SPELL;
                     sp->EffectTriggerSpell[1] = 44912;
    +                sp->procChance = 10;
     
             }
     
    @@ -7324,6 +7328,7 @@
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_CAST_SPELL;
                     sp->EffectTriggerSpell[1] = 39229;
    +                sp->procChance = 10;
             }
     
             // Anvil of Titans
    @@ -7333,6 +7338,7 @@
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_MELEE_ATTACK | PROC_ON_RANGED_ATTACK;
                     sp->EffectTriggerSpell[1] = 44914;
    +                sp->procChance = 10;
             }
     
             // Soul of the Dead
    @@ -7342,6 +7348,8 @@
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_SPELL_CRIT_HIT;
                     sp->EffectTriggerSpell[1] = 40382;
    +                sp->procChance = 25;
    +
             }
     
             // Illustration of the Dragon Soul
    @@ -7350,6 +7358,7 @@
             {
                 sp->procFlags = PROC_ON_CAST_SPELL;
                 sp->EffectTriggerSpell[1] = 40432;
    +            sp->procChance = 100;
             }
     
             // Grim Toll
    @@ -7359,6 +7368,7 @@
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_MELEE_ATTACK | PROC_ON_RANGED_ATTACK;
                     sp->EffectTriggerSpell[1] = 40256;
    +                sp->procChance = 15;
             }
     
             // Fury of the Five Flights
    @@ -7367,6 +7377,7 @@
             {
                 sp->procFlags = PROC_ON_MELEE_ATTACK | PROC_ON_RANGED_ATTACK;
                 sp->EffectTriggerSpell[1] = 40431;
    +            sp->procChance = 100;
             }
     
             // Bandit's Insignia
    @@ -7376,6 +7387,7 @@
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_MELEE_ATTACK | PROC_ON_RANGED_ATTACK;
                     sp->EffectTriggerSpell[1] = 40371;
    +                sp->procChance = 15;
             }
     
             // Meteorite Whetstone
    @@ -7385,6 +7397,7 @@
                     sp->proc_interval = 45000;
                     sp->procFlags = PROC_ON_MELEE_ATTACK | PROC_ON_RANGED_ATTACK;
                     sp->EffectTriggerSpell[1] = 37390;
    +                sp->procChance = 15;
             }
     
             // Sonic Booster
    @@ -7394,6 +7407,7 @@
                     sp->proc_interval = 60000;
                     sp->procFlags = PROC_ON_MELEE_ATTACK;
                     sp->EffectTriggerSpell[1] = 40767;
    +                sp->procChance = 15;
             }
     
             //Totem of the Third Wind - bad range
    Consecration :

    The problem was that it actually did do some damage, but the damage done wasn't linked to the spelldamage nor was it's school defined as holy. You could fix it by just defining it like this :

    Code:
    Index: SpellFixes.cpp
    ===================================================================
    --- SpellFixes.cpp    (revision 3174)
    +++ SpellFixes.cpp    (working copy)
    @@ -3013,6 +3013,13 @@
                 sp->procFlags = PROC_ON_SPELL_CRIT_HIT;
             }
     
    +        // Paladin - Consecration
    +        if( sp->NameHas == SPELL_HASH_CONSECRATION   )
    +        {
    +            sp->School = SCHOOL_HOLY; //Consecration is a holy redirected spell.
    +            sp->Spell_Dmg_Type = SPELL_DMG_TYPE_MAGIC; //Speaks for itself.
    +        }
    +

    Paladin : Swift Retribution.

    Code:
            // Swift Retribution
            if( sp->NameHash == SPELL_HASH_SWIFT_RETRIBUTION )
            {
                sp->EffectApplyAuraName[0] = SPELL_AURA_MOD_HASTE;
                sp->EffectBasePoints[0] = 3;
            }





    › See More: [C++]ProcChance fix of several trinkets + Consecration fix - Swift Retribution.



  2. Related Threads - Scroll Down after related threads if you are only interested to view replies for above post/thread

  3. #2
    Banned

    Join Date
    Aug 2008
    Location
    Scotland
    Posts
    652
    Post Thanks / Like
    Rep Power
    0
    Reputation
    103
    Nice release.

  4. #3
    Contributor
    Cocain's Avatar
    Join Date
    Mar 2010
    Posts
    208
    Post Thanks / Like
    Rep Power
    16
    Reputation
    92
    Thanks.

  5. #4
    Grunt

    Join Date
    Feb 2010
    Posts
    42
    Post Thanks / Like
    Rep Power
    16
    Reputation
    98
    very nice

  6. #5
    Senior Sergeant
    .SalMAX™'s Avatar
    Join Date
    Mar 2010
    Location
    Miami, Florida
    Posts
    100
    Post Thanks / Like
    Rep Power
    15
    Reputation
    52

    Register to remove this ad
    Perfect, Great script Cocain.
    Don't Forget to for useful releases!. It gives you good luck! Just Like Lucky charms!

 

 

Visitors found this page by searching for:

C Retribution

arcemu trinket fixes

Consecration fix

arcemu trinket fix

trinitycore swift retribution

Swift Retribution mangos fix

spellfixes.cpp

fix trinket arcemu

c trinket fix mangos

SEO Blog

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts
  •  
All times are GMT -5. The time now is 05:28 PM.
Powered by vBulletin® Copyright ©2000-2024, Jelsoft Enterprises Ltd.
See More links by ForumSetup.net. Feedback Buttons provided by Advanced Post Thanks / Like (Lite) - vBulletin Mods & Addons Copyright © 2024 DragonByte Technologies Ltd.
vBulletin Licensed to: MMOPro.org