Thread: Mangos + YTDB + Scriptdev2 + Changelog

YTDB 231
+ All fixes from the forum and editing of bug reports (see "adopted patches")
+ Settlement
+ Scripts quests
+ Adjustment "gameobject_template" type = 0,1,10 for WDB
+ Adjustment loot money from the NPC
+ Gossip-menus mobs

Mangos 9044 - 9071
Exclude TARGET_SELF from I***plicitPositiveTarget.

This must fix triggred spells casting in case when it self casted but cast
code send diff target.
Implement talent 48539 and ranks.

Signed-off-by: VladimirMangos <[email protected]>

Also some typos in mangos.sql field order fixes (sql updates in past ahe
been correct)
Correctly send channeling start/update packets to clients

(cherry-picked from commit 1bc38f7)
Support triggered spells that have cast time.

Like spell will placed in unit event list for cast at next tick or later
dependent from cast timer.
Before all triggered spell ignore cast time and casted explcitly from
related cast caller code.
This must fix some spell work like 17086 in damage apply time part and
also in preventing possible
stack overflow because this spell triggering by chain 19 spell casts from
each other.

This also exclude from triggered arg of CastSpell function meaning that
this cast will instant alsways.
So triggred arg now meaning only that this seppl casted nit from player
side and then not send
in some cases cast info to client if not vosula effect expected.
Add src\bindings\universal\Scripts\sc_defines.cpp to script.vcproj
Additional fixes for talent 17056 and ranks.

Thanks to Sarjuuk for clarify existed problems and help in prepare fix.
Add MAX_EXPANSION define for config option Expansion check.

This will prevent case when expansion set to high for supported client
in config and account have also too high expansion setting.
Client in like case receive too high expnasion and reject connection
because it think that have not installed expansion for connection account.


This possible for example for account case when single realmd used for
diff client versions and account have high expansion setting for most
recent client support. And in same time mamngos.conf for specific realm
have wrong Expansion value.
Make code more compatible with C++ standart strict follow compilers.
Fixed possible crash at fake items swap packet.
Fxied some mage DoTs stacking.
Implement expire/dispell damage for spell 44457 and ranks.
Fixed charge amount for spell 64823 to expected 1
Not exclude real caster from TARGET_ALL_ENEMY_IN_AREA_INSTANT.

Not found cases when this need for affected case (without 27/28 effects)
Implement some damage related spell attributes support.

* SPELL_ATTR_EX4_STACK_DOT_MODIFIER
* SPELL_ATTR_EX6_NO_DMG_PERCENT_MODS
Implement spell 7057
Implement expire effect for spell 28169
Fixed leave combat by timer.

This also fix some problems with stealth detection.
Fixed SPELL_AURA_MOD_CRIT_DAMAGE_BONU (163) use in calculations.

* Renamed from SPELL_AURA_MOD_CRIT_DAMAGE_BONUS_MELEE
* Also apply to non-melee damage also
Implement two helper-functions for casting spell in creatureAI.

Function will return a cast result, with fail reasons if spell can not be
casted (can be used to take alternative action). Please note this is not a
full list of cast fail errors/reasons, but will cover a few basic errors
that may occur.
The virtual function CanCastSpell() may be adjusted for custom needs from
script library if not the default is sufficient.
Add one more expected spell cast at spell 28169 debuf expire.
More internal cooldowns for some intem spells.
Implement motionmaster function UpdateFinalDistanceToTarget()

To update a creatures distance to it's target without creating a new
movement generator. Note it can only be used where creature is using
TargetedMovementGenerator.
Small cleanups in spell code.

Mostly avoid unclear "lost" break case
Restore build at *nix.
Include spell 35395 in trigger list for talent 53380 and ranks.
Also remove wrong masks from talent 53486 and ranks.
Drop outdated code.
Add explcit 6 sec triggering cooldown to 58597.
Fixed exclusive triggering 2 buff versions for talent 48516 and
ranks.

Mangos 9072 - 9091
Implement periodic dummy aura for spells 50792, 59859, 50801 and
59858
Implement hack way detection for cave area 571.
Fix typo in 'server shutdown' description.
Fixed direction of move for SPELL_EFFECT_PLAYER_PULL
Another SPELL_EFFECT_PLAYER_PULL problem fix.

If base points porvided then this is _max_ pull distance, not direct
distance.
Fixes for pet work in case mounted owner.

* No unsummon temporary pet at non-fly mounting.
* Implement client side disable pet's action bar for mountted owner time

Signed-off-by: VladimirMangos <[email protected]>

* implement server side action disabled case (action bar modify, aggro
reaction and autocast)
Allow stacking healing buffs from spell 33763 and 48438, and ranks.
Less strict check related to TARGET_SCRIPT_COORDINATES

Fixes and enables ~20 more summon related spells. Some minor cleanup in
related code
Add custom/preset unMaxTargets for a few spells where info is not
present

Thanks to kamillys and KAPATEJIb for original code and research!
Fixed DoT damage from 12834 and ranks.
Correct some spells unMaxTarget (ref [9080]) to depend on map
difficulty
Rename maps naming used in spell targeting code for easier
readability
Implement periodic dummy aura for spell 50789 and 59860
Implement periodic dummy aura for spell 50824
Limit maxTargets for spell 33711 and 38794

Also remove not strict required difficulty check for some spells and add
lost comment from [9085]
Fixes in pet unsummons

* Not unsummon warlock pets at logout.
* Prevent overwrite current saved pet at save secondary pet (with
temporary unsummoned first).
This possible at arena for example.
* Not fixed: in char list at login pet don't must be show with character
if character saved at mount in game.
Not critical and maybe not need fix as feature
Prevent unsummon permanent pets at arenas.
Check explicit target correctness by all effect target modes.

All effect target modes start from client provided target data
so all its must be used for checking explicit target modes.
For example exist spells that have as first effect SELF non-explicit
target mode.
but in same time negative to explicit target.

Signed-off-by: VladimirMangos <[email protected]>

Also add caching IsHostileTo/IsFriendlyTo for avoid recall this not fast
functions.
Implement tick counting in periodic auras.

This can be used for some tick number dependent aura effects.
Also in some cases impossible claculate tickes count pass,
for example for infinity duration auras.
Add max targets limit for spell 34861 and ranks.
Also implement glyph 42396 work for referenced spells.


YTDB
+ All fixes from forum
+ spawn
+ quest scripts
+ mob's gossip menues
+ fix "item_template"
+ fix "quest_template"

Mangos 9092 - 9112
Fixed typo in function name.
Implement periodic dummy aura for spell 48630 and 59275
Implement periodic dummy aura for spell 46041
Allow apply .modify scale to targeted creature (without save
scale).

Also add command description to mangos.sql.
Implement periodic dummy aura for spell 52441

Note speed is not really reduced as expected, this need correction in
other parts of code.
Implement periodic dummy aura for spell 53520
More correct targets selection for target pairs with TARGET_SELF2

* Many spell effects that have A target mode SELF2 expected applied to
enemy
target selected by targetmode B so we need skip SELF2 target mode.
* remove SEFL2 from explicit positive target modes.

Implement periodic dummy aura for spell 55592

Also correct second cast, expected for spell 53520
Set MaxTargets limit for spell 31347
Correct target mode 48, and rename to something more meaningful

Also adjust target 49/50 angles to be really left/right.
Use FillRaidOrPartyHealthPriorityTargets for 34861 and ranks.
Make gcc happy with muti-byte char casts and use more readable
magic strings.
Avoid send reset warning to map/difficulty cases without fixed
reset time.
Add missing argument in error message, _LoadSkills()
Add script effect for spell 47097

Also add areaflag hack to detect correct areaId
Fix most of the gcc warnings

* use UI64FMTD instead of "%u" for uint64 output
* on most *NIX systems, I64FMT is "%016lX" and not "%016llX"
* also fix typo: renamed GridMap::loadHeihgtData to
GridMap::loadHeightData

Note: there are still many warnings from the 3rd party libraries g3dlite
and ACE. Those warnings won't be fixed with that commit.
Also, a few warnings from MaNGOS are left, they'll be fixed later.
Adjust max nextMoveTime to 10000+totalTravelTime for random
movement

This is apparently closer to how the world should look like, which is
still of course a best guesstimate.
Removing the option for run chance from generic random movement
generator

Npcs with random movement in general do not behave like this, and movement
that fits the pattern of a mixed movement run/walk must be made instead if
needed.
Some cosmetic cleanup in random movement code.
Implement ConditionType CONDITION_LEVEL for PlayerCondition
Limit maxTargets for spell 42005












just DTS and AC

keep it up again

YTDB 236
+ All fixes from forum
+ spawn
+ quest scripts
+ mob's gossip menues
+ many the operating time
Mangos 9113 - 9130
Add helper functions to set/getSummonLocation

This should help the poor homeless that does not have a database defined
home at evade (such as "wild summon" without owner).
Limit maxTargets for spell 28542 and 55665

Also add missing comment for target exclusion
Fix typo in error output.
Lost break/return in CONDITION_LEVEL cases.
Add dummy effect at aura removal for spell 32286
Fixed problem with not set
AchievementCriteriaRequirementSet::criteria_id

This important for support ACHIEVEMENT_CRITERIA_REQUIRE_INSTANCE_SCRIPT
Add achievement creteria requirements for
ACHIEVEMENT_CRITERIA_TYPE_BE_SPELL_TARGET*

Most ACHIEVEMENT_CRITERIA_TYPE_BE_SPELL_TARGET and
ACHIEVEMENT_CRITERIA_TYPE_BE_SPELL_TARGET2
not need any additional requirements (so just
ACHIEVEMENT_CRITERIA_REQUIRE_NONE(0) in DB) but some
need map difficualty checks and some
ACHIEVEMENT_CRITERIA_REQUIRE_INSTANCE_SCRIPT also.
Implement option to use delay in ForcedDespawn for creature
Implement dummy effects for spell 50926,51026,51592 and 51961

Note: Some adjustments in addition to original patch, using delay despawn.

Also provide sql update for proper work of affected spells (if already
exist in database).
Updated copyright notice for new year.

Also fix some lost in past cases.
One lost cases in year update
Fixed typo in README.
Add dummy effect of spell 46167

SQL update included to ensure proper work (if database has existing data)
Correct makefile copyright notice year, again

Blame the tools!
Allow use delayed forced despawn also in EAI.
Updated doc/EventAI.txt version.
Rename BG/arena queue_id to bracket_id and related functions/etc

This is more consistent to wide used terms

Also some other cleanups.
Implement spell 48603 script effect.

Also apply some ordering to existed spell cases code.

Mangos 9131 - 9171
Use more generic check for IsLootCraftingSpell

This include spell 69412 to autoloot generation spells.
Some enum fixes.
Merge remote branch 'origin/master' into 330
Fixed crash at loading from `player_classlevelstats` level 0 data.

Added check that prevent loading data for unexpected level 0.
Compile fix.
Fixes in talent 11129 work.

* Restore after client switch talent triggering.
* Propertly remove triggred auras stack or main spell aura at
expire/cancel.
MaNGOS 0.15 release.
Bump for 0.16.0 development.
Merge branch '330' - Switch to support client version 3.3.0A

You need extract new dbc.

Also recommended extract new map/vmaps.

And apply ofc sql updates that including character convertion.

Special thanks to TOM_RUS for continue work at next client versions
support
Add prev/new supported builds explcitly to realmd supported builds
list.
Implement glyph 45783.
Implement glyph 40913
Let aura after seal do at least one finish tick for stealer.

* Set periodic to fit new aura max duration range for this
* This also prevent crash for soem auras at steal.
Prevent memory lost at pet declined names loading.
Move start outfit items check to server loading.

Also drop one not needed now hack.
Typos
Propertly update combat ratings fields.

* Implemented proper combat rating fields update like other stats fields.
This will prevent reset combat ratings at .reset stats for example.
* Skill loading moved after InitStatsForLevel for prevent reset fields
setup
as part of aura apply from skill set triggered spell casts.
This fix for example talent 53125 work (combat rating set at skill
loading)
Small cleanups in pool system code

* Mark some pool system functions as constant
* Drop unused field.
More poolmgr cleanps.

* Replace mixed values used type args by function template specializations

* More explcilty show fact that poolmgr work only with db guids.
More code cleanup in poolmgr.

* Use normal result pointer instead args pair in pool roll.
* Send PoolObject pointer into (Re)Spawn1Object and set internaly spawned
field.
Revert "[9042] Remove double apply bonuses for spell 635/31935 and
ranks"

* This reverts commit 2157bc1b2fb064bd6bf0dfa5b4152d13760450c5.
* And drop DB bonus data.

Thanks to MrLama and pasdVn for reseach problem.
Drop code and DB data for removed 31892/53720 and related spells.
Fixed some paladin spell bonuses

* Use stack size in additional spell damage for 31803/53742.
* Use in code calculation for additional spell 20187/20375 damage

Thanks to MrLama for small cleanups and patch updating.
More paladin spells fixes

* Allow stacking caster effect with target effect at same player for
53736. Provided by KAPATEJIb.
* Allow proc 53736/31801 at melee hits or melee like spell hits
Prevent unexpected removal of move flag for following creatures not
in combat
Use in code heal amount calculation for 20165.

Thanks to MrLama for small cleanups and patch updating.
Implement spell 20375 targets amount depndence from triggering
source spell.
Update spell_proc_event for spell 20375, 21084, 31801.
Implement talent 19552 and ranks affect of spell 61846 and ranks.
Prevent crash after .goname/namego teleports at same bg/arena.
Fixed build errors for contrib/extractor at some x64 plaforms
Skip invisible/stealthed and not detected targets from threat list
at next target selection.

This will fix work spell 58984 and similar in combat.
Implement and use PROC_EX_FULL_BLOCK

It used for spell 31245 and ranks new proc flags.

Original patch provided by dardennf.
Drop unexpected added copy of sql update.
Allow SPELL_AURA_PERIODIC_LEECH to crit if able to.

This allow DoT crits from 2944 and ranks for example.

(based on commit be72957)

Also included improvement from Lynx3d for resilence and crit threat
affect.
Update splitConfig.txt for vmap generations.

This will fix large size some generated vmap files and optimize server
work with its.

NOTE: in fact no changes in real in game data but for optimize work better
regenerate vmaps with new splitConfig.txt.
Use enum for CONFIG_SKIP_CINEMATICS values.

Just small code cleanup
Implement speed reduction at creatures DoFleeToGetAssistance
Fixes/cleanups in extarctor code.

* Avoid create debug binary version with space in name, ignore it in git
changes.
* Alow filenum == 0 in archive file lists. Some currently not loaded fiels
have its
for example in case when in archive single file.

NOTE: no change in extracted files, so not need re-execute.
Remove unused arg in new function added to prev. commit.

Also update ad.exe
Correctly work with alternative locale names.

Allow use enGB locale subdirectory for DBC files.
Move accaptable builds check/list preparing to functions.

Maybe DBCStore.* not best place for its but we not have src/game local
file for common functions...
Impleament DBCs build check at server startup.

* Extractor now include in extarcted DBC dir data file with build info.
* Mangosd use this data for check at startup for main DBC dir and DBC
local subdirs intergrity.
* Also updates DBC checks for raw data.

NOTE: You need reextract DBC data by _new_ extractor for correct work
mangosd.
Update pet and minipet monster move flag at player toggle walk/run

this is a good thread,,I have made mangos
repacks,but getting the download thing to
work is more difficult that compiling it,,

I made a 8953 & 3.3.0 ytdb with ,heisei 1.1.1 ''Secrets of Ulduar''scripts,
but now I see updates,,

now i can make mangos 3.3

a few to many error's
runs good,but I will try and
update it,,

tree