Thread: Mangos + YTDB + Scriptdev2 + Changelog

Mangos 9578 - 9599
Use ObjectGuid in visibility sets
Use ObjectGuid in some loot code.

Also use ObjectGuidSet instead std::set<ObjectGuid>
Add ObjectGuid const& Object::GetObjectGuid() and restore build.
Fixed apply damage reduction to melee/ranged damage.
Send looted creature guid in proper field of loot packets.

Also use ObjectGuid in related functions.
Fixed speed recalculation at remove .mod speed rate while
mounted/etc.
Continue fix loot roll packets and related code.

* Propertly send itemSlot field and use it with looted target for roll
selection.
* Remove references to NumberOfPlayers useless data send in args
* Fixed long existed bug with roll show when single player from group can
roll item.
* Fixed possible crash at player leave group while item roll
* Fixed wrong item amount in stack in rolls inreasult use non-initilized
field as info source.
* Remove unused item guid field from Roll and not lost for nothing item
guids for this.

Thanks for help in research to TOM_RUS and j4r0d.
Restore lost `return` in prev. commit.
Remove a useless include
Fixed freeze after recent loot roll code changes.

Thanks to j4r0d for testing.
Really fix freeze :/
Add additional field for storage of speed_run rate of creature

This allow independent rate of walk vs run speed. Existing field renamed
to explicit speed_walk.
Note that default database rate for run is a result of the most common
value seen, 8.0/7.0
fixed mangos.sql
Fixed rest state remove at leave tavern
fix crash with ACHIEVEMENT_CRITERIA_REQUIRE_INSTANCE_SCRIPT

BattleGroundMap has no GetInstanceData() function
Fixed bug in instance binding in case heroic/25-man raids
difficulties

In fact typo in my old commit at adding support MapDifficulty.dbc.
Allow UTF8 strings via SOAP
Fix the amount of mana restored by spell 68082
Use area trigger zone check for inn leave case.

This is still have false cases but will more correct for specific area
triggers.
Also let cleanup code and store less data for Player.
create battleground map at bg creation

when a bg gets created it will also get it's map
(old behaviour was, that map got's created when first player entered the
instance)

the reason why battlegroundmaps aren't instantiated with a player object:
* the only information from player-class we need is
player->GetBattleGround()
also we can't use anything else
(e.g. playerlevel can be outside of bg-levelrange)
-> cause bgs depend pretty much on their maps this caused circualr
dependencies between map,bg,player
* battlegroundmaps will _always_ be prepared by the bgsystem to set
the proper data
* there is not much shared in the creational process with dungeonmaps
even the functioncall is different since players need to enqueue
first for bgs,
therefore again the player's way to that instance is only through
the bgMgr
update battlegrounds per map + cleanup at delete

this will be useful, if we have multithreaded mapupdates one day

since i couldn't reproduce any errors regarding to self deletions of
battlegrounds i removed the m_deleteThis variable
Adding a few research comments for unit_flags and rename one.

Mangos 9600 - 9620
restored work of DeleteAllBattleGrounds
check for UNIT_FLAG_OOC_NOT_ATTACKABLE in
DynamicObjectUpdater::VisitHelper

this will solve the problem that spiritguides could get attacked
(for instance with spell 2121)

thx to DasMy who helped with research
Simplify creating mail draft with content text, cleanup includes.
Implement use of UNIT_FLAG_PASSIVE for creature.

Add function to check creatures own ability to initiate an attack in
MoveInLineOfSight.

Prevent unexpected call to AttackStart when having unit_state
stunned/died
SetSummonPoint for any summoned creature.

Should fix a crash where summoned attempt moveRandom without having a
valid summon point.
Send packed caster GUID for AFLAG_NOT_CASTER.
Fix SMSG_GUILD_INFO time part.
Fix typo that broke guild creation timestamps
Send zoneUnderAttack from EventAI if creature is a guard.
Use more readble format for default `gossip_menu_option` values.
Add index for some tables in characters DB.
Add to SendMonsterMove var args for optional values.

Also drop currently unused Unit::m_InteractionObject
Use stdarg.h instead outdated varargs.h

This must restore build at *nix
Objects HIGHGUID_MO_TRANSPORT not have entry part in guid.
Send AFLAG_NOT_CASTER only if casterguid == targetguid.
Fix ByteBuffer::appendPackGUID appending a superfluous byte.
Add WorldPacket.h to vcproj files.
More use ObjectGuid in spell/etc code
Reset more UNIT_FIELD_FLAGS at login.

Resolve linking problems for script DLLs




YTDB 313
+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ fix spawn and pool for all viens
+ fix data "creature_equip_template"
+ Icecrown Citadel (Raids) - all modes: N10/N25/H10/H25 - ("alpha") - (No loot from Lich-King in heroics)
+ processed 260 caches (3.3.2)
+ Thanks YTDB forum & UDB forum & CTDB forum & TDB forum, for the WDB caches 3.3.2.
+ All fixes from forum (Look under Accepted Patches Section);
+ Spawns;
+ Quest scripts;
+ Mob's gossip menus;
+ New templates from WDB
+ Correction of the fields in "creature_template" following WDB
+ Correction of spawn in "Maraudon"
+ processed 204 caches (3.3.2)
- Icecrown Citadel (Raid) - Is closed for now (The spawns are fully completed including Lich King) , Loot is 99% completed on all the difficulties, we will polish Icecrown in the next commit (Lich King is under "Repair" there are some questions about him) + read cache topic (And help us out))

Added maps, buildings and dbc 3.3.3

Mangos 9621 - 9637
Typo in CastSpell.

Not affect code work except restore small code speedup.
Add keys for gameobject table.
Fixed typo in mangos.conf comment.
varargs list (...) auto promote any float value to double and any
less int type to int.
Add absent empty lines in end of sql updates.
Fix one wrong cast case and simplify similar debug output.
Make mail load async.
Fix typo from [8408].
Replace some PQuery/PExecute by more simple Query/Execute.
Remove character data blob.

Update will create backup in data_backup table, just in case...
You can drop this when you think you don't need it anymore.
(I would recommend you to keep it for a few days/weeks)
Forgot to use git_id
Fix enum names.


Restore load/save known titles.
Some code clean up.
Remove fields 'data' and 'zone' from corpse table.
Restore load/save shown action bars.
Move item real-time/in-game duration counting flag to new
extraflags field.

Client expected only positive duration values, so stop use duration field
as signed.
Include recent field into mangos.sql