Thread: Mangos + YTDB + Scriptdev2 + Changelog

thanks...!

Mangos 10525 - 10554

Code:

Add missing () to expressing for proper prio.
Implement server side global cooldown check.
Also pet/controlled unit global cooldown code replaced by new placed in charmInfo structure.

Thanks to nos4r2zod for testing and gcd range check implement.
Disable CombatSpell check for triggered spells
Run creature_movement_scripts also at first waypoint
Water level in movement use fixes.

* Move selection allowed upper and lower heights for target point
  into near point core function used for contact/close point selection.
  Selection base at possibility target point searcher fly/swim(or walk by water bottom).
* Use vamp water level data so have proper water level in instances in movements.
* Use increased ground search distance for water level case.
Fixed client reject any login attempt after WOW_FAIL_INCORRECT_PASSWORD receive.

Problem similar all all client versions.
Spells with SPELL_ATTR_EX6_NO_DMG_PERCENT_MODS must ignore all damage mods
Aura SPELL_AURA_ALLOW_ONLY_ABILITY not prevent auto-attacks.
Revert [10528], simply wrong (scriptId already called properly)
Fixed second and later resets schedule for raid/heroic after server restart.
Add optional argument to SummonCreature, summon as active object

When true, the summoned will be able to load grids as needed.
Extend SCRIPT_COMMAND_TEMP_SUMMON_CREATURE to set summoned as active object

Field data_flags 0x01 will enable active state
Fixe typo in command help text.
Fixing some comments in mangos.sql

Not all sql tools like the mix of comment styles in import of dump, so using inline style.
Use more near for final point coordinates for Z calcualtion.
Fixed structure SMSG_RESYNC_RUNES
Allow set afk/dnd message in afk/dnd state
Fixed ObjectGuid::IsUnit

Also some better string format for pet guid case.

Thanks to zergtmn for find problem.
Fix handling of spell 14157 and 14189 so they really apply combo points after current spell finished.

Also spell 70802 from new item set needs same treatment.
Output debug only note for known not implemented packets

This is packets that have allowed to receive setting (not STATUS_NEVER)
and WorldSession::Handle_NULL handler.

Mark some packets in this way.
Better way mark not implemented packets.
Fixed EffectActivateRune activate only expected runes amount of some rune type.
More correctly check delay time for spell with speed.
Implement missing part spell 47568 functionality.

Original patch prowided by False.Genesis.
At schedule second reset update real reset time.

Missing part of prev. related commit.

Also without this code at second reset after restart server will go to infinity loop.
Fixed field types in mangos.sql in consistant with related sql updates.
Fix 55880 proc
Add some vehicle flags, thanks to zergtmn and community
Two more cases where AURA_REMOVE_BY_EXPIRE mode can be used
Fix wrong procs when spell hits with no damage

Mangos 10555 - 10577

Code:

Remove not existed function declaration.
Add frand function for random floats with min/max, similar to urand
Add optionial arg to Unit::SetFacingTo which is passed to SendMessageToSet
Fix spell "Spinning" (64385) for item "Unusual Compass" (45984)
Add world state id in comments for all hard coded state id's
Remove reundenant spell store for temporary unsummoned  pet.

We not use this data and now always have proeprtly save current pet
when it temporary unsummoned and avoid it overwrite by another cases.
Avoid ask AI for direct controlled creature at attack.
Also fix warrning double->float in recent commited code.
Cleanup WorldSession::HandlePetAction

Also fixed attack target seelction base at packet content instead direct player selection.
Remove unneded arg for Unit::SendPetAIReaction.
Implement CMSG_PET_STOP_ATTACK.
Not allow charmed by player creatures have threat list.

Original patch provided by zergtmn.
Fixed loaded DBC  count.
Implement SMSG_SPELLINSTAKILLLOG
Revert VS90/game.vcproj changes in [10551]
Drop unused column 'realmid' from the table 'character_tutorial'
Don't save holders from channeled spells
Store spell entry of triggering spell on triggered, original patch provided by insider42
Properly remove dual-wield flag at spell unlearn.
Drop unused Spell::m_triggeringContainer
Add end file empty line to some files.
Fixed non-weapon offhand equip after my recent commit.
Fix world states related to arena season.

Replace the "in progress" option in config (as no such thing exist) with the expected "previous arena season id".
Prevent diseases to be dispelled while 50536 is on target
'shuttingdown' -> 'shutting down' in log

YTDB 344

Code:

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ processed 186 caches (3.3.5a)

Mangos 10578 - 10589

Code:

Use static call for IsBGWeekend in BattleGroundAV
Better wording in log for shutdown cancelled case.
TARGET_ALL_RAID_AROUND_CASTER include caster only for positive spells.
Rename some local variables in random move generator for easier reading
Add spell_proc_event data for some relic related spells.

Missing ones were 67356, 67363, 67365, 67379, 67381, 67384, 67386, 67389, 67392.
Remove dual ERROR in logs
Prevent lost aura connection with item at Aura::ReapplyAffectedPassiveAuras

Thanks to Lynx3d for research problem and testing.
Make GO type 10 become nice and shiny: sparkling animation and jingle bells

When GO is active for quest, same as GO type 3.
Also add comments for future development of gameobject dynamic flags
Update taxi mask size for 3.3.5a
Make GO type 5 sparkle at related quest active
Make GO type 8 activate and sparkle at related quest active
Always activate GO type 3 when quest id is defined (and active)

GO may be "lootless", but events at looting can happen

YTDB 345

Code:

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ repopulation of fishing holes
+ processed 192 caches (3.3.5a)

Mangos 10590 - 10610

Code:

Check if GO is requirement of quest to activate sparkle if it is
Simplify LoadGameObjectForQuests for case GO type 3
Make GO type 2 activate/deactivate

As with similar GO's that are not interactable (gameobject_template.flags|4) as default, GO's of type 2 becomes active when player can take a quest (or deliver quest).
Cleaning up code a bit, in related functions for recent commits
Use equal_range instead of lower_bound/upper_bound pairs

(based on zergtmn's repo commit 0499169)
Add new functions to Set/RemoveShortFlag (uint16, lo and high part of uint32)
Apply restrictions to vmap options.

After switch to new vmap version and later height check code chnages
some vmap related options now outdated.

* Option vmap.ignoreMapIds removed. You can't now diable vmaps use for selected maps.
* Option vmap.enableHeight must be always enabled for normal work server and server
  at startup now pring error if it's diabled. Option still supported just for special
  work cases (debug, new clients testing, etc).

Possible soon option vmap.ignoreSpellIds also will be removed, because like los ignore checks
must be in spell code instead options.
Enable by default vmap.enableHeight and vmap.enableLOS

mangosd.conf version updated.
Create enum GameObjectDynamicLowFlags and use instead of hard coded
Attempt fix data corruption for some localization structures with GCC use.

By unknown reason GCC generate wrong code for locale structures declared in header after pack pragma.
Correct size of animprogress for GO Create()

Add a default define and use it instead of hard coded value.
Some additional minor corrections for transport GO's
Amother attemp fix locale structures corruption.

Possible real source of problem: existing in code mixed
std:: structure templates instanting under pack pragma and out.
And this incompatible structure layouts wrongly mixed used by GCC.

So all std:: strcutures used moved out from pack pragma guards.
Add GO_DYNFLAG_LO_ACTIVATE to GAMEOBJECT_TYPE_GENERIC and merge similar cases.
Replace one hard coded value w/enum name. Additional code style cleanup
A couple more spell_proc_event entries for relics.

Missing items were 38360, 40714, 45509, 45144, 50454, 50455, 50456, 50457, 50458, 50459, 50460, 50461, 50462, 50464.
Fixed infinity loop at grid loading

this also probably solves the problem that object tries to be loaded twice
Fix loot for victims being creature type critter
Handle GAMEOBJECT_TYPE_GENERIC at Use() to trigger despawn of GO

In addition, a check is added to prevent unexpected call to Use() at received opcode. Despawn of this type GO can then only be used with explicit call to Use()
Update melee miss chance calculations...finally.

Also thanks to Revils for correcting effective skill for spells that don't use weapon despite being melee/ranged ability.
I consider it proven that all classes shall benefit from intellect for weapon skill increase.

But better formula for chance would still welcome...
I consider it proven that all classes shall benefit from intellect for weapon skill increase.

But better formula for chance would still welcome...

YTDB 346

Code:

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ fix spawn "Pit of Saron" from sniffs
+ processed 205 caches (3.3.5a)

Mangos 10611 - 10636

Code:

Made some values const
Revert "[10611] Made some values const"

Reason: It makes no sense to make a local variable const.

This reverts commit 49e3184d69056738701bc15d9b7f982bf11d7bbc.
A bit of cleanup in ByteBuffer::hexlike
Replace ACE_ASSERT with MANGOS_ASSERT
Add script effect of spell 66741
Simplified trade distance checks, GROUP_UPDATE_FLAG_POSITION flag handling moved out of Map

note: need avoid Map::PlayerRelocation calls now and use Player::SetPosition instead
Fixed array access in SCRIPT_COMMAND_TALK loading check.
Properly update objects usable state at GM-mode on/off.
Clarify premade groups mode config option.

Also prevent mark group as premade with 0 time wait.
It's any way useless becase at next tick group moved to normal team mode.
Fixed MSG_MOVE_HEARTBEAT structure.

Thx Wojta for pointing.
Add new field RequiredClasses for quest_template

* SkillOrClass is converted to RequiredSkill (and then field can contain skill id only)
* Field ZoneOrSort has no longer a function in quest requirement, and RequiredClasses must be used instead where class limits are expected.

To restrict a quest to one class or more, use bitmask of class in RequiredClasses. RequiredSkill works like before.
Set respawn delay for BG creatures before set dead state.

This prevent save to DB wrong respawn time and unexpected in wrong event state spawn BG creatures.
Make .respawn work correctly with BG event spawns
Fix quests w/QuestFlags QUEST_FLAGS_AUTO_REWARDED
Implement SPELL_EFFECT_CLEAR_QUEST (139)
Fix bad bandate check.
Fix logic in FillRaidOrPartyManaPriorityTargets and FillRaidOrPartyHealthPriorityTargets
Use ObjectGuid for player's selection and unit's target
SQL update for prev. commit
Drop function GuidHigh2TypeId

Added ObjectGuid version Aura::GetCasterGuid()

But for prevent big problen with backporting AuraHolder
to mangos-0.12 in most cases still used old uint64 version
Aura::GetCasterGUID.

Recommended use new version where possible in clean way
as done for some cases in commit already.
Convert Set(Get)ChannelObjectGuid to ObjectGuid way.

Also fix typo in debug output for prev. commit.
Small code style cleanup in quest related functions
Small comment style fix in mangosd.conf
Correct behavior for completion of quest objectives.

Rename related function to SendQuestCompleteEvent for clarification of when it's expected to be used.
Include non-percent mana cost in EffectDestroyAllTotems mana return.

Also small speedup for no-return spells.
Convert many opcode handlers to ObjectGuid use.

Also re-enabled anticheating check for bank window open
base at .bank command access rights.
Ignore another map target for text emote.
Implement server side check combo points req. for spell cast.

Thanks to nos4r2zod for problem research.

YTDB 347

Code:

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ processed 220 caches (3.3.5a)

Mangos 10637 - 10658

Code:

Better totem summon cases selection.

But added check still not allways work. Unclear better way selections for summon prop id 61
More appropriate for warrior spell fail result for combo point check fail.
Making dummy effect of spell 54530 be positive effect.
Implement instance guids with proper HIGHGUID_INSTANCE use.
Fixed use item dynamic/item proto flags.

* List its independelty. Each from this 2 fields have own flags. Cleanup lists.
* Not copy proto flags to item flags update field. This fix heroic item versions
  show in client in result mixed use ITEM_DYNFLAG_WRAPPED (0x8) with ITEM_FLAG_HEROIC (0x8)
* Update uses to proto case use for some cases where before wrongly has been used item dyn.flags
* For ITEM_DYNFLAG_UNLOCKED (0x4) set for item at unlock and check for prevent re-unlocking.
  This mostly for future case when will be implemented partly loting items support.
* For ITEM_FLAG_LOOTABLE (0x4) check loot absent or conflicting setting with containers/casted at use items.
  Report wrong cases art loading.
* Better check related loot tables content using ITEM_FLAG_PROSPECTABLE and ITEM_FLAG_MILLABLE
Implement spell 56826
Update the ACE part we use to 5.8.2
Remove wrong check preventing lootable itesm have at-use spell casts.

But note: like at use spells cast at loot open not implemnted yet.

Also fixed typo in ITEM_DYNFLAG_READABLE.
Use more make sense corpse expire check timer period.

Use 3 hours timer when bones really expired by Corpse::I***pired code each 1 hr
just lol ;) So restore old 20 min time used long time ago.

Thanks to TGM for pointing to patch.
Preserve creature dynamic flags at UpdateEntry
Show die animation at totem destroy.

Or any creature type die with linked unsummon.

Original patch provided by Eggxp.
Typos in mangosd.conf.dist.in

Also thanks to Marik for additional typo fix and diff preparing
 Enchanted spell 8017 and ranks should apply to weapon by client auto selection
One more typo in mangosd.conf.dist.in
Fixed combat log being bugged by pets without name
Allow set pvp flags from creatures *_addon data
Implemented MSG_MOVE_KNOCK_BACK opcode

 * Player's knockback movement now smooth and doesn't looks like teleporting
 * Cleanup WorldSession::HandleMovementOpcodes, separated opcode specific and generic movement handlers code
 * Handle Feign Death aura interrupting into more appropriate place
Allow creature to offer same quest for more than one game event
Add support for monthly quests

Quest that can repeated each month are set by quest_template.SpecialFlags |0x04 flag
Quest are reset at midnight the first day of each month.
Note: for the time being, quest must also be set repeatable (SpecialFlags |0x01)
Rename quest function HasFlag to HasQuestFlag
Separate quest_template.QuestFlags from SpecialFlags

Create enum for SpecialFlags (database flags and internally computed)
Added related functions for specialFlags and update code accordingly.
Add enum as argument for quest special/flags functions

YTDB 348

Code:

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

Long time no updates


Mangos 10659 - 10737

Code:

Fixed mistake in [10653] that causes player to fall from the transport at teleporting to another map
Make quest for game event be independent of source

Create new table and convert existing data.
Simplify how game event quests are activated during event by adding generic function to set quest active/inactive.
Any quest in game_event_quest are disabled until event start (and deactivated once stopped)
Update VC10 filers for new ACE
Implement partly item looting

* Not deleted normal item loot at first loot window close.
* Save current item loot content to DB for later continue looting.
* Cleanup spell effect SPELL_EFFECT_OPEN_LOCK check code
* Cleanup Player::AutoStoreLoot calls
Fix totem animation at normal unsummon.
Rename arena_team_stats fields for better fit to stored values.
Allow use faction data for cases raceMask==0

Also some related code cleanup
Implement ACHIEVEMENT_CRITERIA_TYPE_HIGHEST_*_RATING
Timed Achievements, Fail-Support and Opcodes
Implement CONDITION_*ITEM_WITH_BANK conditions.

Similar CONDITION_*ITEM but including character bank content in counting.
Fixed mana amount for overheal case for talent 31785 and ranks.

Also thanks to Wojta for patch code improvements.
Restore build at real C++ compilers after recent timed achievements commit.
Convert some Unit owner/etc guids to ObjectGuid way.
Allow damage own pet in sanctuary.

Also mome repeating code to new function.
Include `item_loot` into pdumps
Show some SPELL_AURA_MOD_DODGE_PERCENT auras as debufs as expected.
Ignore BOA items reputation requirements at use.

Item reputation requirements checked at buy, and in quest case
related quests expected to have own reputation requirements
preventing rewarding items with not fit reputation requirements.
Fix repeating looting for milling/prospecting.
Send to creature/etc Update call real diff from last update and use it.

Now in case when creature/etc some tices not updates in result stay
in not active (no near players or active objects) cell some important
timers (corpse decay, summon timers, group loot expire, aura durations, etc) will
updates at real diff time from last prev. update call.

For some systems added exclude use real diff time because current limitations
like move generators. So its stay use last tick diff and considered freeze and
skip all time while creature in not active map part.
Revert "[10675] Ignore BOA items reputation requirements at use."

This reverts commit 4ce902e5d9c3cfc635c0eff1ba3552da5ecd0c5b.

Check done at client side so useless skip it at server side.
Proper fix expect show diff items in vendor list depndent from required reputation.
New table `npc_vendor_template` for comon item data for diff vendors.

In vendor list show own vedor items + template ites if any.
Vendor template item lists selected by id stored in creature_template.vendor_id
Update item buy code for new way vendor item lists work.
Added new Cell::Visit* functions to visit grids with center in (x,y) coords

* This fixes possible problems with Spell::FillAreaTargets(center of search should be (x,y) position, not spell caster's position)
* Cleanup Cell class, removed old and unused code
New table 'item_convert' for convertion items.

* Implment vendor at show replace BoA item with reputation requirement
  by identical item without rep. reqs for player that fit this requirements
  of original item.

* Table also can be used for store item convertion data form one team items
  to similar other team items. This case not impement but added function easy
  used for it.

* Note: strict single convert for item not created problem for both way use:
  item converted for same team or all, can't be original item for conversion to
  another team.
Revert "[10677] Send to creature/etc Update call real diff from last update and use it."

This reverts commit 10784a8c7cc81c468b5411e973d36ecf31de9603.

Main reason: impossibility for me as commiter test problem and fix all corner cases problems.
Fixed mangos.sql `creature_template` default content after adding vendor_id
Fixed creature_template loading after vendor changes.

Thanks to insider42 for problem research.
Update outdated comment
UInt32 timer class copies instead using time_t timers for mstime cases.

Also cleanup weather update code and some random code cleanups.
New version of patch for send real diff from last update.

In new version last update time stopred for specific Cell that store all world objects
placed in it. All objects of Cell updated (or not updated) in same time.

Original version provided by ciphercom.
Restore some item checkes for temporary loot case.
Fixed *nix build problem after recent commits.
Add dummy effect of spell 53475, 53487 and 54015
Fixed some GCC warnings and code errors.

Thanks to freghar for provide cleaned list of warning messages.
Fixed wrongly use %d for guids in DB queries.

This can affect correct result in cases big guid values
(out of range for possitive part of int32 range) at x86 platforms.

Some other cases addded in addition to original patch fixes
where %d wrongly/unsafe used for unsigned values.
Update SpellEntry based on the work of TOM_RUS
Use portable ACE way msecs time value calculation

Avoid use unsafe code for non-Windows platforms
Thanks to Marik for research the problem and Ambal for helping me with this patch
Cleanup some death state enums usage.
 Avoid selection despawned creatures as spell autoselected targets.

Original patch provided by virusav.
Less strict check for update at war state for factions

Clarify in comments of recent added spell dummy effect
Compute cell area bounds for active objects in the same way like it done for players
Add debug note for not implemented summon property group
Remove unused structure GridUpdater.
Correct check percent spell costs in AI::CanCast

Also use uint32 for spell cost fields/results
Fixed loading mails broken after [10692]
Check SPELL_ATTR_IMPOSSIBLE_DODGE_PARRY_BLOCK for special attacks.
Add the option to close gossip window in gossip system

Field action_menu_id in gossip_menu_option table can be set to -1 where close gossip is expected, instead of sending a new menu.
Simplify CellArea calculation
Implement talent 30326 for spell 5138.
Move Glancing Blow early in melee outcome results.
Update ACHIEVEMENT_CRITERIA_TYPE_LOOT_* with group roll.
Prevent wrongly use transport guid as unittarget in spell targets
Fixed typos in my previous commit
Check localization data for existance main table entres.

Data will skipped for nonexistent entries, and reported with
disabled LogFilter_DbStrictedCheck filter.
Startup checks for `gossip_menu` and `gosip_menu_option` table data.

Existance `gosup_menu` id refercned from gameobject field and unused meni ids
activated only with disabled LogFilter_DbStrictedCheck.
player/group instance binding fixes.

* Use anum instead raw uint8 type in args
* Fixed crash when gm at continent invite to group gm in instance
  and then teleport to instance using .goname.
  When group leader teleport to instance it must get group bind instead solo bind.
* In other semilar cases detection report error as before but replace solo by group bind instead
  assert crash at enter to map.
Avoid unexpected error at action_menu_id < 0 after recent loading checks adding.
Fixed move in inventory items with ItemLimitCategory.
Typo show commit before revet all realddiff one more time.

Typos show that in fact "working" has been result typos diabled state for relamd.
Cell-based way have not avoidable problems with case when object added to not active
long time Cell. If someone find more working sollution it can be readded ofc.
Revert "[10716][10688] New version of patch for send real diff from last update."

This reverts commit 8398a55fa274471daae115e00c627b299a3fdbbd.
This reverts commit 06e2d6859ba3d7fd47be72c23a64e68ae039701f.
Partly revert "[10687] UInt32 timer class copies instead using time_t timers for mstime cases."

This reverts commit 967877fefd91e00895f9790dc006b532b94d41b7
in part MapManager/World timers.

Main reason: unclear source cases wrong mstime diff generation at WorldRunnable level at *nix systems.
So need have existed in past hacks that skip its.
Implement proper calculation quest honor reward.

Now server side rewar same as reported at client side.

Also thanks to KiriX for patch prepering to commit and testing.
Implement check `gossip_menu_option`.`npc_option_npcflag`.

For cases main menu options used by creature but impossible show in result absent
related npcflags for any creatures used that menu.
Use required_quest instead of _heroic for non_instance areatrigger teleport
Fill target map for TARGET_RANDOM_NEARBY_DEST(b) cases.

Corrects ~35 spells, where most has summon effects.
Backports from 400 branch.
Add dummy aura effect of 51405 and dummy effect of 51420
Fixed wrong error message for quest related areatriggers.
Fix TARGET_AREAEFFECT_CUSTOM, need to obey type when DB target entry exist
Add a few comments for SUMMON_PROP_TYPE_CRITTER
Correct one SQL in tools, table was renamed.
Map system re-engineered. Special thanks to Blueboy for tests.
Fix Deathly Stare spell
Add dummy aura effect of spell 47178 and dummy effect of 47176

Note: see comments in code for spell 47176
Check if Pet's target is a valid target (isTargetableForAttack)
Remove redundant isAlive-check, thanks LordJZ for notice
Not send session fields as args into HandleMoverRelocation/VerifyMovementInfo.

Also mark args as constant where expected in this functions.
Implement defencive guardians pet type for creatures like 28120
Rename and clarify SummonPropertiesEntry.Type->Title field meaning.

This also show why we have some problems with sorting sumons by types base at this field.

Thanks to TOM_RUS for research.
Fixed spell 51420 work by use recently added protector pets as expected.

Thanks to NoFantasy for problem research (and prev. new pet type adding case research aslo) ;)
Fixed  unexpected typo in prev. commit.

YTDB 351

Code:

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus