Thread: Mangos + YTDB + Scriptdev2 + Changelog

Mangos 10155 - 10168

Code:

Add script effect of spell 66744
 Add shared object for auras of same spell and move spell proc code to 
its own file, also spread procs by auras and effect indexes.
Fix makefile and make gcc happy.
Fixed 2 format args errors in debug output.
clean-up after recent changes
Fix sql for character_aura and pet_aura
Add bzip2
 Added libmpq to dep/

This is from official repo (SVN rev. 300)

Additionally includes free implementation of stdint.h and dirent.h for VC++,
aswell as Visual Studio project files.

Special thanks to faramir118 for Windows support.
 Update vmap_extractor to support new vmap implementation.

Note: This is not compatible with current assembler, wait for upcoming commits

* Now also supports Linux (CMake) and Visual Studio 2010,
  see README for build and use instructions
* Uses libmpq for now, since at project start stormlib did not work
  properly on 64bit linux.
* Should be a lot faster, a few badly written lines ate most CPU time for
nothing...

Special thanks to arrai and faramir118 for additional code and fixes
Update vmap_assembler to upcoming new implementation

* Note: vmap_assembler tool will not compile until final commit of new vmap 
system
* Now also comes with Visual Studio 2010 project files and CMake files
New collission system (vmap) implementation

Important:
* You have to re-extract and assemble vmaps
* Update your config file, new option 'vmap.enableIndoorCheck' added

New features:
* Include WMO+DBC area information for correct subarea identification and indoor 
check
* Support for WMO liquid (fishing/swimming in cities, instances and oterh WMO 
based environments)

Technical changes:
* New Bounding Interval Hierarchy (BIH) data structure for better performance
* Referenced model data for reduced memory usage,
  needs more files, but reduces overall file size from ~1.9GB to ~550MB

Additional Authors:
arrai (DBC handling and indoor detection)
faramir118 (windows support and bug investigation)
And of course thanks Vladimir for a lot of patience and support!
Romve now unused Stormlib, it also included a redundant copy of zlib.

Note that WoW 4.x support for libmpq still unclear, but in any case
this Stormlib version is outdated too and will not support it either,
even if we need to switch back.
Bump vmap extractor version to 3.00
Add dummy aura effect of spell 32045, 32051 and 32052.

YTDB 331

Code:

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new teplates from WDB
+ update table "*_template" by WDB
+ data from sniffs
+ processed 437 caches (3.3.3a)
+ processed 15 caches (3.3.5a)

added

Reamld sql full
characters sql full

Mangos 10169 - 10189

Code:

New config option Quests.IgnoreRaid

It allow if enabled (disbled by default) do non-raids quests in raid.
Fixed typo in prev commit :/
Clarify acoount password/lock command errors.
Make git and users happy with contrib/vmap_extract_assembler_bin/make 
vmaps.bat

* Unix encoding
* Never never use in any cases not only mangos filenames with spaces. Tools can 
generate
  expected nightmare level without like help from your side ;)
Fix infinity loop in 31884 spell code
Fix special targeting for spells 812/9347.
Fix incorrectly blocked line of sight in certain locations.

I really should know by now that floats are not infinitely precise...
Use std::isnan in the hope more non-MS platforms provide it.

Note that G3D::isNaN() is simply wrong IMHO...and not even inlined.
One day, there will be a usable C++ standard not light-years behind good old 
C...
Add custom code for triggered part of spell 39105
Clean up some comments and align/indent as done for similar spell code.
Add "missing" spells in commented form for Aura::TriggerSpell()
Implement ITEM_FLAGS_NO_EQUIP_COOLDOWN support.

Also server side check for ITEM_FLAGS_INDESTRUCTIBLE
Fix spell 55681. Thanks Danstahr.
Allow stacking some tracking bufs, and prevent stacking some other.

For example item 25548 buff expected to be allowed stacking
but spell 19885 not allowed.
Better tracking stack checks with include one not catched non-stacking 
case.

Spell 41446 expected to be non-stacking with other trackers.
And tradition typos :(
fix auras adding to previously added holder
Fixed SMSG_BATTLEFIELD_STATUS packet.
Fixed visibility constant refresh problem with pet direct control 
spells.
 2 non-sense code lines cleanup.
Add missing locales to vmap extractor.
Update realmd opcode list.

Thanks to Phazerz for helping with research.

Mangos 10190 - 10227

Code:

Fix another numerical corner case...

...hopefully the last one.
Slightly different approach to tree bound intersection.
Update vmaps extractor/assembler binaries using vs2008.

* This make some ppl happy who not have installed VS2010 runtime.
* Also vmap assembler include recent fix for absend locale support,
  that ofc only affect ppl who before can't use assembler with this locales 
  supporting client.
* Also small update for vmap extarctor project .gitignore
Small cleanups related target effectMask check.
Use for Transport::Update arg uint32 type as for other world objects
Fix "Documentation" filter in ACE VC 10.0 project
Some gender dependent spells
Use enum for instance reset event types, some related cleanup code.
Fixed typo in enum value name.
Add to `playercreateinfo` original player orientation field.

It still not filled. Patch with correct values welcomed ;)
Partly revert old changes in load instance reset time.

* Its has been added for raid/heroic instances in time adding
  support MapDifficulty.dbc. Its wrongly assign reset events
  for each instance instaed use generic event for map/difficulty pair.
  In result at this event triggering instance can be attempt resetted
  multiply time.
* Also comment this in InstanceResetEvent fields notes
Fix 33763 and ranks final heal and mana return on dispel and on expire
Correct function call sequence in possess aura handlers

also removed not needed ResetView call in dummy aura handler

(based on SilverIce's repo commit c3f02ed)
Broadcast packets only if worldobject is in world

There is no sense to do that for objects that not in world - those objects are 
unknown for clients
and their packets will be ignored

(based on SilverIce's repo commit 6305402)
Rename isInFlight() to IsTaxiFlying() and UNIT_STAT_IN_FLIGHT to 
UNIT_STAT_TAXI_FLIGHT.

Also add IsFreeFlying() function to Player class.
Rename `item_template`.Faction to Flags2 and define some values for it.

Thanks to Shauren for research flag ITEM_FLAGS2_COST_REQUIRES_GOLD meaning
and inspiring in general what must be done long time ago with field rename
and other enum values listing.
Add one more known value for item flags2.
 Correctly implement flying mount restrictions in zone 4395 by use of 
special area flag.

Also drop existing spell_area entries if exist, workaround not needed anymore.
Implement ITEM_FLAGS2_HORDE_ONLY and ITEM_FLAGS2_ALLIANCE_ONLY

* Check item_template data
* Check at equip/use
* Skip at loot if not compatible
* Skip in vendor list if not compatible
Implement ITEM_FLAGS2_EXT_COST_REQUIRES_GOLD use instead sign of 
ExtendedCost field.
Add proper data for character orientation at creating.
Output leaned before disabled ranks at talent re-learn or spec swith in 
proper order.
Do unmount at expire restricted flight zone debuf if still in restricted 
zone/etc.
Fix aura procs for spells with auras that can't trigger
Fix iterator update in Unit::RemoveNotOwnSingleTargetAuras
Implement ITEM_FLAGS2_NEED_ROLL_DISABLED.
Small final (as i think ;) ) fixes for restricted flight zone

* Fixed my horriable typo in 58600 effect code. Thanks to zergtmn for pointing 
to it.
* Remove redundent cast 45472 in 58600 effect code (it casted from 58601 
already). Thanks to porteyoplait.
* Prevent restart 58600 debuf timer at temporary leave zone and return to it.
Implement ROLL_VOTE_DISENCHANT disable

* for player without reqired enchanting skill
* for item without disenchanting possibility
Re-implement ROLL_VOTE_DISENCHANT disable case

Also implement NEED_BEFORE_GREED disabling ROLL_VOTE_MASK_NEED
instead skip item as expected in recent client changes.

Thanks to TOM_RUS for help in understanding proper way work.
Hmm, maybe i still do wrong something... ^^

Also count disenchnt roll as greed in ACHIEVEMENT_CRITERIA_TYPE_ROLL_GREED
Update playercreateinfo_action/playercreateinfo_spell

* Drop some food action buttons
* Drop attack spells for caster classes
* Use expected simlifed spell version 20154 (it replaced by full version at 
learn spell 53408 and similar)
  In code used helper code for support 2 versions as fake non-stacking ranks.
* Some other old "max ranks" of talents and spells now are permanent bonuses 
known from start (only "max rank" for spell exist)
Restore trinket procs when no specific spell is defined for proc
Fix spell 36032 stacking and procs
Fixed typos in mangos.sql

* Typos in `1playercreateinfo_*` tables. Thanks to Astoria.
* Lost recent field rename in `item_template`. Thanks to bobi88.
Fixed visual bug that some deleted auras still show at client side

(based on commit b10058e)
Restore proc events at full miss/immune spells to target.
Implement spell 44572 affect to permament stun immuned targets.

This also fix unexpected triggering effect any unrelated spell casts.
Small code style cleanup.
Propertly show empty vendor list for empty item list.
Fixed GO_JUST_DEACTIVATED for despawned by default gameobject.
 Generate gameobject loot only at open spawned gameobject.

YTDB 332

Code:

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ "quest_template" for 3.3.5a - FULL sniffs
+ "quest_poi" for 3.3.5a - FULL sniffs
+ "quest_poi_points" for 3.3.5a - FULL sniffs
+ processed 40 caches (3.3.5a)

Mangos 10228 - 10246

Code:

Missing send packet in empty vendor item list case.
Small cleanup in taxi related checks
Avoid use enum valuse/define like naming style for enum type name.
 Use VMAP::VMAPLoadResult instead raw int loadMap result.
 Fix mechanic-related check, thanks to VladimirMangos
Fixed check in SpellAuraHolder::HasMechanicMask
Fix typo in IsNoStackAuraDueToAura()
Cleanup in pet stable handlers
Implement SPELL_AURA_OPEN_STABLE (292).

(based on Wowka321's repo commit 213ceb0)
Implement additional damage proc on hit for Spell 8024 and ranks.
Set flag for offhand melee spells to allow proper triggering of 
weapon-specific effects.
Fix mangos.sql

I just had to forget one thing...
Fix some spells proc from spells that don't deal damage/heal
Fix expired spell interrupt
Rewrite internal work chat command system.

* Use single command search function with recursion and reuse it in now more 
simple
  and consistent for execute/help/loading
* Add intergiry checks for hardcoded part of commands list. Fix some cases base 
at it.
* Fixed diff small problems in past code:
  - in console single symbol commands rejected (without dot start)
  - .help not output propertly subcommands list for not found subcommand
  - some other...
Traditional crash fix :/
Implement .stable gm command for open pet stable anywhere.

Maybe command not so useful for stable case because spell can be learned,
but it example how can be packet allowed depndent from player possibility
when some functionality base at many packets recieved from client.
Same way possible can be used for auction anywhere, maybe some other cases.

Also it will very usefull for 2.x/1.x branches where no another way... ;)
Allow have custom starting area team/personal rating.
Restore work killCredit and kill achievements in regular difficulty 
instances.

YTDB 334

Code:

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ processed 73 caches (3.3.5a)

Mangos 10247 - 10269

Code:

Prevent lost items at problems with auction loading.

This will prevent adding to DD item data garbage not accessable from anywhere.
Now item will mailed back to owner.
Implement applying proper penalty spell when making use of talent 46917.
Don't interrupt area effects for channeled spells from target side
Select auction store by house id only.

After this commit auction auctioneer guid used only for select auction house in 
packet or loading.
Next task replace it in DB by houseid, dependence DB data from creature guid 
isn't good.
Clarify error message for one from redundent `commamd` data case.
Implement reputation_reward_rate for quests and creatures

* In addition, implement "flat" reputation for quests, where a value in 
RewRepValueN is given. Human diplomacy will not affect the total. The rate 
however will be applied, where a faction is defined with a rate for quests. 
Value in database are expected to be *100 of the actual value given (before rate 
are applied).
* New database storage can contain rates for quest/creature/spell reputation and 
will affect the base value given as reward. When for example the quest reward 
for a faction should receive 30% more reputation points, the rate can be set to 
1.3.
* This will fix issues with certain quests that are using the expected 
RewRepValueId but where the outcome has been lower than expected.
* Note that if the rate is set to 0.0 it will disable reputation gain for the 
faction and type.
* Reputation rate for spells (spell effect) is not yet implemented
 Small cleanup in Unit::HasAura() to prevent redundant upper_bound calls.
Remove dependence auction data from auctioneer guid.

* Field `auctioneerguid` replaced by `houseid` and table reanmed to `auction`
  (it list auctions and `id` is auction id).
* Update related code.

* SQL update fill `houseid` field by old `auctioneerguid`
  BUT: SQL update expect that you world DB named `mangos`.
  If this not true for your case you need modify SQL update BEFORE APPLY
  in 2 placed in part "mangos.creature AS c, mangos.creature_template AS ct"

* Another small possitive result: now possible easy select auctions related
  to some auction store (1-3 is one team actions, 4-6 another team auction,
  and 7 is neutral auction store for both teams
Fix aura remove in Unit:: _UpdateSpells
New `auction` command with subcommands for look different auction stores 
from anywhere.
Fixed typo in "alliance" in recent commit changes.
Correct old typo in GetReputationOnKillEntry function name
Fix some iterator in Aura::HandleAuraModShapeshift
Move pre-0.16 release sql updates to subdir
 Revert [10259] -_-
Fixed table `auction` name in characters.sql
Not allow listing pool elements in more one pool.

NOTE: sql update remove forbided by commit duplicates from pool_* tables in 
random way.
      So for more porper results DB better manually check and fix before apply 
      it.
      This is mostly note for DB projects devs.
Fixed build at Unix after auction changes.
Add comments for fields in struct FactionEntry, related to rep spillover
Implement CONDITION_ACHIEVEMENT and CONDITION_ACHIEVEMENT_REALM
Fixed typo in comment.

Also thanks to SkirnirMaNGOS for pointing to this long existed patch.
If schoolMask present for proc, ignore SpellFamilyFlags check
Fixed typo in CONDITION_QUESTAVAILABLE fail case.

Not affect mostly code work, because used only for not existed quest data,
that checked at loading. So only possible at reload quest templates with
drop related quest.

Mangos 10270 - 10279

Code:

Implement basic system for reputation spillover

* Database table needs data for each faction that should give spillover to other 
faction(s). One faction may give spillover to max 4 other spillover factions.
* The spillover rate is multiplied with the points after bonuses and reward rate 
is set, Rate is given as: 0.5 for 50% gain, -1.0 for 100% loss, etc
* It is possible to restrict spillover faction by rank. If player has a higher 
rank with the spillover faction given in database, no spillover will be given 
towards this faction
 Include ObjectMgr.h to reputationMgr, helping *nix compilers to know 
what to do
Add option for search distance to getHeight() functions and make 
Creature::FallGround() use VMaps properly.

This finally prevents flying creatures from falling to infinity (basically 
instantly diappearing) in several instances,
aswell as prevent creatures from falling inside larger solid object around the 
world.

Default height search is untouched, needs more research on how creature AI etc. 
will be affected.
Avoid some redundent and recursive calls to SpellMgr singleton.
Make gcc happy after last commits. Restore Unix build.
Fix initialization of DoSpellBonuses
Use more appropriate vector container instead of list as container for 
CreatureEventAI holders

vector container provides less time to access to contained elements
Use typedef CreatureEventAIList, some other code style cleanups in 
EventAI code.
Reserve space for EventAIHolder container
Unused function declarations after aura holders.

Bad post