Mangos + YTDB + Scriptdev2 + Changelog

[DjAligator]

Mangos + YTDB + Scriptdev2 + Changelog



If Mangos 9667+ dosen't work on x32 then it work on x64
If Mangos 9972+ dosen't work with .NetFramework 3.5 then it work with .NetFramework 4
If you want to post this releases on other websites you can but please write whos is the original poster. Also if you want me to post this releases on your forum or other contact me.



Red- New Releases
Blue- Little old Releases
Green- Old Releases








Mangos


Mangos 10894 (http://bitshare.com/files/6w9mc57g/Mangos-10894.rar.html)
Mangos 10866 (http://www.megaupload.com/?d=WNACWIWC)
Mangos 10834 (http://www.megaupload.com/?d=EZK24488)
Mangos 10792 (http://www.megaupload.com/?d=F3GL8FCM)
Mangos 10777 (http://www.megaupload.com/?d=UOMWZPNG)
Mangos 10737 (http://www.megaupload.com/?d=FAQXWDZE)
Mangos 10658 (http://www.megaupload.com/?d=XZ685F19)
Mangos 10636 (http://www.megaupload.com/?d=8G79ZO0E)
Mangos 10610 (http://www.megaupload.com/?d=FBJB3NEF)
Mangos 10589 (http://www.megaupload.com/?d=M8IR99J7)
Mangos 10577 (http://www.megaupload.com/?d=PJLGDV0W)
Mangos 10554 (http://www.megaupload.com/?d=WMACO480)
Mangos 10524 (http://www.megaupload.com/?d=YKRDDWDS)
Mangos 10512 (http://www.megaupload.com/?d=U35X7R5L)
Mangos 10502 (http://www.megaupload.com/?d=U82EBJPS)
Mangos 10489 (http://www.megaupload.com/?d=Q97J6UFC)
Mangos 10446 (http://www.megaupload.com/?d=3TTD9PWC)
Mangos 10422 (http://www.megaupload.com/?d=DOVAVHVE)
Mangos 10403 (http://www.megaupload.com/?d=TS567WGD)
Mangos 10380 (http://www.megaupload.com/?d=073AL68F)




Mangos Update SQL


12/20/2010 (http://bitshare.com/files/mrro0fxr/updates-mangos.rar.html)
12/13/2010 (http://www.megaupload.com/?d=FGMGEWI1)
11/29/2010 (http://www.megaupload.com/?d=FQWZZA7U)
11/22/2010 (http://www.megaupload.com/?d=80ETPDU4)
11/18/2010 (http://www.megaupload.com/?d=YDTAJPNA)
10/30/2010 (http://www.megaupload.com/?d=479B7EPK)
10/21/2010 (http://www.megaupload.com/?d=F55ES9XA)
10/15/2010 (http://www.megaupload.com/?d=XX2LRZE4)
10/08/2010 (http://www.megaupload.com/?d=LL19CH12)
10/03/2010 (http://www.megaupload.com/?d=DH5X0U1G)
9/28/2010 (http://www.megaupload.com/?d=3SUX5RBH)
9/18/2010 (http://www.megaupload.com/?d=IKZ9AUQ6)
9/15/2010 (http://www.megaupload.com/?d=ZBNOWXL2)
9/05/2010 (http://www.megaupload.com/?d=1Q5OI8J6)
8/29/2010 (http://www.megaupload.com/?d=XYI50Z97)
8/24/2010 (http://www.megaupload.com/?d=Y7VB5BOB)
8/19/2010 (http://www.megaupload.com/?d=D6SNUA4X)




Scriptdev2 Update SQL


Update 1913 (http://bitshare.com/files/njkmh678/Updates-scriptdev.rar.html)
Update 1892 (http://www.megaupload.com/?d=6M76NKXA)
Update 1906 (http://www.megaupload.com/?d=3OG2JDBF)
Update 1886 (http://www.megaupload.com/?d=5LN13LYP)
Update 1884 (http://www.megaupload.com/?d=TXVHBGU9)
Update 1847 (http://www.megaupload.com/?d=ZJJW2AS4)
Update 1844 (http://www.megaupload.com/?d=ZVQJVWVE)
Update 1842 (http://www.megaupload.com/?d=TVJQU5N4)
Update 1837 (http://www.megaupload.com/?d=QHZUGNFR)
Update 1833 (http://www.megaupload.com/?d=FPN5LT8U)
Update 1828 (http://www.megaupload.com/?d=59BWNKPT)
Update 1827 (http://www.megaupload.com/?d=F71TQ00S)
Update 1823 (http://www.megaupload.com/?d=NAE5EUZS)
Update 1816 (http://www.megaupload.com/?d=FRHXLG78)
Update 1815 (http://www.megaupload.com/?d=R5ZDBBL6)
Update 1801 (http://www.megaupload.com/?d=0U2D1OF3)
Update 1782 scriptdev2_script_full (http://www.megaupload.com/?d=G1DTB9JW)




YTDB


YTDB 357 (http://bitshare.com/files/d22zg45b/Updates-ytdb.rar.html)
YTDB 356 (http://www.megaupload.com/?d=RRAIFNF0)
YTDB 355 (http://www.megaupload.com/?d=AUWG73IT)
YTDB 354 (http://www.megaupload.com/?d=I4VLOZSE)
YTDB 353 (http://www.megaupload.com/?d=0H2VLCUZ)
YTDB 351 (http://www.megaupload.com/?d=DVE9N7WP)
YTDB 348 full db (http://www.megaupload.com/?d=XRG5D61B)
YTDB 347 (http://www.megaupload.com/?d=38XAXTWT)
YTDB 346 (http://www.megaupload.com/?d=MB8SHOIT)
YTDB 345 (http://www.megaupload.com/?d=5O9M6Z61)
YTDB 344 (http://www.megaupload.com/?d=ZIUPBWC0)
YTDB 343 (http://www.megaupload.com/?d=5GY7H9QI)
YTDB 342 (http://www.megaupload.com/?d=FFPCXL73)
YTDB 340 (http://www.megaupload.com/?d=XWM6TWKD)
YTDB 339 (http://www.megaupload.com/?d=IDNSMLNW)




Maps


Maps 3.3.5 (http://www.megaupload.com/?d=KJ9VGY4D)
Maps 3.3.5 (http://www.megaupload.com/?d=QP01K3H9)
Maps 3.3.3 (http://www.megaupload.com/?d=OPARFQII)
Maps 3.3.2 (http://www.megaupload.com/?d=2EZVVX3K)
Maps 3.3.0a (http://www.megaupload.com/?d=ASJK99ZI)
Maps 3.2.2 (http://www.megaupload.com/?d=567I3DVW)




Buildings


Buildings 3.3.5 (http://www.megaupload.com/?d=IIFLKN44)
Buildings 3.3.5 (http://www.megaupload.com/?d=UDNEUIJY)
Buildings 3.3.3 (http://www.megaupload.com/?d=567COPN0)
Buildings 3.3.2 (http://www.megaupload.com/?d=C881MDG9)
Buildings 3.3.0a (http://www.megaupload.com/?d=96MIKG6R)
Buildings 3.2.2 (http://www.megaupload.com/?d=67DA3N2Q)




DBC


DBC 3.3.5 enGB (http://www.megaupload.com/?d=V26AALSD)
DBC 3.3.5 enGB (http://www.megaupload.com/?d=OAGSSWBT)
DBC 3.3.3 enGB (http://www.megaupload.com/?d=03S8Y1YY)
DBC 3.3.2 enGB (http://www.megaupload.com/?d=VKWOEMD6)
DBC 3.3.0a enGB (http://www.megaupload.com/?d=JCNVOKIY)
DBC 3.2.2 enGB (http://www.megaupload.com/?d=GDPO3UED)



Characters SQL Full


Characters 3.3.5 SQL ( 7/9/2010) (http://www.megaupload.com/?d=Q3AD4LRY)
Characters 3.3.3 SQL (http://www.megaupload.com/?d=JJKLEDR5)
Characters 3.2.2 SQL (http://www.megaupload.com/?d=STWHR46P)
Characters updates sql (http://www.megaupload.com/?d=W2JSZ06W)
Characters 3.2.2 (http://www.megaupload.com/?d=KK9SOENG)




Realmd SQL Full


Realm 3.3.5 SQL ( 7/9/2010) (http://www.megaupload.com/?d=60GG7FOP)
Realm 3.3.3 SQL (http://www.megaupload.com/?d=51I8U4JK)
Realm 3.2.2 SQL (http://www.megaupload.com/?d=JL6K3RVY)
Realm update SQL (http://www.megaupload.com/?d=JL6K3RVY)
Realmd updates sql (http://www.megaupload.com/?d=JL6K3RVY)
Realmd 3.2.2 (http://www.megaupload.com/?d=LFE4P6SM)




.NetFramework


If .NET Framework 4 dosen't work use this x86 (http://www.megaupload.com/?d=F4EGPEYY)
.NET Framework 4 (http://www.megaupload.com/?d=RTPTN1GF)
.NET Framework 3.5 (http://www.megaupload.com/?d=SB4V5V26)
.NET Framework 3 (http://www.megaupload.com/?d=741GDJ2W)
.NET Framework 2 (http://www.megaupload.com/?d=K5KSWWTU)

[Apple]

nice one +rep and stickied

[DjAligator]

Mangos 8938 - 8953
Implement talent 50880 and ranks.
Fixed talent 49200 and ranks triggered spell for arcane school.
Make players and totems always immune to taunt.
Limit used energe as expected for spell 22568 and ranks.

Thanks also to Sarjuuk for code simplification.
Spells 20911 and 25899 stats bonus.
Add spell_chain data for 24604 and ranks.
Use DBC data for summon effect functionality.

Also some more local fixes:
* Alow multiply same type guardians req. for some spells.
* Apply spell duration mods to summons

Many summon spells must start work.

Great work qsa! :)

Thanks The_Game_Master for updaing patch to recent sources.
Update work triggered effect for 20271
Implement talent 57499.
Implement aura SPELL_AURA_MOD_DURATION_OF_MAGIC_EFFECTS (245)

Used in spell 6117 (5/6 ranks)
Not check victim at apply SPELL_AURA_MOD_SPELL_CRIT_CHANCE_SCHOOL
for ranged spells

In same way as for other cases. For consistance.
Implement proper support spell auras with maxstack > 1 and charges
> 0.

* Like auras expected to be proccessed in spell proc event code (not lost
charge at use in spellmods code).
Exist examples for like spells that affect value in spellmods but have
different expire requirements.
* Propertly work with stacked auras in spell proc event code
- remove only one auras from stack
- in case charges exist in same time not touch charges but return expire

(all really used auars with maxstack>1 and charges have 1 in one from
this values)
Implement talent 55198.
Remove trailing spaces
Fixed loading `locales_gossip_menu_option`.
Use default gossip menu options if no options exist for "top level"
menu.

Also not close gossip menu in cases where no action_menu_id is set.
Apply spell mutiplier to final damage for health calculation in
Spell::EffectHealthLeech.

[StickyIcky]

Nice to see your back, +repx3

If you need any help, hit me up on MSN.

[DjAligator]

Mangos 8954 - 8975
Implement spells 65495 and 65386.
Check gossip_menu_option table for GOSSIP_OPTION_NONE and output
error if exist
Implement aura SPELL_AURA_ALLOW_ONLY_ABILITY.

(cherry picked from commit f4d1e05)
Implement talent 53754.
Inlcude 15407 and ranks damage in talent 15286 affect.
Implement talent 15318 and ranks and move talent 44745 and ranks
code.
fix crash introduced with 8805

or actualy i didn't introduce a new crash there.. the old crash
just changed a bit..
after we force the player to logout without valid mapcoords the player
wasn't in
world anymore and through that Getplayer()->GetMap()->RemoveFromWorld()
caused a crash..

i changed now the error handling inside farteleport there.. instead of
forcing
a logout without saving, i just port him to his homebind
which will be much nicer

(minor cleanup with the other homebind teleportation.. we don't need to
check
for the error there.. homebind realy should be a valid coord)
Prevent crash in Aura::HandleAddModifier for far group member
Check player class instead of just active pet for gossip stable
option
Make bindpoint field private and add required functions for use.
Return in TeleportToHomebind return result from TeleportTo
Implement `quit` command for close RA connection.
Restore full stack bufs from talent 51528 and ranks using unique
aura type.
Fixed division by zero in Unit::CalcAbsorbResist.

This also fix spell 31662 work.
Implement gossip menu options for GameObject
Ignore in stacking check pure dummy spells.

One more hacks to SpellMgr::IsNoStackSpellDueToSpell
This fix for example 53601 with 20911 stacking.
Implement CONDITION_AREA_FLAG

Value1 is for "include flag", Value2 for "not include flag"
Correct mangos.sql after changes to creature_template in rev 8923
Some hacks to our hackish IsPositiveEffect function.

In attempt improve positive spells detection.
Clarify ICON_POI_* changes from 2.4.3 in comment.
Increase z limit for at transport coordinates for bettr support big
height lifts.
Spell 34914 and ranks will deals damage at dispel.

(cherry-picked from commit 6ff5b6a)

[DjAligator]

Mangos 8976 - 8993
Implement CONDITION_RACE_CLASS

Condition has independent value1 (race mask) and value2 (class mask)
fields and can be used with one or both.
Not send npcflag stablemaster to non-hunter player

Also check for player class vs stablemaster flag in
GetNPCIfCanInteractWith()
Fix wrongly apply weapon damage mods to broken weapon.
Remove unexpected added lines in prev. commit.
Avvoid apply spell bonuses to glyph 42408 heal amount.
Re-apply sql update from [8211] that not included in mangos.sql in
past.
Prevent infinity recusion at repally auras at sepllmod change.

Passive auras (in different area auras) not affected by another group
member spellmods.
In different from owned unit case.
Implement item 42988 buf expire effect.
Fixed max channaled spell distance check at aura update.

Radius for target applied chanmaled auras around affect, not for caster
diatance check.
So use spell range and _only_ for explicit pointed channled target for
spell.
Remove morph from spells including aura
SPELL_AURA_MOD_PACIFY_SILENCE

This fix at damage transformation remove for spell 51514/47585 and ranks.

Thanks to KAPATEJIb for prepare compatible version for current sources.
Implement resilience on periodic crits
Allow swap spell and command/reaction in pet action bar.

* Also prevent command/action drop from action bar
* Pet action bar will recetn at this revision use single time for all
pets.
Overwrite default wrong class family mask for spell 53817.
Clean up parts of WaypointMovementGen code for better readability
Correctly return DEFAULT_GOSSIP_MESSAGE and never 0 as gossipTextId


Fixes problem with summoned and gossip and where no textId is defined in
database
Merge 2 switch in Unit::HandleProcTriggerSpell
Fixed spell proc data for

* 19184 and ranks
* 53290 and ranks
* 34506 and ranks
* 35100 and ranks
* 46913 and ranks
* 51521 and ranks (use cooldown for prevent triggred spells proccessing)
* also 34457, 20784
Fix sql update for prev. commit.
Fixed spell family mask 53817 one more time.



Added Mangos SQL updade

[DjAligator]

Implemented Slad'Ran encounter in Gun'Drak.

Snake Wrap work needs research.


Mangos 8994 - 9007
Re-implement remove auras from channeled target

* Old way have problem with auras that have last tick avent at one from
caster/target:
depndent from auras update order in caster/target pair ti can wrongly
not triggered.
* Fxied possible problem with remove same spell non-caster auras at
target/caster at spell cast cancel
* Also fix memory lost in old deleted auras cleanup.
Overwrite wrong proc flags for glyph 43539 triggering.
Implement 2 items effect from itemsets 803/-33
Implement SUMMON_PROP_TYPE_REPAIR_BOT(12) support

Used only for item 49040 summon. Need DB support for proper work summoned
creature.
Allow pet guid to have gossip options like creature guid.
Make creature wild summoned by item 49040

This make it usable by other players, not only owner.
Also sort summon types by value in switch.
Reset time in more proper way.
Add internal cooldown for for item 42987 effect.
Make 8923_01_mangos_gossip.sql more propertly work

if rename target table exist by some reason.
Revert "[9000] Reset time in more proper way."

This reverts commit 8e8f7710e8baf29196256c6e0afcce1b7d3f3671.

Main reason: unexpected work in debug with breakpoints.
Also have other reports with strange effects.
Drop dead code case
Add internal cooldown for item 40373 effect.

Thanks to Splinter for cleanup query.
Trailing whitespace cleaning

Sorry for a (bit) delayed commit.
Set internal cooldowns for trinkets and some other items/spells.

Including items: 27683, 28418, 30619, 30626, 43134, 38579, 38212, 40767,
37559, 40865, 38071, 38072, 43462, 43470, 43573, 43829,
28190, 49076, 40682, 28034, 37220, 37390, 37064, 44308,
37660, 37264, 39229, 37657, 40258, 40382, 41385, 43838.

Also included data prepared by co-authors: Sephiroth1983, nos4r2zod,
Sarjuuk, oc_redfox, Alez.


Added Mangos SQL update

[DjAligator]

YTDB
+ All fixes from the forum and editing of bug reports (see "adopted patches")
+ Settlement
+ Scripts quests
+ Gossip-menu mobs
+ Editing DPP type = 2 under the "gossipy"
+ Adjustment "fishing_loot_template"
+ Adjustment "skinning_loot_template"
+ Adjustment "prospecting_loot_template"
+ Adjustment "disenchant_loot_template"
+ A complete rewrite of loot all bosses Crypt Arkavona
+ Handled 235 caches (about 2x gigs инфы) (3.2.2a), probably the last



Mangos 9008 - 9020
modelids for shapeshifts from dbc

this will correct some modelids:
form old model, new model
FORM_TRAVEL: 632 --> 918 (now a bit smaller)
FORM_GHOUL: 10045 --> 25527 (whisp --> ghoul)
FORM_CREATUREBEAR: 902 --> 2281 (old brown horse -> bear)

implement shapeshift for spell 24347

this commit also
fix the errormessages with: "Race %u not found in DBC: wrong DBC files"
which were triggered from this code
and will fix the modelid for creature 2038
since it's also using a shapeshift aura and only got the horde-modelid

+ some new entries in ShapeshiftForm-enum
+ some research for the shapeshift.dbc
More fixes in pet action bar buttons swap.
Implement realmd support realms for different client versions

* Supported 1.12.1, 1.12.2, 2.4.3, 3.2.2a in same time as relams in same
realmlist
* mangosd by self check correct for it client build and reject all
incorrect cases
* realmd know from mangosd what builds supported each realm and
if realm not support it then in relamlist for specific client this relam
show as offline.
Not need any manual settings for this.
Drop unused enum.
fix crash when achievement is completed and player isn't in world

also don't divide money loot for players who are not inside the
same map..
and player shouldn't be able to reclaim his corpse if it isn't in same map


and some other related cleanups
shapeshift spells

some shapeshift forms will give the player spells
so we need to tell the server that the player has those new
spells else he can't cast them since the server is thinking the player is
cheating

ps forms with spells:
FORM_GHOUL
FORM_THARONJA_SKELETON
FORM_TEST_OF_STRENGTH
FORM_BLB_PLAYER
FORM_TEST
FORM_ZOMBIE

--
so this mostly won't affect any ingame experience.. but good to have this
feature anyway.. :)

also changed errormessage if player has no reagents for spell..
thx to nofantasy
Fixed unexpected error output for "unused" `db_script_string`.

When it reallt used in `gossip_scripts`.
Fixed spell 34914 ranks dispel damage and spell 29722 and ranks
bonus damage.

In both cases not expected additional spell damage bonus apply.
Add missing value for recently aded field in `realmd.sql
Fix typo in GO gossipID check for type 10
Implement aditional form specific bonus for 16857.

SQL data prepered by MrLama.
Add/update some hidden threat values for warrior/druid spells.
Re-implement 1680 (and triggred spell for 46924) in less hack way.

[Paradox]

Nice that you keep it up-to-date.

[DjAligator]

Mangos 9021 - 9043
Implement item 21213 effect work.
Fixed small typo in creature_template.difficulty_entry_N checks.
Fixed some hunter sting affects.

* spell 1978 and ranks RAP bonus
* spell 53209 affect from spell 3034 dot.
Fixed RAP bonus percent for spell 56641 and ranks.
Implement talent 63373 and ranks.

Idea with AddTriggeredSpell use suggested by darkstalker.
Implement ACHIEVEMENT_CRITERIA_REQUIRE_INSTANCE_SCRIPT.

This achievement criteria requirement type let set in table
`achievement_criteria_requirement`
that specific criteria id for achievmenet connected with some instance
must be checked by new InstanceData call
bool CheckAchievementCriteriaMeet(uint32 criteria_id,Player const*
source, Unit const* target, uint32 miscvalue1)

It expected to be used for cases: kill boss without raid members death or
for some limited time
or without kill before some other boss helpers and etc. Implementation
expected base at collection some data/counters update
in instance data at specific event and then make check by query and retunr
success for specific criteri or fail requirements.
Restore spell bonus apply to dot damage for 17962 damage
calculation.

In fact reverting wrong part of my one from prev. commits.
Better error output for
ACHIEVEMENT_CRITERIA_REQUIRE_INSTANCE_SCRIPT.
Fixed spell 0451 and ranks buff apply.

In fact drop now wrong redundent code.
Fixed: remove spell 30451 and ranks buffs stack at another arcane
spells.

(cherry-picked from commit 8dbbc7b)
Fixed: remove talent 44404 buff at spell mod apply triggering.
Correctky cast rank 2 mana regent triggred effect for 53228 and
ranks.
Fixed percent mana regneration from spell 53228 and ranks buff.
Add internal cooldown for item 47215 effect.
Attempt make more fast and less hackish spell target checks

* Enable server side recheck clear negative to friend or positive to enemy
casts that already checks at client side
* Use more fast way check in similar cases for non-players, and fall back
to old way in unclear (for while at least)

Please report if some spell stop propertly casted at friends/enemies.
Typo in function name.
Cleanups in spellmode apply code.

* Add constructores for spellmode creating instead explcit fields init
* Use uint32 for family mask 2 instead unneded uint64

Also drop one from manual applies for uno-existed now spell.
Update highest threat enemy at move to offline list.

It will restored if still highest at move back and fix
at least visual bug with GM-mode on still show for GM
as highest threat enemy for creature.
Allow have more one hunter aspect from different casters.
Update code for talent 17056 and ranks correct work.
Move enum CastFlags from eventAI to creatureAI for access to all AI
Remove double apply bonuses for spell 635/31935 and ranks

One time in code and second time by DB data.
Fxied build at *nix systems.



Added and Dual spec and anticheat Enjoy

[Paradox]

Damn, ManGOS goes up quick. Goodpost.

[DjAligator]

YTDB 231
+ All fixes from the forum and editing of bug reports (see "adopted patches")
+ Settlement
+ Scripts quests
+ Adjustment "gameobject_template" type = 0,1,10 for WDB
+ Adjustment loot money from the NPC
+ Gossip-menus mobs

[DjAligator]

Mangos 9044 - 9071
Exclude TARGET_SELF from I***plicitPositiveTarget.

This must fix triggred spells casting in case when it self casted but cast
code send diff target.
Implement talent 48539 and ranks.

Signed-off-by: VladimirMangos <[email protected]>

Also some typos in mangos.sql field order fixes (sql updates in past ahe
been correct)
Correctly send channeling start/update packets to clients

(cherry-picked from commit 1bc38f7)
Support triggered spells that have cast time.

Like spell will placed in unit event list for cast at next tick or later
dependent from cast timer.
Before all triggered spell ignore cast time and casted explcitly from
related cast caller code.
This must fix some spell work like 17086 in damage apply time part and
also in preventing possible
stack overflow because this spell triggering by chain 19 spell casts from
each other.

This also exclude from triggered arg of CastSpell function meaning that
this cast will instant alsways.
So triggred arg now meaning only that this seppl casted nit from player
side and then not send
in some cases cast info to client if not vosula effect expected.
Add src\bindings\universal\Scripts\sc_defines.cpp to script.vcproj
Additional fixes for talent 17056 and ranks.

Thanks to Sarjuuk for clarify existed problems and help in prepare fix.
Add MAX_EXPANSION define for config option Expansion check.

This will prevent case when expansion set to high for supported client
in config and account have also too high expansion setting.
Client in like case receive too high expnasion and reject connection
because it think that have not installed expansion for connection account.


This possible for example for account case when single realmd used for
diff client versions and account have high expansion setting for most
recent client support. And in same time mamngos.conf for specific realm
have wrong Expansion value.
Make code more compatible with C++ standart strict follow compilers.
Fixed possible crash at fake items swap packet.
Fxied some mage DoTs stacking.
Implement expire/dispell damage for spell 44457 and ranks.
Fixed charge amount for spell 64823 to expected 1
Not exclude real caster from TARGET_ALL_ENEMY_IN_AREA_INSTANT.

Not found cases when this need for affected case (without 27/28 effects)
Implement some damage related spell attributes support.

* SPELL_ATTR_EX4_STACK_DOT_MODIFIER
* SPELL_ATTR_EX6_NO_DMG_PERCENT_MODS
Implement spell 7057
Implement expire effect for spell 28169
Fixed leave combat by timer.

This also fix some problems with stealth detection.
Fixed SPELL_AURA_MOD_CRIT_DAMAGE_BONU (163) use in calculations.

* Renamed from SPELL_AURA_MOD_CRIT_DAMAGE_BONUS_MELEE
* Also apply to non-melee damage also
Implement two helper-functions for casting spell in creatureAI.

Function will return a cast result, with fail reasons if spell can not be
casted (can be used to take alternative action). Please note this is not a
full list of cast fail errors/reasons, but will cover a few basic errors
that may occur.
The virtual function CanCastSpell() may be adjusted for custom needs from
script library if not the default is sufficient.
Add one more expected spell cast at spell 28169 debuf expire.
More internal cooldowns for some intem spells.
Implement motionmaster function UpdateFinalDistanceToTarget()

To update a creatures distance to it's target without creating a new
movement generator. Note it can only be used where creature is using
TargetedMovementGenerator.
Small cleanups in spell code.

Mostly avoid unclear "lost" break case
Restore build at *nix.
Include spell 35395 in trigger list for talent 53380 and ranks.
Also remove wrong masks from talent 53486 and ranks.
Drop outdated code.
Add explcit 6 sec triggering cooldown to 58597.
Fixed exclusive triggering 2 buff versions for talent 48516 and
ranks.

[DjAligator]

Mangos 9072 - 9091
Implement periodic dummy aura for spells 50792, 59859, 50801 and
59858
Implement hack way detection for cave area 571.
Fix typo in 'server shutdown' description.
Fixed direction of move for SPELL_EFFECT_PLAYER_PULL
Another SPELL_EFFECT_PLAYER_PULL problem fix.

If base points porvided then this is _max_ pull distance, not direct
distance.
Fixes for pet work in case mounted owner.

* No unsummon temporary pet at non-fly mounting.
* Implement client side disable pet's action bar for mountted owner time

Signed-off-by: VladimirMangos <[email protected]>

* implement server side action disabled case (action bar modify, aggro
reaction and autocast)
Allow stacking healing buffs from spell 33763 and 48438, and ranks.
Less strict check related to TARGET_SCRIPT_COORDINATES

Fixes and enables ~20 more summon related spells. Some minor cleanup in
related code
Add custom/preset unMaxTargets for a few spells where info is not
present

Thanks to kamillys and KAPATEJIb for original code and research!
Fixed DoT damage from 12834 and ranks.
Correct some spells unMaxTarget (ref [9080]) to depend on map
difficulty
Rename maps naming used in spell targeting code for easier
readability
Implement periodic dummy aura for spell 50789 and 59860
Implement periodic dummy aura for spell 50824
Limit maxTargets for spell 33711 and 38794

Also remove not strict required difficulty check for some spells and add
lost comment from [9085]
Fixes in pet unsummons

* Not unsummon warlock pets at logout.
* Prevent overwrite current saved pet at save secondary pet (with
temporary unsummoned first).
This possible at arena for example.
* Not fixed: in char list at login pet don't must be show with character
if character saved at mount in game.
Not critical and maybe not need fix as feature ;)
Prevent unsummon permanent pets at arenas.
Check explicit target correctness by all effect target modes.

All effect target modes start from client provided target data
so all its must be used for checking explicit target modes.
For example exist spells that have as first effect SELF non-explicit
target mode.
but in same time negative to explicit target.

Signed-off-by: VladimirMangos <[email protected]>

Also add caching IsHostileTo/IsFriendlyTo for avoid recall this not fast
functions.
Implement tick counting in periodic auras.

This can be used for some tick number dependent aura effects.
Also in some cases impossible claculate tickes count pass,
for example for infinity duration auras.
Add max targets limit for spell 34861 and ranks.
Also implement glyph 42396 work for referenced spells.


YTDB
+ All fixes from forum
+ spawn
+ quest scripts
+ mob's gossip menues
+ fix "item_template"
+ fix "quest_template"

[DjAligator]

Mangos 9092 - 9112
Fixed typo in function name.
Implement periodic dummy aura for spell 48630 and 59275
Implement periodic dummy aura for spell 46041
Allow apply .modify scale to targeted creature (without save
scale).

Also add command description to mangos.sql.
Implement periodic dummy aura for spell 52441

Note speed is not really reduced as expected, this need correction in
other parts of code.
Implement periodic dummy aura for spell 53520
More correct targets selection for target pairs with TARGET_SELF2

* Many spell effects that have A target mode SELF2 expected applied to
enemy
target selected by targetmode B so we need skip SELF2 target mode.
* remove SEFL2 from explicit positive target modes.

Implement periodic dummy aura for spell 55592

Also correct second cast, expected for spell 53520
Set MaxTargets limit for spell 31347
Correct target mode 48, and rename to something more meaningful

Also adjust target 49/50 angles to be really left/right.
Use FillRaidOrPartyHealthPriorityTargets for 34861 and ranks.
Make gcc happy with muti-byte char casts and use more readable
magic strings.
Avoid send reset warning to map/difficulty cases without fixed
reset time.
Add missing argument in error message, _LoadSkills()
Add script effect for spell 47097

Also add areaflag hack to detect correct areaId
Fix most of the gcc warnings

* use UI64FMTD instead of "%u" for uint64 output
* on most *NIX systems, I64FMT is "%016lX" and not "%016llX"
* also fix typo: renamed GridMap::loadHeihgtData to
GridMap::loadHeightData

Note: there are still many warnings from the 3rd party libraries g3dlite
and ACE. Those warnings won't be fixed with that commit.
Also, a few warnings from MaNGOS are left, they'll be fixed later.
Adjust max nextMoveTime to 10000+totalTravelTime for random
movement

This is apparently closer to how the world should look like, which is
still of course a best guesstimate.
Removing the option for run chance from generic random movement
generator

Npcs with random movement in general do not behave like this, and movement
that fits the pattern of a mixed movement run/walk must be made instead if
needed.
Some cosmetic cleanup in random movement code.
Implement ConditionType CONDITION_LEVEL for PlayerCondition
Limit maxTargets for spell 42005












just DTS and AC

[Apple]

keep it up +rep again :)

[DjAligator]

YTDB 236
+ All fixes from forum
+ spawn
+ quest scripts
+ mob's gossip menues
+ many the operating time
Mangos 9113 - 9130
Add helper functions to set/getSummonLocation

This should help the poor homeless that does not have a database defined
home at evade (such as "wild summon" without owner).
Limit maxTargets for spell 28542 and 55665

Also add missing comment for target exclusion
Fix typo in error output.
Lost break/return in CONDITION_LEVEL cases.
Add dummy effect at aura removal for spell 32286
Fixed problem with not set
AchievementCriteriaRequirementSet::criteria_id

This important for support ACHIEVEMENT_CRITERIA_REQUIRE_INSTANCE_SCRIPT
Add achievement creteria requirements for
ACHIEVEMENT_CRITERIA_TYPE_BE_SPELL_TARGET*

Most ACHIEVEMENT_CRITERIA_TYPE_BE_SPELL_TARGET and
ACHIEVEMENT_CRITERIA_TYPE_BE_SPELL_TARGET2
not need any additional requirements (so just
ACHIEVEMENT_CRITERIA_REQUIRE_NONE(0) in DB) but some
need map difficualty checks and some
ACHIEVEMENT_CRITERIA_REQUIRE_INSTANCE_SCRIPT also.
Implement option to use delay in ForcedDespawn for creature
Implement dummy effects for spell 50926,51026,51592 and 51961

Note: Some adjustments in addition to original patch, using delay despawn.

Also provide sql update for proper work of affected spells (if already
exist in database).
Updated copyright notice for new year.

Also fix some lost in past cases.
One lost cases in year update
Fixed typo in README.
Add dummy effect of spell 46167

SQL update included to ensure proper work (if database has existing data)
Correct makefile copyright notice year, again

Blame the tools! :D
Allow use delayed forced despawn also in EAI.
Updated doc/EventAI.txt version.
Rename BG/arena queue_id to bracket_id and related functions/etc

This is more consistent to wide used terms

Also some other cleanups.
Implement spell 48603 script effect.

Also apply some ordering to existed spell cases code.

[DjAligator]

Mangos 9131 - 9171
Use more generic check for IsLootCraftingSpell

This include spell 69412 to autoloot generation spells.
Some enum fixes.
Merge remote branch 'origin/master' into 330
Fixed crash at loading from `player_classlevelstats` level 0 data.

Added check that prevent loading data for unexpected level 0.
Compile fix.
Fixes in talent 11129 work.

* Restore after client switch talent triggering.
* Propertly remove triggred auras stack or main spell aura at
expire/cancel.
MaNGOS 0.15 release.
Bump for 0.16.0 development.
Merge branch '330' - Switch to support client version 3.3.0A

You need extract new dbc.

Also recommended extract new map/vmaps.

And apply ofc sql updates that including character convertion.

Special thanks to TOM_RUS for continue work at next client versions
support :)
Add prev/new supported builds explcitly to realmd supported builds
list.
Implement glyph 45783.
Implement glyph 40913
Let aura after seal do at least one finish tick for stealer.

* Set periodic to fit new aura max duration range for this
* This also prevent crash for soem auras at steal.
Prevent memory lost at pet declined names loading.
Move start outfit items check to server loading.

Also drop one not needed now hack.
Typos
Propertly update combat ratings fields.

* Implemented proper combat rating fields update like other stats fields.
This will prevent reset combat ratings at .reset stats for example.
* Skill loading moved after InitStatsForLevel for prevent reset fields
setup
as part of aura apply from skill set triggered spell casts.
This fix for example talent 53125 work (combat rating set at skill
loading)
Small cleanups in pool system code

* Mark some pool system functions as constant
* Drop unused field.
More poolmgr cleanps.

* Replace mixed values used type args by function template specializations

* More explcilty show fact that poolmgr work only with db guids.
More code cleanup in poolmgr.

* Use normal result pointer instead args pair in pool roll.
* Send PoolObject pointer into (Re)Spawn1Object and set internaly spawned
field.
Revert "[9042] Remove double apply bonuses for spell 635/31935 and
ranks"

* This reverts commit 2157bc1b2fb064bd6bf0dfa5b4152d13760450c5.
* And drop DB bonus data.

Thanks to MrLama and pasdVn for reseach problem.
Drop code and DB data for removed 31892/53720 and related spells.
Fixed some paladin spell bonuses

* Use stack size in additional spell damage for 31803/53742.
* Use in code calculation for additional spell 20187/20375 damage

Thanks to MrLama for small cleanups and patch updating.
More paladin spells fixes

* Allow stacking caster effect with target effect at same player for
53736. Provided by KAPATEJIb.
* Allow proc 53736/31801 at melee hits or melee like spell hits
Prevent unexpected removal of move flag for following creatures not
in combat
Use in code heal amount calculation for 20165.

Thanks to MrLama for small cleanups and patch updating.
Implement spell 20375 targets amount depndence from triggering
source spell.
Update spell_proc_event for spell 20375, 21084, 31801.
Implement talent 19552 and ranks affect of spell 61846 and ranks.
Prevent crash after .goname/namego teleports at same bg/arena.
Fixed build errors for contrib/extractor at some x64 plaforms
Skip invisible/stealthed and not detected targets from threat list
at next target selection.

This will fix work spell 58984 and similar in combat.
Implement and use PROC_EX_FULL_BLOCK

It used for spell 31245 and ranks new proc flags.

Original patch provided by dardennf.
Drop unexpected added copy of sql update.
Allow SPELL_AURA_PERIODIC_LEECH to crit if able to.

This allow DoT crits from 2944 and ranks for example.

(based on commit be72957)

Also included improvement from Lynx3d for resilence and crit threat
affect.
Update splitConfig.txt for vmap generations.

This will fix large size some generated vmap files and optimize server
work with its.

NOTE: in fact no changes in real in game data but for optimize work better
regenerate vmaps with new splitConfig.txt.
Use enum for CONFIG_SKIP_CINEMATICS values.

Just small code cleanup ;)
Implement speed reduction at creatures DoFleeToGetAssistance
Fixes/cleanups in extarctor code.

* Avoid create debug binary version with space in name, ignore it in git
changes.
* Alow filenum == 0 in archive file lists. Some currently not loaded fiels
have its
for example in case when in archive single file.

NOTE: no change in extracted files, so not need re-execute.
Remove unused arg in new function added to prev. commit.

Also update ad.exe
Correctly work with alternative locale names.

Allow use enGB locale subdirectory for DBC files.
Move accaptable builds check/list preparing to functions.

Maybe DBCStore.* not best place for its but we not have src/game local
file for common functions...
Impleament DBCs build check at server startup.

* Extractor now include in extarcted DBC dir data file with build info.
* Mangosd use this data for check at startup for main DBC dir and DBC
local subdirs intergrity.
* Also updates DBC checks for raw data.

NOTE: You need reextract DBC data by _new_ extractor for correct work
mangosd.
Update pet and minipet monster move flag at player toggle walk/run

[treetree]

this is a good thread,,I have made mangos
repacks,but getting the download thing to
work is more difficult that compiling it,,

I made a 8953 & 3.3.0 ytdb with ,heisei 1.1.1 ''Secrets of Ulduar''scripts,
but now I see updates,,

+rep now i can make mangos 3.3 :)

a few to many error's
runs good,but I will try and
update it,,

tree :)

[DjAligator]

Mangos 9172 - 9209
Fixed unreaded packet tail spam at group inviting.
Remove character_queststatus_daily data at character delete.

Data deleted anyway at next daily status update so just more early and
expected cleanup.
Target limit for spell 25991.
Remove duplicate fclose call.

At some platform can cause cras at server startup.
Add commented check for unit_class == 0.

In fact creature unit class must not be 0, but some creatures (like
triggers) have this.
Remove /Wp64 option for git_id vcproj files.
Lost changesat my prev. push
Update formula for GameObject 'autoclose' time (dataN-field in
_template)

This require database support/dataN-fields update for correct calculation
of time (now in milliseconds)
Add function to send custom animation for GameObject

Replace in code where packet used explicit.
Rewrite parts of GameObject use for GO type 10

This implement using autoclose time for type 10 and also sending a custom
animation for some.
To avoid duplicate code, remove code from SendLoot() (handled in Use()
instead)
Replace 0 with NULL in a few CastSpell calls (removed where not
needed)
Add filter in VC project files for motion/movement generators and
related
Fixed unread packet tail spam for CMSG_LEAVE_BATTLEFIELD
Auto-leave player at login back to bg/arena when bg/arena finished.
Templated functions for apply some code to all controlled units.

Also fix some related problems with not updates totems/etc
Fixed problem with non-attackable pes/totems at arenas

... and other FFA areas. Problem is result chnages in related flags work
after old 3.x switch.

* Added high-level functions for FFAPvP state set for unit
* Apply FFA PvP to all controlled units also at set, and at summon/load
Implement MoveGen::Interrupt call.

It can be used in time when need do some tasks before
another movement generator add on top to motion stack.
This just finish pair Interrupt->Reset similar Initilize->Finilize
In general movementgenerator have states:

Initilize=>Interrupt<=>[-some addition movegen->]<=>Reset=>Finalize
Fixed build error at *nix.
Remove not needed and currently unused header file
Fixed crashes related to recently totem acccess function

* No search if not in world (no totems then)
* Check NULL.
Fixed typo in error output for lock id gameobject template data
check.
Implement dummy effect for 46797.
Implement default min player per team at BG same as max players.

This let use now default requirement for not set in
`battleground_template` min/max values (or =0)
In other cases just set expected data into template table.
Update some comments for GO autoCloseTime to reflect changes in
9179
Prevent corrupt in-game used strings by DB escaping.
More propertly update walk mode for player pets.

* Use AddMonsterMoveFlag instead SetMonsterMoveFlags for set walk-mode
* Apply walk/run mode to all copntrolled units (except totems).
* Synchronize walk/run mode at pet creating/loading.
Replace targeted movegen by 2 new: chase/follow movegens.

NOTE: this is mostly just formal adding 2 movegens with very limited
cleanups.
Real result from adding 2 new movegens possible after apply more deep
cleanups/fixes
in UNIT_STAT_CHASE/UNIT_STAT_FOLLOW set. But this will need more cereful
changes
because we have currently sometime strange dependences and places for set
for this flags.
Similar cleanups required for other movegen related flags. Infact i have
related patches but
need more testing before apply step by step.
Clarify debug log message in GameObject::Use
Move handling of most GO's from SendLoot() to GameObject::Use()
Fix typo from [9200] and clean up code in function.
In attempt make GCC happy with chase/follow movegens code.
Use CalculateSimpleValue as delay, used in spell effect 86
Possible queue bug fix.
Player flags enum update.
Move remaining handling of GO from SendLoot to GameObject::Use
Move script call GOHello to GameObject::Use

This provide more accurate call in case of delay use from spell effects
Some code cleanups.

* UNIT_STAT_SEARCHING not used
* Remove some commented wrong code
* WaypointMovementGenerator<Creature>::Initialize() not have code
Fixed chase/follow functions calls in movegen templates system.

This commit specially made indeepndent from other changes for show problem

in my prev. commit where 2 new movegens added.

For proper call Initilize/Finilize/Reset/Interrupt/Update functions
_important_
set second template arg in MovementGeneratorMedium< T, D >
in _last_ class in class chain. In other case in chase/follow instead
TargetedMovementGeneratorMedium
In other cases will called referenced functions from
TargetedMovementGeneratorMedium
instead proper subclasses.
Big cleanup in UNIT_STAT_* use

* Re-number enums by function groups and use where possible new defined
masks in code instead raw enum |-lists.
* Avoid use movement generator generic state markers like
UNIT_STAT_CONFUSED for mark movement stoped.
Add special shadow UNIT_STAT_CONFUSED_MOVE/etc states for like use.
UNIT_STAT_CONFUSED in like case will be safe expect use for normal
checks confused state presence
And UNIT_STAT_CONFUSED_MOVE for check real move in this state
Finish synchonization walk mode for pets.

* Re-sync at follow mode switches
* Support sync for creature pets

Also
* Attempt fix build at *nix
* Drop unused unut state mask with typo in name.
YTDB 246
+ All fixes from forum;
+ spawn
+ quest scripts
+ mob's gossip menues
++ branch 3.2.2a => 3.3.0a
+ "quest_template" + 204 (full for 3.3.0a)
+ "creature_template" + 390
+ "gameobject_template" + 181
+ "item_template" + 818
+ "creature_involvedrelation" + 47
+ "creature_questrelation" + 48
+ "creature_loot_template" + 1666
+ "gameobject_loot_template" + 95
+ "disenchant_loot_template" + 149
+ "item_loot_template" + 36
+ "skinning_loot_template" + 3
+ "npc_vendor" + 988
+ spawn (including new quests)
- new event quests in the game are not available yet (no data, will be available later), also (to avoid the "freebie") are not available, some normal quests - they are all still in the development.
+ Icecrown Citadel: Halls of Reflection ("alpha")
+ Icecrown Citadel: Pit of Saron ("alpha")
+ Icecrown Citadel: The Forge of Souls ("alpha")
- Icecrown Citadel (Raids) - closed (in dev)
+ processed 273 caches (3.3.0a)

[DjAligator]

added DBC, maps, buildings.

[Dorito]

THANK YOU SO MUCH :) +rep

[DjAligator]

Mangos 9210 - 9239
Fix visual bug making npc run-in-same-position in client.

Not send MOVEMENTFLAG_FORWARD (even if expected). As result npc will not
run in same position when npc becomes visible at client side.
Fixed recent build problems at *nix.

Thanks to DasBlub and Lightguard for teating.
Implement pet speed synchronization with owner only for follow
mode.

* This allow pet use own speed (and all speed affects appiedto pet itself)
in combat.
* Apply this speed synhronization to minipets/guardians also.
* Also rename Unit::SetSpeed to SetSpeedRate as more close to real
functionality.
Fixed typos in unit states used in waypoint movegen.
Add helper function StoreNewItemInInventorySlot

Mainly function for script side store new item, but may also be used to
simplify similar task in code.
Move template function specializations before uses to make gcc
happy.
Fixed hunter pet XP requirements.
Also move calculation to function. And avoid use operator[] for access to
per-area base xp table data.
Fixed spell 34471 applying from 34692.

(based on commit 7a9dc4e from insider42/mangos)
Fixed check in CMSG_QUEST_POI_QUERY proccessing for max quest
amount.

This fix work quest poi for filled quest list
and fix unexpected spam about unreaded packet content.
Use ax_check_openssl.m4 for support more ways detected openssl at
*nix.
Implement talent 53527 and ranks.
Implement minimal area team size for some items arena rating
requirements.
New start spell for alow proper use new startup weapon.

After sql update apply new and old charactrs for affected class/race pairs

will receive spell at first/next login.
Implement possibility have 2 weapon by rogue at start.
Fixed memory leaks in WorldSession::HandleCharCreateOpcode
Implement .relaod gossip_scripts
Fixed a bug with applying spells 1784,5215,24450 and ranks as
debuff.

All non generic spells expected to be cancellable and part of buff
abilities.

(based on commit 7f5310b from insider42/mangos).
More wide check item looting state at item operations.

Move some checks from packet handlers to Player::Can functions

Patch base at idea suggested originally by zhenya.
Speedup groups store and other code work.
Add AI function SummonedMovementInform

Informing summoner of summoned when it reach a movement point (MovePoint)
Add maxtarget limits for spells 66013, 68509, 67700 and 68510
Update used utf8 cpp library version up to 2.2.4
Replace list bool fields with exclusive true values by subtype
field in Creature.

Use it in recently added code instead dynamic_cast use.
Restore build at *nix after [9228]

Partly undo changes.

Thanks to DasBlub and Lightguard for testing.
Remove redundent typecast.
Change way call AX_CHECK_OPENSSL.

Original way have many reported problems.
New also maybe not allways working but less problematic.
Set damage division for spells 70492, 72505, 72624 and 72625
Implement spell 12479.
Update spell 15286 work to current funtionality.
Apply second part of spell 50397.

YTDB
+ All fixes from forum;
+ spawn
+ quest scripts
+ mob's gossip menues
++ branch 3.2.2a => 3.3.0a
+ "quest_template" + 204 (full for 3.3.0a)
+ "creature_template" + 390
+ "gameobject_template" + 181
+ "item_template" + 818
+ "creature_involvedrelation" + 47
+ "creature_questrelation" + 48
+ "creature_loot_template" + 1666
+ "gameobject_loot_template" + 95
+ "disenchant_loot_template" + 149
+ "item_loot_template" + 36
+ "skinning_loot_template" + 3
+ "npc_vendor" + 988
+ spawn (including new quests)
- new event quests in the game are not available yet (no data, will be available later), also (to avoid the "freebie") are not available, some normal quests - they are all still in the development.
+ Icecrown Citadel: Halls of Reflection ("alpha")
+ Icecrown Citadel: Pit of Saron ("alpha")
+ Icecrown Citadel: The Forge of Souls ("alpha")
- Icecrown Citadel (Raids) - closed (in dev)
+ processed 273 caches (3.3.0a)
+ All fixes from forum
+ spawn
+ quest scripts
+ mob's gossip menues
+ text update for "quest_template"
+ fix templates from WDB
+ processed 347 caches (3.3.0a)

[CthulhuFtagn]

Just a heads up, your versions are a little outdated.

[DjAligator]

Mangos 9240 - 9260
Implement spell 24834.
Implement AI/EventAI calls at summoned creature die/despawn

* New CreatureAI::SummonedCreatureJustDie called for owner at temporary
summoned creature die.
* New EVENT_T_SUMMONED_JUST_DIE (25) for proccess
CreatureAI::SummonedCreatureJustDie event
* New EVENT_T_SUMMONED_JUST_DESPAWN (26) for proccess
CreatureAI::SummonedCreatureJustDespawn event
* Some code cleanups.
Fixed inconstence in one from recently added AI events name
Some spell rune code fixes

* Also replace check/take functions for runes by single 2 mode function
* Implement proper check for dead runes case
* Implement proper rune selection for Aura::HandleAuraConvertRune
Implement talent Rime

And apply SPELLMOD_COST to rune spell cast as part this.
Remove CellLock class and all cell-level thread locking.

* It was wasting CPU power as cell-level locking is not needed.
* Future multithreading will be on map-level.
* CellLock was just a 'proxy' between Cell and CellPair and in some cases
carried redundant data.
* Some minor cleanup in Cell::Visit/Map::Visit.
Move more values from `data` to own fields.

Now possible (need recheck) glyphs still used form `data`.
Fixed typo: achievment -> achievement
Allow mounts at map 595.
Move instance call OnPlayerEnter() to after really added to map

Also clarify log message and comment for function.
Fixed my typo in 9246_01_characters_character.sql

And provide sql update for case if old sql update version already applied.
Restore work spell 31687 and implement work glyph 50045.
Fixed crash in result typo in arena points loading.

Also small cleanups in PLAYER_FIELD_WATCHED_FACTION_INDEX use.
Update AP bonus for item 2892 and ranks DoT.
Implement .reload locales_gossip_menu_option
Add information about m4 dir to configure.ac.

Possible this will help resolve recent porblems with openssl detection at
some platform.
At least it help in some similar cases at testing.
Fixed boss emote range
Report error message at openssl dir find fail in configure.

Instead linking errors.
Add break for safe and code style.
Implement talent 52795 and ranks.
Rewrite pool system work with dynamic data.

Concentrate all dynamic data in single structure for future move it to Map
for support pre-Map pool data store.

* This let use pool system in future in instances
* Remove main stoper to move creature/guids to per-map store tht open lot
simplifcation and problem autoresolves
* This is also fix some porblems in pool-pool case work.



added
characters sql and ramld sql

[Dimman]

Nice & Thanks :) :cool: +rep /Need to spread before ;)

[DjAligator]

Mangos 9261 - 9280
Clarify two error messages related to achievement criteria data
Allow larger value in database quest_template.QuestFlags
- Updated unit dynamic flags enum.
Updated player flags enum.
Send MinLevel of quest to client (minimum level required to obtain)
Fix build. Add ITEM_MOD_FERAL_ATTACK_POWER to deprecated list.
* Call Database::ThreadStart()/ThreadEnd() for all DBs.

Implement CMSG_CORPSE_MAP_POSITION_QUERY opcode.

* Send coordinates of corpse on world map, if outside instance.
* Send coordinates of instance entrance, if inside instance.

Thanks to Ceris and Lightguard for helping with research/code.
Correct mixed up typeid check for gossip scripts
Fix one areaflag for city subarea
Second attempt to add missing break for SPELL_EFFECT_SUMMON

(earlier accepted patch by daveh never pushed to master)
Send pointOfInterest (if exist) to client before sending gossip
menu.
Revert "[9266] Implement CMSG_CORPSE_MAP_POSITION_QUERY opcode."

This reverts commit 102abf5fff122ec736b49c978fcfba0177f9edc2.

Research was in fact wrong, and caused wrong corpse position at client.
Revert "[9265] * Call Database::ThreadStart()/ThreadEnd() for all
DBs."

This reverts commit af146f14c0999eed0e293bc0595a04e62df54f3e.

Not need call this function more that one per thread.
Implement item 49623 triggered stacking affect.
Implement SPELL_EFFECT_SUMMON_ALL_TOTEMS

This implement work spells 66842, 66843, 66844.

Patch originall writed by Arthorius, with additional fixes from
darkstalker
and hack removes from me.
Quest reward data rearranged and comments added.
Prevent gain/lost health/powers form death persistent periodic
affects.

This must solve bugs with inconsistent death states also.
Fixed AP bonus percent for spell 16857.
Prevent reapply charged/noaffect spellmod to persistent auras.
Move reapply spellmods code in own function.
Fixed work scrolls of enchantment.

SOme for its have spells with unexpected reagent requirements.
Movement packets fix.

YTDB
+ all fixes from forum
+ spawn
+ quest scripts
+ mob's gossip menues
+ fix tokens drop
+ fix conditions "quest_template"
+ new templates from WDB
+ processed 378 caches (3.3.0a)

[baciany]

I downloaded all those RED MARKED Files.
now is Question: How to run this server ? This mangos have 12mb installed, All databases not more than 1mb. how it is possible to server have 13Mb ? All repacks etc have about 50mb. Can you explain me it and help do ManGOS 3.3.0a Server ?

[DjAligator]

you didn't download them all.

[Cothe]

This is a nub question but I forgot...
Do the maps etc. here work for my ArcEmu + WhyDB too?

[ovidel]

Nice it helps me for the server ;) .

[DjAligator]

Mangos 9281 - 9311
Fixed client ignore spell 1464 and ranks in combat log.
Possible fixed crash source added in [9228]

After [9228] groups stored under leader guid keys, but group leader can
change
and in result at group disband after leader change group not removed from
storage.
Apply SPELL_AURA_MOD_HEALING_PCT to any healing.
Realy fixed crash source added in [9228] now.
Fixed unexpected double time for apply damage for spell 1464 and
ranks.

* Implement way ignore some redundent data for triggered spells base at
cast cost exist.
Reason: some triggered spells inherited data from main spells
just for porper client show spell attributes, we not need this data.
* Use check for ignore inherited cast time.
Fix spell 69377
Prevent weapon skill grow at player's pet hit.
Prevent apply spell power bonuses to some item heals.
Update to 3.3.2 client.
Update DBC file checks.
Fix glyph 57870
Not need modify (it autorization code not affected) until switch.

Current realmd work in way that support future supported build without
modifications.
Some cleanups in realmd, no functional changes
Implement DB storage for new quest field, CompletedText

Text will display in quest objectives window when quest is completed.
Also add locales storage
Merge branch 'master' into 330
Include build in to .map files data.

This let not update map fiels format version at switch to new build
for prevent use wrong .map files. Build checked at loading.
Remove unused declaration of string in sendQuestGiverQuestDetails

Some additional code cleanup for readability
Fix stacking problem of tracking spells
Fixed typo in function name.
Implement SPELL_AURA_MOD_BLOCK_CRIT_CHANCE
This fixes talent 47294 and ranks
Add ranks info for 3674 and ranks.
Increase max allowed DB value for item_template spellcharges_N
Implement affect glyph 41533, talent 16187 and ranks to 5394 and
ranks healing.
Upgrade a few error messages from engrish v.1 to engrish v.2 :)
A few more error message corrections/clarifications.
Implement proper check of broken spells for IsLootCraftingSpell
case.
Fix load quest locales, after implement CompletedText in 9291
Restore skip one from startup (by DBC data) but not existed items.
Propertly detect underground area 4425
Fix load quest locales, after implement CompletedText in 9291, v2.0
Implement glyph 43385.
Grid containers, cleanup
Fix SMSG_CHAR_ENUM opcode
Implement DB storage for new quest_template field 'RewXPId'.

Values 0-8, used to display XP reward in client log.
Please note that calculation of quest XP has changed, and formula must be
corrected accordingly.
Item 13506 not flask anymore.
Switch to support client 3.2.2 (build 11403)

Merge branch '330'

You need regenerate dbc/map/vmap files. Use updated ad.exe for this.

---------- Post added at 11:46 PM ---------- Previous post was at 11:23 PM ----------

YTDB 266
+ All fixes from the forum and editing of bug reports (see "adopted patches")
+ Settlement
+ Scripts quests
+ Gossip-menu mobs
+ Adjustment field "QuestFlags" of WDB under recent changes in the nucleus
+ Adjustment loot mobs
+ Adjustment fields "item_template" by WDB
+ Adjustment modelek "creature_template" by WDB
+ Adjustment field "EndText" in "quest_template" of WDB
+ Filling of the new field "CompletedText" in "quest_template" of WDB
+ New templet of WDB
+ Handled 416 caches (3.3.0a)

---------- Post added 02-06-2010 at 12:41 AM ---------- Previous post was 02-05-2010 at 11:46 PM ----------

Mangos 9311 scriptdev2 not added because they didn't upgrade v100 on c++.
DBC 3.3.2 and maps added.
Soon and buildings.

[DjAligator]

YTDB 267
+ 3.3.0a => 3.3.2
+ All the patches from forums that were accepted (look under "Accepted patches")
+ Spawns
+ Scripts for Quests
+ Gossip Menus for Mobs
+ New templates from game caches (WDB)
+ Full filling the new field "RewXPId" in "quest_template" from WDB
+ Upgrade from 3.3.0a to 3.3.2
+ Processed 419 Cache Folders (3.3.0a)


Mangos 9312 - 9327
Implement DB storage of new quest_template field RewHonorMultiplier


Also rename an existing field to RewHonorAddition.
Note: calculation of real reward must be corrected accordingly.
Fix spell 53511 and ranks
Add new explcitly supported build to realmd
Use correct way extraction low guid for player.

No functional changes in fact for current code base at 0 high guids used
for player at this moment.
Restore build after [9313]
Fixed client crash at raid target icon update.
Some other updates.
Fixed error output at creature loading.
Fixed compile error.
Call linkedtrap summon in more cases.

* GAMEOBJECT_TYPE_BUTTON can have linked traps
* Spell::EffectSummonObject also can summon objects with linked traps

Thanks to patman128 for research second case.
Update quest XP formula

Use dbc store as base for real xp rewarded and also display xp reward
accordingly in related packets.
Note there are still some smaller things that may need smaller adjustments
and tweaks, these are on the todo-list.
Load factionReward store for later use.
Correct typo in [9319], sorry :)
Correct enum PetTameFailureReason
Fix spell 69378 and 69381
Fixes in code work with original caster guid.

* Add 2 function for 2 used way for original caster
- GetAffectiveCaster(), is posible NULL unit as source spell affects
(explcit caster, GO owner, caster of aura that trigering affect)..
- GetCastingObject(), possible NULL world object as in game spell
effects
source, cast center, etc, need because original caster can store GO
guid that apply effect around. In other cases m_caster
* Use functions and avoid use explicitly m_originalCaster
* Use GetAffectiveCaster() for fix explicit GO cast at near unit, like now
fixed campfire bonus.
Fix some gcc warnings
Restore linking in case DatabasePostgre use.
Restore code style after [9286], [9322].
Replace leader based indexing groups by group ids.

* This must repolve problem with loot.
Before if some mob killed by group member and then leader changed
then group members can't loot this mob body.
* Possible resolve crashes at loot. Now group storage content not
dependent from leader changes.




scriptdev2 added

[Milation]

Epicz!

[DjAligator]

Mangos 9328 - 9348
Implement spell 772 (high ranks) additional damage bonus.
Add spell chain for 50245/50519 and ranks.
Fixed msvc compile warnings.
Implement DB storage of new quest fields RewRepValueIdN

Value can be -9 to 9. Value point to actual rewarded value in dbc store.
This id can then fully replace current use of RewRepValueN, as this field
will most likely be reserved for custom reputation rewards (override
RewRepValueId).
Old system/DB data will still work like normal, but be aware this may
change in not too far away future.
Correct mangos.sql for missing RewRepValueIdN-fields
Added some comments.
Check if baseLevel for XP is valid before attempt use data from
store
Clarify error log message after rewrite of monster_* to spline_*
flags

Also change name of related field in code.

Use single FD_SETSIZE define

* Remove unused framework/Network/SocketDefines.h
* Make sure that we have single FD_SETSIZE define in code
Use ACE PATH_MAX define magic
Simplify group loading code.
Use group ids for indexing groups in DB

* Use group ids in DB
* Pack used group ids at server startup
* Finaly drop group search by leader guid.
Fixed typo in group memeber add sql query.
Fixed loading chosen player title
Fixed group creating :(

Also prevent not read tail packet spam in soem cases in group handlers.
Remove unused function.
Implement show item socket gems in trade window.
Show enchantment applied to item in trade slot to caster after
apply.

Also more strictly check cases when in spell targets presetn item in trade
slot.
Implement bonuses for spell 50464

* Implement percent bonus at own Hot at target. Original patch provided by
rechapa79
* Implement glyph 45603. Original patch provided by Splinter.
* Rewrite code for spell 60137.
Restore wild gameobject casting.

Most visible case: gameobject based teleports.
Move mangos 0.14/0.15 sql updates in archive subdirs.

[DjAligator]

Mangos 9349 - 9364
Add posssibility for one action button set per talent spec.
Add missing update query of [9349].
Hopefully final fix for sql update of [9349].
Remove unused varibles
Simplify code.
Some fixes to guild/arenateam events.

Add spell efffects for dual spec.

Actual dual spec still not implemented.

Credits to EnderGT for original patch.
Spell 50464 bonuses dependent from amount HoT types at target, not
stack size of this HoTs.

Thanks to LordJZ for research.
Correct output in case negative value in one error message.
Propertly show mail data in new mail tooltip for action mails.
Not use PLAYER_FIELD_ARENA_TEAM_INFO_1_1 directly.
Load/save current active spec and total spec count.

Still needed for complete dual spec:
* support for second glyph set
* implement gossip options
* support for second talent set
Fix the damage of spell 53351 and ranks
Correct the health increased by spell 55233
Make specs work at least for action bars

* Propertly add/remove required for specs work spells at 63624/63651.
* Copy current spec action bars to new spec at specs count increase, and
delete action bars data at spec count decrease.
* Avoid undexpected action button data test for not active spec at
loading/copy, but test action buttons data at spec activation.
* Reset active spec to default if active spec removed.
* Remove talent reset at spec switch that useless at this moment.
Also note that for future case this also can be not correct and batter
unlearn/learn only talents that different in specs.

After this changes specs must fully work in action bar part without
unexpected another effects.
Implement new way spell 1535 and ranks work.
Also implemented spell casting requirement check and proper animation.
Update diminishing categories.




YTDB 274
+ All fixes from forum
+ spawn
+ quest scripts
+ mob's gossip menues
+ new templates from WDB
+ filling the new field "RewHonorMultiplier" in "quest_template" from WDB
+ filling the new field "RewRepValueIdX" in "quest_template" from WDB
+ fix pull "rare" mobs
+ World Events - "Love is in the Air" - 45 new quests (full)
+ proccesed 38 caches (3.3.2)

[DjAligator]

Mangos 9365 - 9391
Implement spell 31226 and ranks in non-consume poison part.
Fix spell 67228
Fixes for [9366] for restore server startup and other.

* Add expected sql update order guards to sql updates
* Update size of spell id field in spell_bonus_data.

Note: You need apply new sql updates versions or just re-aplly
one more time new sql update version if apply already old.
Fixed my typo in mangos.sql

Thanks to Dereka for pointing to it.
Proper secondary target damage for spell 55050 and ranks.
Implement .reload `quest_poi` (also reload `quest_poi_points`).
Implement .reload all_gossips

* For reload `gossip_menu`, `gossip_menu_option`, `gossip_scripts`,
`npc_gossip`, `points_of_interest` by single command.
* Also fixed reloading `points_of_interest`.
Missing whitespace.
Fixed rune consume at no rune code mods

Do rune cost calculations only if no no rune cost mod active
Add possibility for second glyph set.
Fxies for prev. commit.

NOTE: DON'T APPLY prev commit version sql update
Now really correct sql update with content
Maybe last fix of fix of fix sequence. O.O
GRRRRRRRRRRRRRRRRRRRRRRRRRRRRRRR!
Not report action button porblems at spec activation.

Action bar copied at spec creating and base at fact that talents not
copied
possible cases when action bars not apporpriate for created spec.
So let its drop silencely
Fix spell 55268
Some missing in mangos.sql command descriptions.
Fixed some compile warnings.
Some missing .reload all_* commands descriptions in mangos.sql
Move back from archive subdir 9010_01_realmd_realmlist.sql

This need for correct work git_id tool used by devs.
All last sql updates for specific DB mangos/characters/realmd must be in
sql/update.
Resore use uint64 instead time_t in query, some other fixes.
Lost sql update from [9382]
Store some config values in Rate emun.
Fix commit [9386]
Implement max cast chain length for triggered spells.

* New config option MaxSpellCastsInChain ( 0 is disabled old way work )
* Check added for prevent stack overflow crashes in case infinity
triggered casts sequences
with more useful error output instead crash.
* Default config steeing in 10 casts expected to allow all possible in
game proper cast chains.
Cleanup config data. Use proper names and expected types.
Remove unneeded mail related queries on character load.
Remove unused defanes in Configs enums.

[ADRIAN]

Awesome +rep

[DjAligator]

Mangos 9392 - 9419
Update creature/gameobject pool at despawn instead spawn prepare.

This let solve problem with not despawned creature/gameobject at pool
update in case when related grid not loaded.
Add init value to config.
Add expected spell ids to error output.
Update cmake for mysql_to_pgsql.
Fixed compilation mysql_to_pgsql on *BSD.
Fixed unexpected rounding in healamount = healamount *
int32(TakenTotalMod);
Some config enmus fixes.
Simplify config options loading code.
Creature relocation acts like instant movement generator, so
current generator expects interrupt/reset calls to react properly.
Resolve porblems with waypoints moved/etc after [9400]

* Move movegen Interrupt/Reset calls from CreatureRelocation that called
and from another movegens.
* Add this called to NearTeleportTo creature case and new MonsterMove*
functions that considered
as special moves similar instant movegens.
* NearTeleportTo/MonsterMove functions recomended used instead explicit
use CreatureReolcation+SendMosterMOve pairs
for proper reaction at movement from creature movement generators.
Add enum SpellEffectIndex to use with explicit effect index checks
Replace number with enum name where explicitly used in array/other
checks
Fixed glyph apply with with specs.

This resolve problem when glyph rejetect applied
at some spec if it applied already at another spec.
Make all movements instant applied.

* Drop delayed moves list in Map code
* Apply movement coords update always at call including movement to
different cell/grid.
* Instead removed functionality mark creature as need move notify
broadcast at next tick, do it.

This must resolve porblesm with CreatureRelocation in past not always
update position to new expected at call
And in resul next code fail or work in strange way. Mark creature for
notifier call at next Update
let safe main part remopved functionality implemented in another way:
prevent cascade (or infinity chain)
in move updates. In fiture possible implement move notify call not at each
tick for save time.
Documentation mail system.
If instance have reset time not let rate make it less 1 day.

This also fix crash at instance reset data loading at server startup.
Add MAX_EFFECT_INDEX to enum SpellEffectIndex and use it.
Use SpellEffectIndex as arg type for spell effect handlers.
Correct a typo in enum name, CAST_INTERRUPT_PREVIOUS
More SpellEffectIndex using in apropriate cases

Add #include DBCEnum.h for headers where SpellEffectIndex used.

This must fix Unix build problem.
Use SpellEffectIndex in EffectDummy* script calls.

Scripts used this script calls will need update...
Some lost changes for prev. commit.
Dome not catched cases for MAX_EFFECT_INDEX use.
Implement dummy effect of spell 46606
Correct spelling of horizontal.
Implement dummy effect of spell 45980
Implement dummy effect of spell 45990

YTDB 281
+ all fixes from forum;
+ spawn;
+ quest scripts
+ mob's gossip menues
+ new template from WDB
+ update vendors: "Arena Season 8" + "Tier 10" - FULL
+ fix column "type_flag" in "creature_template" from WDB
+ Vault of Archavon: - "Toravon the Ice Watcher"
+ full respawn veins: Kalimdor
+ Event: "Kalu'ak Fishing Derby"
+ processed 87 caches (3.3.2)

[agamoose]

Nice Work +rep

[DjAligator]

Mangos 9420 - 9435
Implement aura dummy effect for spell 35357

Also adjusting dummy spell 45990 slightly, despawn after some time instead
of die instantly.
Some code cleanup in EffectDummy, also correcting order of spell id
Return success result for Zone<->map coordinates convertions.

This will prevent #INF-inity values in gps for zones where
zone coordinates calculation impossible with current code.

Also fix small typo in debug output format for honor




Implement dummy effect of spell 46485
Some code/comments cleanup in EffectScriptEffect
More achievement types support.

Implemented new achievement criteria requirement:
* ACHIEVEMENT_CRITERIA_REQUIRE_S_EQUIPED_ITEM_LVL (item level and item
quality equiped in specific slot)

Implemented suppoprt achievement types:
* ACHIEVEMENT_CRITERIA_TYPE_EQUIP_EPIC_ITEM (required DB data)
* ACHIEVEMENT_CRITERIA_TYPE_SPECIAL_PVP_KILL (required DB data)

Also achievment types used only for statistics:
* ACHIEVEMENT_CRITERIA_TYPE_CREATE_AUCTION
* ACHIEVEMENT_CRITERIA_TYPE_WON_AUCTIONS
* ACHIEVEMENT_CRITERIA_TYPE_MONEY_FROM_VENDORS
* ACHIEVEMENT_CRITERIA_TYPE_GOLD_EARNED_BY_AUCTIONS
* ACHIEVEMENT_CRITERIA_TYPE_LOOT_EPIC_ITEM
* ACHIEVEMENT_CRITERIA_TYPE_RECEIVE_EPIC_ITEM




Really rename to ACHIEVEMENT_CRITERIA_REQUIRE_S_EQUIPED_ITEM_LVL
Add helper functions for Unit::Get/SetHealthPercent
Remove redundant calls to Set(Max)Health, already done by
SelectLevel function.
Fix problems related to
SPELL_AURA_MOD_DURATION_OF_EFFECTS_BY_DISPEL and duration reduction of
some positive auras
Implement preservation of current health percent at UpdateEntry use


Updated creature will now have the same amount of health (in percent) as
the original creature after update.
For cases where full restoration of health is expected, function have
option to disable preservation.
Remove dummy effect (old code and wrong) of spell 34665

Let script handle dummy effect like expected for this type.
Propertly show zone coords in .gps after recent changes.

Implement detection subzones 4716 and 4740 of zone 4395.
Prevent crash at script call that modify movegen list at
MovementInform call.
Avoid useless creature running around at evade

* If creature near respawn point and by defult do random movement
then restart from current point
* If creature have default waypoints movegen restart from last
updated point. Not reload waypoints

[DjAligator]

Mangos 9436 - 9444
Correctly display the party leader's name in chat
Move waypoint's GetResetPosition function body to .cpp.
Add base code of effect for spell 45668, but in commented form.

The spell triggering 45668 need to be corrected before it can trigger this
as expected.
Auto-exclude from git tracking changes any non universal binding
subdir files

Also resolve small exclude conflict for dep subdir.
Store in plauer spell list structure instead pointer.

Just not reason in element persistanse storage as std::map
store pointer to structure with size < 16 bits.
Add dummy effect of spell 50133/43882
Add dummy effect of spell 44454 and script effect of spell 44455
Add dummy effect of spell 55818
Add script call EffectAuraDummy, called at dummy aura(4)
apply/remove

[DjAligator]

Mangos 9445 - 9459
Possible fix often crashes in waypoint movegen.

Thanks to DrKLO for research source of problem!
Compile fix in MovementGenerator.cpp

Also added few newlines to end of files to satisfy GCC.
Typos and missing info in mangosd.conf

Provided by erickeir and unknown author (sorry, lost info about who point
me to first typo)




Ignore anything untracked in src/bindings/

NOTE: works only on directories

(only modification / deletion of tracked files
will show up in "git status")

To force-stage a file/directory, use "git add -f",
an exception was made for universal/ .

Signed-off-by: freghar <[email protected]>

(based on commit 0a4057f)




Fixes for the Solaris platform.
Implement item set 887, 251, 232 spell effects.
Added new config option for arena queue announcer.

Option Arena.QueueAnnouncer.Enable removed so if it used
need update mangosd.conf to new options use.

(based on insider42/mangos commit 211506f)




Replace battleground announcer options.

* Drop Battleground.QueueAnnouncer.Enable and
Battleground.QueueAnnouncer.PlayerOnly
* Add Battleground.QueueAnnouncer.Join with 0..2 values (1=to joined
player, 2=to world)
* Add Battleground.QueueAnnouncer.Start for start bg event

Also fixed bug when not rated arenas announced as BG announces
Also lost mangosd.config changes from prev commit.
Implement heal bonus from talent 62905 and ranks.
Fixed some time existed multi-map taxi problem.

Interrupt taxi movegen at far teleport time with remove related state.
Far teleport triggered code not expect this state set.
Check glyph index send by client at glyph adding to prevent
cheating.
Fixed spell proc code for mixed proc event cases.

* Allow spells with multiple procEx flags to trigger also with 0 dmg, if
current
procExtra is no normal hit (e.g. block and normal hit as flags -> all dmg
blocked).

* Also allow proc at hit as result partly block. This fix case from
unknown author
prepered by KAPATEJIb.
Implement spell/attack power bonus for 59547 and similar spells.
Also fix build in prev. rev. in result my not added changes.
Add exception for spell 51912 and then trigger 45668 as expected

Also remove commented code for spell 45668
Make spell 47540 and ranks channeling interruptible

In fact make triggered spell replace main spell for channeling.
This also let drop hack for target death case interrupt channeling for
spell.





YTDB 287
+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ update all PvP-vendors;
+ Full respawn viens: Azeroth
+ fix data in "achievement_criteria_requirement"
+ processed 119 caches (3.3.2)

[margarawow]

Hi guys, i looking for create a public but private WOW WOTLK 3.2.2 server. So i download the doritos repack 3.2.2 and setup all the sql/magoscore/scriptdev/ytd updates on this page.

:confused: but when i go to make the quest "Into the realms shadows" isn't work, i can't take the horse of the "Deathcharger" to complete the quest. (i seen how is the quest on youtube)..

So i wanna know if any body has a sql patch or something to repair this bug or if you know what's wrong (maybe on the sql updates, ytdb or something) just explain me. I'll be very gratefull.

My mail is [email protected].

I'll be waiting, excuse my bad english. Thanks

[margarawow]

Ups! i forget another question! if i wanna make a public (bout private) server of wow for 4.000 users (for example) my bandwith 1512(down)/512(up) is enought?? if isn't how much user's can serve with these conecction type. Thank's guys and excuse my ignorance.

[DjAligator]

Mangos 9460 - 9473
Spellpower bonuses for spell 47540 and ranks.
Some another cases when movegen can be lost while updating.
Compile fix under GCC.
Add script effect of spell 45691 and dummy effect of 45685
Spell effects of itemset 883 and variants.

Make passive aura buffs/debuffs always show at not-casters.

This fix case when some racial party passive bufs not show for party
members.
Implemented SOAP in MaNGOS

- removed deprecated code from RASocket
- allow more than one login at a time on the RA console
- added gsoap library for handling SOAP requests
- removed deprecated mangos_string entry

Thanks to:
- Derex for reporting a bug which occured if more than 1024
players were connected [poll() vs select()]
- caeruleaus for adding windowsbuild support
- vladimir for suggesting a different thread starting order
- fdb_ for suggesting SOAP in the first place

Add dummy effect of spell 51330
Restore compile Win32/x64 (VC80/VC90), add correct include dir to
all builds
Add dummy effect of spell 51333
Add dummy effect of spell 42287
Add dummy effect of spell 43036

Revert "[9465] Make passive aura buffs/debuffs always show at
not-casters."

This reverts commit 43f6a355e5a94c56c8fd6b881b572e1d685f046c.

Need more work.
Apply recent sql update to mangos.sql itself.

[DjAligator]

Mangos 9474 - 9501
Implement negative totem effect apply for 30706 and ranks.
Add and use TotemSlot enum type
Add basepoints array to Unit::HandleDummyAuraProc
Implement glyph 45776
Reimplement Aura::IsNeedVisibleSlot

Rewrite base at area aura type check
* For positive area aura types show at non-caster target or caster-totem
or non-passive aura at caster
* For negative area aura show at non-caster target
* For other auars show at any target if non passive auras or totem-caster
Use Clear call in MotionMaster::Initilize

Function can be called from deep code in time MotionMaster::Update.
So need use safe way cleanup with possible delayed movegens deletion.
Add aura dummy effect of spell 29266
Add dummy effect of spell 51276
Implement 48266, and 50365, 50384, 50391 and ranks.

Original patch provided by laise.
Not affect anything but not nice typos...
Add dummy aura effect of misc feign death spells

Please note that it may not be correct to handle them all in the same way.

Some more research should be done regarding the whole issue with creatures
and faking death (cheaters) and a possible difference between the spells.
Fix a value in movement update blocks with update flag
UPDATEFLAG_VEHICLE
Increase reserverd stack size for mangosd up to 4Mb at Windows

Most Unuxe/Linux OSs have by default 4Mb as max stack size for application
by default.
VisualStudio for x86/x64 set 1Mb by default. In result at Windows possible
more often
stack overflow crashes in cases when Unux version work fine. So we fix
this not nice
difference.

VS10 version not included. If someone prepare patch for VS10 case it can
be added to repo.
Fix a typo in Pet::addSpell
Fixed semaphore locking on non-posix systems
No reason have different code for apply/remove for this spells.
Make common apply/remove handler for another spell group in
HandleAuraDummy
Restore code commenting style after 9489/9490

Adjust comment style for rest of function and some additional code style
cleanup.
Some cleanup in effects table.
Fixed wrong spell cast at talent 50391 and ranks apply case.
Implement SPELL_EFFECT_JUMP (41).
Show overheal from HoT in combat log.
HomeBind fixes.

* Use area id instead zone id for home bind zone info as expected.
This will for example proper show capital name in area himebinding for
capital; tavern.
* Clarify that player create zone in fact is area (subzone)
* Implement SPELL_EFFECT_BIND for normal homebinding.
Also support spell target position mode used in 53823/53821 spells
* Add Spell::EffectEmpty for mark spell effects that used but not expect
any code in handler.
Example weapon spells that used just as known spell markers for client.

Original patch idea inspirit by Sadikum patch suggestion.
Implement basic use of SPLINETYPE_FACINGTARGET

Adjust related helper function accordingly.
Restored build on *nix
Add replacement spells for GO type 10 that may have dummy spellId
in _template
Update SpellCastResult enum to 3.3.x state.
More speel effects table cleanups in comments
Implement item limit category inventory mode.

* Now expected item limit categories (for example for item 5513 and
related)
correctly limited by its amount in inventory.
* Provide and use additional arg in SendEquipError for alt. way get
affected
item prototype. This let send to function item id and prevent crash
client at
limit category equip errors that required item prototype data.

[DjAligator]

Mangos 9502 - 9541
Update SpellCastResult enum to 3.3.x state.
Updated behavior of auto shot according to the client changes.
Removed obsolete code for spell 18096 and ranks.
Removed facing limitation for spell 2764.
Add missing AI calls to inform summoner of summon-related events



Implement SPELL_EFFECT_RESTORE_ITEM_CHARGES

Also it application in special case of item 5513 and similar.
Finish impement new functionlity for item 5513 and similar.

* Implement recharge low rank item in inventory.
* Implement recharge item at loading after 15 offline mins
Move custom data from item spell charges sign to new field
`NoConsumable`.

Some items with negative by defaul charges not expected to be deletedt at
no charges.
In past this fixed by using positive charges amount in like cases in
different from
expected negative value. Adding new field for avoid this.



Gameobject casting improvements.

* Add IsHostileTo/IsFriendlyTo and implement expected way checks for diff.
world object types.
For controlled object check redirected to specific owner, for wild
gameobject base at gameobject faction.
If faction not set expected to be hostile to anyone.
* Update grid searchers to be usable with world object instead only unit
case.
Some grid searches lost redundent second object arg,
AnyAoETargetUnitInObjectRangeCheck lost hitHidden arg
(for hitHidden==true case added new
AnyAoEVisibleTargetUnitInObjectRangeCheck)
* Updated grid searchers used with gameobject area casts now.
Note: Gameobject area spell cast animation will still wrong show around
cast triggering target instead
center around gameobject.
* In case gameobject aura apply to target for restored use target itself
as caster because
we not have currently another way apply aura form wild gameobject.
Hotfix for low chance crash at not accessable gameobject cast.
Spell 16952 and ranks will now correctly proc from all cat form
abilities that add combo points
Fix spell 48920
Implement opcode CMSG_HEARTH_AND_RESURRECT
Fix a possible exploit in CMSG_HEARTH_AND_RESURRECT
Fixed talent 50391 and ranks in part apply rune cooldown expire
speed.

* Apply rune cooldown buff only for spell 48265
* Implement SPELL_AURA_MOD_POWER_REGEN_PERCENT work for POWER_RUNE

Thanks to Laise for problem research.
rewrote RA console using ACE

- moved SQL pinging to SqlDelayThread
- use sAccountMgr instead of explict sql queries
Implement account associated execute for RA commands

* Now at login by RA-connection RA-connection use account id/access level
for commands execute. So at login with moderator access by RA-connection
you
can execute only moderator level commands. For administrator level
accounts
allowed execute only console level commands if new config option
RA.Stricted = 0.
For security reasons by default RA.Stricted = 1.
* RA-connection executed commands now logged for associalted account id
* Some own account related commands allowed execute in RA-connection

NOTE: config version updated because RA.Stricted = 1 not compatible with
old
way work and this can break tools thta use RA-access if it not
disabled.
Yuo will need update mangosd.conf.
Remove linking mangosd with sockets library.

Recent RA reimplementation added by Arrai remove using sockets library for
last part mangosd code.
This let not link anymore sockets library with mangosd.

Now realmd is last sockets library user.
Prevent possible memory leak in WorldSession
Let build map extractor at Mac OSX

Also restore build at Windows (Win32 not have unistd.h)

Win32 ad.exe binary updated but not expected any functional differences.
Implement spells 58600 and 58601
Stacking Auras from dual wild weapons.
Use cooldown data from gameobejct trap tamplate if provided.
Implement effect SPELL_EFFECT_TEACH_TAXI_NODE(154)

Original patch writed by Sadikum.
Fix a typo from commit 9512
Fix CRLF in 9512_01_mangos_spell_proc_event.sql.
Avoid apply spell bonuses to glyph 42397 effect.
Make Player::IsValidPos const
Fixed check for SPELL_AURA_ALLOW_ONLY_ABILITY

Also remove public access to SpellAura::m_spellmod for avoid another hacks

with it use. Spellmods only for Player::ApplySpellMod use.
Fixed apply stamina part of 48263
Fix typo in opcode name.
Use selected target for target mode 38/46 when provided.

For cases where provided target is not valid (or not provided), normal
closest in range will be used.
Attack Power bonus for spell 64382.
Some percent target max health spells.

Thanks to timmit for research.
Implement item 46017 effect.
Avoid proc item 46017 effect from DoTs.
Implement proper work spells 59465 and 56151.
Item 23836 effect and spell 54757 not affcted caster spell power.
Implement cooldown reset part for spell 60970 work.
Implement first target of spell 1064 and ranks boost from 61301.



YTDB 292

+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB;
+ fix respawn ores/viens - Outland/Northrend
+ fix data in "achievement_criteria_requirement"
+ processed 150 caches (3.3.2);

[Hephaestus]

Once again, thank you DjAligator :).

[DjAligator]

Mangos 9542 - 9577
Make MovementGenerator::GetMovementGeneratorType() const
Really call ACHIEVEMENT_CRITERIA_TYPE_WIN_BG

Also make more wide set achievement type criterias expected requirement in
DB table.

Original patch in achievement call part provided BudIcePenguin.


Implement CONDITION_NOITEM.
Rename ObjectDefines.h -> ObjectGuid.h

Also move unrelated generic defines to Common.h
Less strict check in spell CheckTarget, and allow triggered spell.

Unit may be not selectable, but spell may be expected to target this unit
in any case.
Mostly known problem with npc->npc spells and dummy/triggered spells from
AI side.


Implement ObjectGuid wrapper for guid value

Only one example (mostly) case converted to use it.
Need lot work for finally switch to class obly use, so old low-level
defines still exist also (while used).
But some unused low-level defines dropped.


Lost new ObjectGuid.cpp at prev. commit.
One more typo :/
Hide unsafe templated ByteBuffer::append function only for internal
use.
Add and use PackedGuid wrapper.

Also
* use more wide bytebuff << >> operators for objects
* use at read packet faisl alsways exception way instead some time used
bool results.




Make some compiler happy with forward class declaration.
Make GCC really happy...
Fixed possible runtime crash.
Makes some arguments as references in some ByteBuffer operator
methods.
Allow summoned creatures use MovementType == RANDOM_MOTION_TYPE

Using creature_template.MovementType as default. For normal spawned
creatures, data from creature table will still apply and override
_template.
Radius is 5.0 as default, but may be changed in real-time from ai scripts
using function.
Move the code of glyph 55672 to a better place
Fix a typo from prev. commit:/
Update AiReaction enum.




Fixes possible runtime crash added by 9551
Fixed typos in header guards
Another update of AIReaction enum (and comments).
Use DEFAULT_WORLD_OBJECT_SIZE in ObjectPosSelector if size == 0.

This should fix a freeze in ObjectPosSelector.
If size == 0, m_anglestep became 0 -> freeze.





Remove some trailing whitespace and add comment for last commit.
Add detection code for partly cave area 3780
Restore build
] Add 2 unknown target flags.
Add function to manually start random movement.
Fix spell 60772
Implement glyph 55692
Create and use ObjectGuidGenerator/IdGenerator template classes.

* This is let finally hide guid structure in ObjectGuid.h/.cpp code.
* Shared related code.

NOTE: while switch to use new clasess one more problem has been detected
with not-safe code in .pdump work for future per-map multi-threading.
It's need rewrited before will possible safe use in like case.
For current single world thread case it's safe.
Add script calls for GameObject GossipHello and GossipSelect
Add structure and prevent spam for some LFG opcodes.
Thanks to Spp for help with researching CMSG_LFG_JOIN.




Add config option Network.KickOnBadPacket. If enabled, player will
be kicked on badly formatted (wrong structure) packet.
Use proper template arg instead default value
Use ObjectGuid in Map object stores/world access/search.
Implement SCRIPT_COMMAND_CREATE_ITEM to use when no spell exist
Implement SCRIPT_COMMAND_DESPAWN_SELF (self = creature in this
context)



YTDB 298
+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ filling "points_of_interest" - Dalaran, Shattrath, Exodar, Silvermoon
+ filling table "gossip_menu_option"
+ fix data "achievement_criteria_requirement"
+ fix data "milling_loot_template"
+ fix spawn "Razorfen Downs"
+ fix spawn "Scarlet Monastery"
+ full respawn loot "Trial of the Crusader"
+ processed 183 caches (3.3.2)

[Dimman]

Nice to see a good & updated project here on mmopro :) +Rep

[DjAligator]

Mangos 9578 - 9599
Use ObjectGuid in visibility sets
Use ObjectGuid in some loot code.

Also use ObjectGuidSet instead std::set<ObjectGuid>
Add ObjectGuid const& Object::GetObjectGuid() and restore build.
Fixed apply damage reduction to melee/ranged damage.
Send looted creature guid in proper field of loot packets.

Also use ObjectGuid in related functions.
Fixed speed recalculation at remove .mod speed rate while
mounted/etc.
Continue fix loot roll packets and related code.

* Propertly send itemSlot field and use it with looted target for roll
selection.
* Remove references to NumberOfPlayers useless data send in args
* Fixed long existed bug with roll show when single player from group can
roll item.
* Fixed possible crash at player leave group while item roll
* Fixed wrong item amount in stack in rolls inreasult use non-initilized
field as info source.
* Remove unused item guid field from Roll and not lost for nothing item
guids for this.

Thanks for help in research to TOM_RUS and j4r0d.
Restore lost `return` in prev. commit.
Remove a useless include
Fixed freeze after recent loot roll code changes.

Thanks to j4r0d for testing.
Really fix freeze :/
Add additional field for storage of speed_run rate of creature

This allow independent rate of walk vs run speed. Existing field renamed
to explicit speed_walk.
Note that default database rate for run is a result of the most common
value seen, 8.0/7.0
fixed mangos.sql
Fixed rest state remove at leave tavern
fix crash with ACHIEVEMENT_CRITERIA_REQUIRE_INSTANCE_SCRIPT

BattleGroundMap has no GetInstanceData() function
Fixed bug in instance binding in case heroic/25-man raids
difficulties

In fact typo in my old commit at adding support MapDifficulty.dbc.
Allow UTF8 strings via SOAP
Fix the amount of mana restored by spell 68082
Use area trigger zone check for inn leave case.

This is still have false cases but will more correct for specific area
triggers.
Also let cleanup code and store less data for Player.
create battleground map at bg creation

when a bg gets created it will also get it's map
(old behaviour was, that map got's created when first player entered the
instance)

the reason why battlegroundmaps aren't instantiated with a player object:
* the only information from player-class we need is
player->GetBattleGround()
also we can't use anything else
(e.g. playerlevel can be outside of bg-levelrange)
-> cause bgs depend pretty much on their maps this caused circualr
dependencies between map,bg,player
* battlegroundmaps will _always_ be prepared by the bgsystem to set
the proper data
* there is not much shared in the creational process with dungeonmaps
even the functioncall is different since players need to enqueue
first for bgs,
therefore again the player's way to that instance is only through
the bgMgr
update battlegrounds per map + cleanup at delete

this will be useful, if we have multithreaded mapupdates one day

since i couldn't reproduce any errors regarding to self deletions of
battlegrounds i removed the m_deleteThis variable
Adding a few research comments for unit_flags and rename one.

[DjAligator]

Mangos 9600 - 9620
restored work of DeleteAllBattleGrounds
check for UNIT_FLAG_OOC_NOT_ATTACKABLE in
DynamicObjectUpdater::VisitHelper

this will solve the problem that spiritguides could get attacked
(for instance with spell 2121)

thx to DasMy who helped with research :)
Simplify creating mail draft with content text, cleanup includes.
Implement use of UNIT_FLAG_PASSIVE for creature.

Add function to check creatures own ability to initiate an attack in
MoveInLineOfSight.

Prevent unexpected call to AttackStart when having unit_state
stunned/died
SetSummonPoint for any summoned creature.

Should fix a crash where summoned attempt moveRandom without having a
valid summon point.
Send packed caster GUID for AFLAG_NOT_CASTER.
Fix SMSG_GUILD_INFO time part.
Fix typo that broke guild creation timestamps :(
Send zoneUnderAttack from EventAI if creature is a guard.
Use more readble format for default `gossip_menu_option` values.
Add index for some tables in characters DB.
Add to SendMonsterMove var args for optional values.

Also drop currently unused Unit::m_InteractionObject
Use stdarg.h instead outdated varargs.h

This must restore build at *nix
Objects HIGHGUID_MO_TRANSPORT not have entry part in guid.
Send AFLAG_NOT_CASTER only if casterguid == targetguid.
Fix ByteBuffer::appendPackGUID appending a superfluous byte.
Add WorldPacket.h to vcproj files.
More use ObjectGuid in spell/etc code
Reset more UNIT_FIELD_FLAGS at login.

Resolve linking problems for script DLLs




YTDB 313
+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ fix spawn and pool for all viens
+ fix data "creature_equip_template"
+ Icecrown Citadel (Raids) - all modes: N10/N25/H10/H25 - ("alpha") - (No loot from Lich-King in heroics)
+ processed 260 caches (3.3.2)
+ Thanks YTDB forum & UDB forum & CTDB forum & TDB forum, for the WDB caches 3.3.2.
+ All fixes from forum (Look under Accepted Patches Section);
+ Spawns;
+ Quest scripts;
+ Mob's gossip menus;
+ New templates from WDB
+ Correction of the fields in "creature_template" following WDB
+ Correction of spawn in "Maraudon"
+ processed 204 caches (3.3.2)
- Icecrown Citadel (Raid) - Is closed for now (The spawns are fully completed including Lich King) , Loot is 99% completed on all the difficulties, we will polish Icecrown in the next commit (Lich King is under "Repair" there are some questions about him) + read cache topic (And help us out))

[robot3678]

nice stuff thx man

[DjAligator]

Added maps, buildings and dbc 3.3.3

[Cocain]

Nice that you keep it updated mate.


+R.

[Synapse]

Brilliant thread! Thanks! +rep

[DjAligator]

Mangos 9621 - 9637
Typo in CastSpell.

Not affect code work except restore small code speedup.
Add keys for gameobject table.
Fixed typo in mangos.conf comment.
varargs list (...) auto promote any float value to double and any
less int type to int.
Add absent empty lines in end of sql updates.
Fix one wrong cast case and simplify similar debug output.
Make mail load async.
Fix typo from [8408].
Replace some PQuery/PExecute by more simple Query/Execute.
Remove character data blob.

Update will create backup in data_backup table, just in case...
You can drop this when you think you don't need it anymore.
(I would recommend you to keep it for a few days/weeks)
Forgot to use git_id
Fix enum names.


Restore load/save known titles.
Some code clean up.
Remove fields 'data' and 'zone' from corpse table.
Restore load/save shown action bars.
Move item real-time/in-game duration counting flag to new
extraflags field.

Client expected only positive duration values, so stop use duration field
as signed.
Include recent field into mangos.sql

[Cocain]

Yet again, good job DjAligator.

[DjAligator]

Mangos 9638 - 9649
Replace all C assert()s with MaNGOS ASSERT() macro.
Display homebind messages only to affected players
Fix a typo in ReputationMgr
Fix typo; IN_MILISECONDS -> IN_MILLISECONDS.
Add info for know by client epic difficulty
Typo in UNDERWATER_INDARKWATER.
Changes in emotes work.

Waypoint/db script/event ai/'.npc playemote' emote data now auto select by
emote id way to execute:
oneshot or persistent state

So if in referenced DB data wrongly used state emote as oneshot case this
will work in different way now.
Add new emotes in enum that was missing after version update.
Really restore titles from data_backup table.
Fix current pet save in summoned state.

Thanks to hunuza for explcit bug line pointing ;)
Add comment to UNIT_BYTE1_FLAG_UNK_2 for further research
Replace some unnecessary Player::GetCorpse() calls.

[Apple]

great , keep it up DJ =]

[rcpike]

Nice! keep up the good work.:)

[delreyjr]

nice!

[treetree]

nice

+rep

tree :)

[DjAligator]

YTDB 314
+ all fixes from forum;
+ spawn;
+ quest scripts
+ mob's gossip menues;
+ new templates from WDB;
+ fix spawn: Blackrock Depths
+ fix spawn: Lower Blackrock Spire
+ fix spawn: Upper Blackrock Spire
+ fix spawn: Stratholme
+ mounts models fix;
+ fix quest conditions;
+ fix some vendors;
+ fix loot;
+ mob's stats fix;
+ filling "quest_poi" and "quest_poi_points" (Thanks Blizzy) ;
+ processed 265 caches (3.3.2) - last;
+ processed 28 caches (3.3.3);

Mangos 9650 - 9667
Some corpse related clean ups.

Old bones remove code anyway was dead, so remove it.
Correct code for quest points of interest.

Adjusting field names and type, and send data accordingly to avoid client
crash not using auto-generated id.

Due to the nature of the primary keys, two tables are truncated. Be sure
to make backup if you have data you do now want to loose.

In addition, speed up load times of data from quest_poi_points, thanks
Hunuza for helping out.
Avoid corpse save at arenas also, small cleanups.
Correctly update talent free points in diff cases.

Before at .unlearn or .learn all_mytalents commands free talent points not
updated correctly.
Same for .learn all_mypettalents.
Restore action bar proper content show at spec switch.
Fixed bug with possible double remove spell.

In case when saved in DB spell remove triggering by
dependendences chain self remove attempt.
Implement '.list talents' command.

Command show really know by selected player talent ranks,
including bugged cases like 2 rank same talent known and etc.
Also command claculated count of talents and total used talent
points cost of known talent ranks.

Can be helpful in bug debuging and cheating cases.
Not include in .list talents disabled spells

Also some more cleanups in free talent points update calls.
Remove SPELL_EFFECT_TITAN_GRIP flag at related spell remove.

This let have correct state for flag at .unlearn related spell and etc.
Not only at full talent reset.
Simplify resetTalent code.

Currently all code related to deepndent spells unlern exist in removeSpell

so not need do it in special way in talentReset.
Simplify talents reset for pet case.
Implement dual talent specializations in talent switch part.

* Implement talent specs switch functionality.
* Only gossip part still not implemented.
* At update server to this commit or later character talents will be reset

with some spam in logs about wrong places talents in character_spell.
It can be ignored as part of conversion to new table support.

Thanks to all getmangos.com community members who take part
in creating and updating original dual spec patch.
Use the db-user 'mangos' instead of 'root' in the config file.

Change done for consistence with 'mangos' created in sql/create_mysql.sql

NOTE: for secirity reason better not use this user name (and password)
in real configs/MySQL.
Include entry of gameobject in gobject near command
Fix what author of [9663] messed up, and include the changes in
mangos.sql
Add another exception to IsNoStackSpellDueToSpell.
Check max. honor points on characteacter login.
Implement 57849 and ranks.

[Happymeal]

Thanks Man +rep

[atome13]

thanks

[DjAligator]

Mangos 9668 - 9678
Add .DS_Store to gitignore.
Restore build at some old GCC versions

Old GCC hash_map::erase not return next iterator point
Add dummy effect of spell 55364.
fix resilience applying to periodic leech auras
Add some research for spell attributes.
Updated OpenSSL to version 1.0.0.
Fixed few typos.

Conflicts:

src/game/Unit.cpp
Renamed HMACSHA1 to something that will not conflict with feature
HMACSHA256 and HMACSHA512.

Conflicts:

src/shared/Auth/AuthCrypt.cpp
src/shared/Auth/HMACSHA1.cpp
Small backport from other branch.

Conflicts:

src/game/Player.cpp
src/game/SharedDefines.h
src/game/UpdateFields.h
src/realmd/AuthCodes.h
src/shared/Auth/AuthCrypt.cpp
src/shared/Auth/HMACSHA1.cpp
Updated AuthResult enum.
Added some info about realm list and auth response packets.
Added few dbc structs and updated related enums.
Fixed realm flags enum.
Implemented SMSG_BUY_BANK_SLOT_RESULT opcode.
Fixed console spam.
How this happened?
Added one more git ignore.
Fixed VS2010 build after commits:
Commit 2e4a3ca5e6f3cb11cce5d70f45f997f158d8f908 to mangos's mangos - GitHub (http://github.com/mangos/mangos/commit/2e4a3ca5e6f3cb11cce5d70f45f997f158d)
8f908
Commit 0833a9c56673966e0dc2b1f4517e9bcc310c5aa1 to mangos's mangos - GitHub (http://github.com/mangos/mangos/commit/0833a9c56673966e0dc2b1f4517e9bcc310)
c5aa1
Fix crash in ActivateSpec
Fix SPELL_DAMAGE_CLASS_NONE hit result
Not counting gems at broken item for meta gem requirements.

This is fit as cleint show meta gem state and fix cheating with gems at
broken items.
Implement ITEM_MOD_BLOCK_VALUE support in item stat mods and
enhantments.
Some comments for realmd data.

[DjAligator]

Mangos 9679 - 9709
Some more research on spell attributes.
Create new table character_stats for external tools.

Added new config value to define whether it should be updated.

This table will only be updated on logout, not on periodic save.
Add config to decide whether character stats should only be saved
on logout.
Fixed random base poinst part calculation

0 - unused, 1 -> always +1, other in ranges (rand...1) or (1..rand)
Update I***plicitDiscoverySpell/IsLootCraftingSpell and related code.
Clarify areatrigger related tables loading errors.
Clarify areatrigger related tables loading errors.

(based on 330 commit 71c1d67)
Implement AURA_252
Drop dead code in 3.x for spell 29801.
Add helper function to check if a string is numeric

(based on DasBlub's repo commit 1d5b209)
Remove outdated spell proc data and update code for 44394 and ranks.
Code style cleanups in quest code.
Implement support weekly quests cooldowns.

Part code provided by zhenya.
Add to mangos.conf options for daily/weekly reset time.

* Quests.Daily.ResetHour (0..23) for daily quests
* Quests.Weekly.ResetWeekDay (0..6) and Quests.Weekly.ResetHour (0..23)
for weekly quests.
* Drop time from character_queststatus_daily and use same way as weekly
quest reset time store.
Fixed typo in daily quest reset time init.
Merge branch 'master' into 330
Fixed typo in daily/weekly flags conflict check.
fix item 47670 spell proc event
Up to date mangos_spell_check old data and add some new.
Merge branch 'master' into 330
Now BG honor marks not reawrded in BG

* And related spells not create items.
* Update code for allow creat marks for single existed case: outfield bg
that not yet implemented in mangos.
Switch to support client 3.3.3a (build 11723)

Merge branch '330'

You need regenerate dbc/map/vmap files.

Thanks to TOM_RUS who make most work for adding 3.3.3 support. ;)
Update spell 6572 and ranks for 3.3.3
Not crash in case unknown spell expected to be learned at spec
switch.

It will output error insteed and continue.
Fixed typo in error output string.
Fix 16972 and ranks.

Thanks to vdpqtc and darkstalker.
Include changes from [9692] to characters.sql

mangos.sql part already updated.
Fixed .pdump work after 'data' drop.

Also add `character_talent` including to pdump
Also drop save `item_text` as not used in items/mails now after switch to
3.3.3
Drop item text ids generation.

Now item text not used as independent object (real item texts associated
with item guid)
Update comments for two quest flags.
Fix basepoints calculation
Drop now redundent `item_text` table.

* In beggining bad news: at 3.3.3 switch has been forgoted
item_instance.data field chnage.
In result items with texts (mail copy in to inventory, some other) lost
text content.
* That why in current commit item_text droped without convertion. In
result all itesm with texts
will lost text. Sorry for this as i think small porblem :(
* Now text stored in item itself.
Include in pdumps more tables.

* character_account_data and then will partly included macros/settings
local for character.
Mostyl used account wide macros not included.
* character_declinedname
* character_equipmentsets
* character_glyphs
* character_pet_declinedname
Add to achievement_reward support gender dependent rewards.

For example for achievement 1793
Fixed typo.

This fixes assert in Player::AddQuest when quest log is full.
Correctly update next daily quest reset timestamp in DB after
reset.
Fixed typo added by Vladimir to patch in [9704].
Also add check to prevent have NONE gender with some other for same entry
in `achievement_reward` and `locales_achievement_reward`.
Compile fix under GCC.
change case 0 handle for basepoints calculation


YTDB316
+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB;
+ fix fields "item_template" by WDB;
+ fix fields "quest_template" by WDB;
+ fix spawn: The Violet Hold;
+ fix spawn: The Obsidian Sanctum;
+ fix spawn: Utgarde Pinnacle;
+ processed 56 caches (3.3.3);
- last for 3.3.2;

[DjAligator]

Mangos 9710 - 9748
Add gm possibilities reset talents for all specs.

* At login reset '.reset all talents' will reset all spec talents.
* New command '.reset specs' will reset its online/offline.
* Command '.reset talents' now not support offline player case.
Include in 9692_02_characters_mail.sql convertor for items.

It included in swith time sql update for use in cases not converted yes
characters DB.
It can be not 100% safe used for already used in 3.3.3 mode chaarcters
data.
BUT if you want you can use it at own choice ofc.

Fixed durability problem after switch. Converted non-bag items only.
Bags not have normally item text and durability.
Use enum for effect index
Update future release info in NEWS
Replace tab with spaces, just to make at least one push today.
Implement required basic elements for dual spec learn gossips.

Required DB data for real work. This is final part required at core side
for support.

Also note that commit include

* generic implementation money cost gossip menu items so let
implement in DB many money cost gossip operations with _fixed_ cost.
* useful CONDITION_SPELL that let implemtn menu item visible if specific
spell known/don't known also wide used case for diff gossips.
Allow to vendor have same items in list with different extanded
price.
Fixed [9716] sql update.
Grr... git_id tool corrupt old sql update (it drop sometime all except
guards)
and i copy old not fixed version for restore :/
Use proper index for character_pet_declinedname in pdump code.
Drop very old item amount calculation hack code.

Use pre-calculated normal effect value as amount.
This also must fix recent item amount crafted items.
Implement Glyph of Siphon Life and fix Siphon Life proc
Updated high guids. Renamed few files. Added some comments.
Please include spell names in comments in code and and avoid its
used in commit notes.
Finaly cleanup usage ventorslot values.

This is also fix recent showup problem buy items
from vendors in case when some items usable (and then show in list)
only for some class/races.
Temporary back to 0 player highguid.

This is resolve "none from players see each other" problem.
Please, reapply non-0 player guid only with or after this problem resolve.


Some ObjectGuid use cleanups added while reseach porblem source.
removed PlayerNotifier and related Map::UpdatePlayerVisibility
function, used UpdateObjectVisibility instead

(based on SilverIce's repo commit e226019)
Note: this changes not affect in any good/bad way recent problem with
player guids.
Restore map outdated format protection and copyright years.

Tom, please update in UpdateFields.h generator 2009->2010 ;)
Build equiped item data only for item's owner

This is must decrease amount of data send to network
at player enter to visibility radius for another player.

(based on SilverIce's repo commit 8c60a80)
Correct icon for one option in default gossip menu
Client not like vendor slot 0 so restore send slots counted from 1

This is must fix not selling first item in list by vendor.
Mail send related fixes in recent code.

* Avoid use explicit MailReciever/MailSender where not need.
Types specially added for autoconvertion from common cases.

* Prevent allow copy text auction mails. It anyway store encoded data.
Same for some another non-player mails.
Cleanup in skil steps code.

* Move step arg in SetSkill to end for make possible for it default value.

* Merge GetSkillStep function to SetSkill, base at fact that old
GetSkillStep
code can be != 0 only for already known spell, so at update
Remove another case hardcoded set skill step.

We not have currently way set proper set skill step at loading,
but this not required, because important only for new learned rank have
different step.
Also drop outdated (as tested) comment.
Make Replenishment only affect its caster in arena
Removed outdated code for 33702,33697,20572
Fix proc for 53709 and ranks
Added more usable interface for grid visits

(based on SilverIce's repo commit f20f01e)
Fix number of ticks calculation for 53209 (1978 and ranks part)
Restore build on *nix

Also fix my typo in Unit::SelectRandomUnfriendlyTarget
Use local var value instead recalculation.
Update in comment indexes for SpellEntry

No real code changes.
Implement DOT related part of 54049 and ranks
Final cleanup in non proper now EffectBasePoints use.
fix spell_check.sql
Prevent adding .vsp files from VS10 to repo
Update equipment at aura transform apply/remove for creature case
Implement show realm version and build in realm list.

* Rename `realmlist`.`color` field to `realmflags`

* Client 2.x and later support show in realm list supported
client version for specific realm.

For client 1.x this implemented by adding version to name
in similar way as it look in more recent clients.

For enable version show each affected realm must have in `realmflags`
set
flag 4.

For realm work with not officially supported builds (build > last
suported)
will show version 0.0.0 and correct build value.
Fixed bg template max/min per team values
Fixed startup problems after recent realmd DB.

[simenm]

This is awesome.

[DjAligator]

Mangos 9749 - 9756
Partly revert "[9736] Added more usable interface for grid visits"

In part related broadcasts by explicit provided Map pointer (in different
object GetMap() requested)

This is must fix recent crashes in Map::MessageBroadcast
Add structure of SMSG_REDIRECT_CLIENT (0x50D).

Thanks to TOM_RUS for help with research.
Add index by `spell` to `character_spell`

This is must fix porblem with long logins at
many broken spells in `character_spell` after client switch/etc.
Add storage for min/maxgold of gameobject
Add default value for parent-field in instance_template
Rename flight speed related auras and fix spell 40120
Possibility drop (hide infact) records from DBStore/SQLStorage.
Cleanups in `instance_template` and map entrance DBC data.
Fixed sql update version and related data
Avoid database query on tutorial save by caching tutorial state.



YTDB 317
+ switch 3.3.2 => 3.3.3a (templates/spawn/vendors)
+ all fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ fix spawn: Utgarde Keep
+ fix spawn: Frozen Halls
+ fix spawn: Nexus
+ fix spawn: Azjol-Nerub
+ fix spawn: Ahn'kahet
+ fix spawn: Culling of Stratholme
+ fix spawn: Halls of Stone
+ fix spawn: Halls of Lightning
+ fix spawn: Hellfire Ramparts
+ processed 78 caches (3.3.3)




added
realmd 3.3.3
characters 3.3.3

[DjAligator]

Mangos 9757 - 9774
Add triggered spell(strength buff) for 71904
Include SharedDefines.h to AchievementMgr.h for provided used enum
type definition.
Comment cleanups related to spell base points use.
Add missing argument causing crash using .list obj, after change in
[9663]
Restore .list object output.

No reason have different command output in chat and console
just because need fix crash.
Init client build at reconnect (logout back to char list)

This fix bug with show all realms as offline at view relam list after
logout.
Use min/max BG/arena levels from DBC. Update table content.

* Use min/mac level from dbc because anyway list real selectable
for player level bg/arena backets set min/max range.
* Drop related fields and update per team min/max values.
Remove outdated code for 15286
Prevent crash at use .npc delitem to item with multiply extanded
costs.
Remove outdated code for 54936
Add the posibility to keep deleted characters in the database for a
while and also add related commands.

Added commands:
* .character deleted list [$guid|$name]
* .character deleted restore $guid|$name [$newname]
* .character deleted delete $guid|$name
* .character deleted old [$keepdays]

Command .character delete renamed to .character erase
Fixed my last sec. fix problem :/

Also make $/# in consistence in new command help texts.
Fixed typo in characters.sql.
Use more proper std::istringstream for parse args.

This must fix build problem at *nix.
Fixed typos in mangosd.conf comments
Make GCC happy and restore buuild at *unix now really.

Just for note: this still look as not code problem but GCC bug in C++ std.
library.
Fixed typo in code comment.
Fix periodic damage combat log displaying

[gigabyte]

Thanks for your amazing work dude!.

[DjAligator]

YTDB 319

+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ fix fields "item_template" by WDB
+ fix fields "gameobject_template" by WDB
+ fix fields "creature_template" by WDB
+ fix fields "quest_template" by WDB
+ fix spawn: The Culling of Stratholme
+ processed 112 caches (3.3.3)


Mangos 9775 - 9792
Cleanups in framework library.

* Removed last bits of threading in grid code.
* Removed some weird and unneeded declarations.
* General code style fixes.
* (Perhaps some things I forgot.)

Thanks to Lynx3d for the usual GCC-stabbing...
Set m_mover to NULL on remove SPELL_AURA_MOD_POSSESS by delete.

This should fix a related crash.
Fixed `instance_template` error output arg in one from cases.
Old gcc hash_map not have support for std::string keys.

In different from tr1 unordered_map
Drop trailing whitespaces.
Change CalcAbsorbResist/isBlocked to be called from target side
One more typo in instance_template loading error output.
Small clean up in 2 method names
Update 33851 and ranks according to 3.1.0 patch notes
Update 33851 and ranks according to 3.1.0 patch notes
Remove special dagger starting outfit amount.

Now DBC data provide special off-hand instead.
Also update structure comments.
Fixed crash at drop vendor items (anorther way).
Allow propertly remove attack speed buff/debuff at death.

Check wrong and redundent (not use in other similar auras).
If we use "debug bg" it must ignore that we are lonely on the bg.
Implement spell selection, for creatures in instances, based on map
difficulty
No reason lost time at other checks if spell diff id not provided.
Fixed problem with character deleting at some server platforms.
Fix wrong damage dealing from commit [9784]

[lyma]

This is awesome!!!
(http://mmopro.net/forums/reputation.php?do=addreputation&p=21156)
(http://mmopro.net/forums/reputation.php?do=addreputation&p=21156)

[DjAligator]

Mangos 9793 - 9818
Add 'Logout Player' output to the Char.log
Implement ".account characters" command

Console/chat command output characters list for specific account.
Fixed sql update for avoid apply problems.
Implement CONDITION_INSTANCE_SCRIPT (mapid, some_id)

True if mapid fit to called instance map id and instance script confirm success
for some_id case.
Controlled unit should be a source of movement packets, not
player-controller.

Now movements of controlled unit are visible for nearby players,
even when controller too far from controlled unit

This new type of packet broadcasting used in HandleMovementOpcodes handler only,

maybe it can be used somewhere else.

(based on SilverIce's repo commit d2387ca)
Prevent interect with NPC/Gameobject player in non-react state

* (stun,confuse,fleeing).
* This also fix cheating with taxi use.
Implement basic splitting for caster/target part damage/heal bonus
calculations, periodic damage/heal over time auras will now store m_amount with
caster side bonuses applied and calculate target part on each tick. Currently
critical chance/bonus calculations are not affected by this change
Remove duplicate code causing next reset of daily/weekly quests to double
up
Not need explicit value numbering for internal server side enum
Typo in enum name.
Fix 17962 damage broken after [9798] commit
Fix typo in taken damage/healing bonus calculations and fix damage of
64085
Add script effect of spell 52941
Fixed lost flight mount/form for GM in old contentes.
Fixed player loading to transport.

Bug exist already some time but possible hide by another code way work or
client change maybe.
Add some missing (dummy) opcode handlers to the list.
Simplify TaxiPathNodes data use, specially for transport case.
Drop dead code after switch.
Move pre-switch sql updates (except realmd related) to subdir.
Update/fix some opcode names.
Fix a typo.
Add VS2010 project files to git_id
Add filter files to VC100 projects

Its store file groupping info into projects.
Some cleanups in vc100 project files.

* More wide use $() for have same textual values for all build modes
* Fix NoPCH_Debug build.
Add script effect of spell 44462
Add dummy effect of spell 53808
Fix display bug when spell with more than 1 persistent area aura effect
had several icons

YTDB 320
+ all fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB;
+ fix all fields "*_template" by WDB
+ fix loot of Archavon the Stone Watcher
+ processed 133 caches (3.3.3a)

[DjAligator]

Mangos 9819 - 9842
Rename some more opcodes.

Also fix the name of some older opcodes that were marked as obsolete but no
longer are.
Fix some handlers (correctly use Handle_ServerSide).
Rename two more opcodes...
Fix link error in gcc after [9816] and include needed header
Really fixed link error in gcc after [9816].
Use in taxi flight movegen original taxipath data.
Rename one more opcode.
Fix spell 38736
Rename two more opcodes (related to projectiles).
Fix TARGET_AREAEFFECT_CUSTOM
Avoid redundent data copy in transport waypoints generation.
Implement taxi/transport event scripts support.
Fix type conversion in spell/healing bonus calculations
Move function to select an attacking target from EventAi to Creature
class

Also rename function to a more descriptive name, SelectAttackingTarget
Allow TARGET_AREAEFFECT_CUSTOM to target invisible/not targetable npc if
script target for them exists
Fix damage bonus applying from 49471 and ranks to 49143 and ranks
Fix broken compilation after [9831]. Thanks to VladimirMangos.
Make log output code more consistent for diff build modes.

* Make possible have debug output if build in release mode.
* But preserver current optimization in avoid debug output args
calculation if debug ouput disabled if done using DEBUG_LOG
* Implement in same way BASIC_LOG, DETAIL_LOG. Recommended use
its instead explicit access to sLog
* Use variadic macros for DEBUG_LOG and other new defines.
All supported VS/GCC have its support as C++ extension.
* Add DEBUG_FILTER_LOG and semilar defines for filered log output and use its.
* Also move recent added debug output for transport events under
LOG_FILTER_TRANSPORT_MOVES
Remove calls to Taken part when its not used for damage dealing and fix
HoT tick amount used in 18562 code(Thanks to insider42)
More log filters and macro uses.

* LogFilter_Weather
* LogFilter_PeriodicAffects
* LogFilter_PlayerMoves
* LogFilter_SQLText
* LogFilter_AIAndMovegens
* LogFilter_PlayerStats
Fix shadow damage part of 55090 and ranks
Include Timer.h for getMSTime in SendMonsterMoveByPath
Really fix invisible target selection for TARGET_AREAEFFECT_CUSTOM
Remove a line of whitespace


YTDB 321

+ all fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB;
+ loot from Lich-King in Icecrown Citadel - H10/H25 (now all the loot in Icecrown Citadel)
+ processed 151 caches (3.3.3a)

[Nehoz]

The Link List iss a nice work.

[DjAligator]

Mangos 9843 - 9891
Restore need seelction show at loot roll.

Also some clanups including merge 2 roll type enum.
Fix some whitespace errors.
Fix dispel damage for 30108 and ranks
Restore work of 44745 and rank/s
Add dummy effect of spell 50546, 50547 and 50548
Add script effect of spell 47393, 47615 and 47638
Implement character database clean up.

This can be disabled by config option.

Flag for clean up can be set for example on client version change.
Fixed target selection for area spells casted from aura at enemy.

* Spell::GetCastingObject must be use for selection visual/point cast,
not for friend/enemy checks. Add extanded GetAffectiveCasterObject
for proper provide for referecned checks wild gameobject casted case.

* Also support chain damage spells casted by gameobjects.
Restore work of 1856 and ranks
Disable forced alteration of specialFlags in quest_template at startup.

This will allow quest 10162 to work properly with the expected data in
quest_template (no specialFlags is needed), but will still give a startup error
for spell 33824.
Add dummy effect of spell 61832
Fix negative amounts for spell base damage/healing and fix heal effects
to correctly benefit from heal increasing/reducing auras
Fix some sqls from prev. commit
Add dummy effect of spell 51840
Fix double damage dealing of 63625 and ranks. Thanks to Revils
Restore work of 1064 and ranks, broken in [9854]
Add dummy effect of spell 51964
Add script effect of spell 54182
Backporting some code chnages from 400 branch.

(based on 400's commit 0f37423)
(based on 400's commit 636cfef)
(based on 400's commit 0bbe3a7)
(based on 400's commit ce86b56)
(based on 400's commit b74c6a8)
Defines for some spelentry arrays.

* Move and rename MAX_REAGENTS to DBC Strcuture.h.
It used only afore access to SpellEntry field and so part of strcuture
definition.
* Add MAX_SPELL_TOTEMS and MAX_SPELL_TOTEM_CATEGORIES for same reasons, and use
in code.
Implement SPELL_EFFECT_BREAK_PLAYER_TARGETING (93)
Use proper arg for player name send.
Add support split damage for spells 66765, 67333.
Also small cleanup in mangos_spell_check.sql
More weapon damage split spells.
Prevent another potion drink until combat end.
Impliment glyph 42905.
Extend SCRIPT_COMMAND_QUEST_EXPLORED to allow player<->player as
source/target

Additional code cleanup and output script id in error messages.
Add script id to all remaining SCRIPT_COMMAND_* error message outputs.

Note that script id can be id from different DB tables. It will however make it
easier to find the source of any error.
More code cleanup and style corrections.
Implement movement impairing effects for spell 58875.
Replaced hardcoded value with enum.
Added some comments.
Drop outdated code for 18788
Fix auras with custom periodic damage not entering spell/melee bonus
damage done methods
Fix immunity ignoring for delayed spells
Fixed TARGET_ALL_FRIENDLY_UNITS_AROUND_CASTER work

TARGET_ALL_FRIENDLY_UNITS_AROUND_CASTER expected seelction friendly targets
for spell caster around spell caster (so ignore original caster faction).
This meaning that for begative spell also selected friendly targets for
spell caster object.
One more meteor-like spell.
Set for client battleground weekend event world state.
Update battleground weekend world state at start/stop event.
Prepare world state inint packet data in more clean way.

* Avoid use hardcoded field amount values
* Avoid use world state update packets just after world state init packet
* Attempt make code look less horrible in general.
Add additional fields to *_scripts tables for storage of more data.

Currently not in use by any SCRIPT_COMMAND_* but we have secret plans to be
revealed in the future!
Add support for mounts dependent from riding skill and location
Change SCRIPT_COMMAND_TALK to support CHAT_TYPE_* using enum ChatType

Making data consistent with other, similar tables like EventAI's text tables.
This convert existing data and also adds support for all chat types.
Code style fixes thx to hunuza & Wowka321
Added VS2010 projects for maps extractor.

(based on commit 211997d)
Implement new commands for account search

* .lookup account email, .lookup account ip, .lookup account name
* For new commands and for .lookup player versions use first arg as part of
email/ip/name search
* Use similar output format for player/account lists.
Fix special mounts using in Dalaran
Party restore IsKnowHowFlyIn and add area arg
Extend features available for SCRIPT_COMMAND_TALK

* Allow other than Creature to talk.
* Add "buddy-talk", using creature entry in datalong2 (the npc who will do the
talk instead of the original source). Value in datalong3 is how far to look for
the buddy.
* Add data_flags making it possible to have conversations between units,
controlling who does the talking and to whom, including make player do the
talking when player is not already the source.

Notes and details are added in the comments for SCRIPT_COMMAND_TALK
Add TYPEMASK_WORLDOBJECT to enum TypeMask

Check typemask and replace a few dynamic_cast with more simple casts.
Implement *_scripts for creature_movement

New field script_id in creature_movement can be filled for each waypoint point
and run the corresponding script from creature_movement_scripts.
Script_id can be any value and several points/creatures can share the same
script (with limits of course, such as script depending on location and other
factors).

DB projects are advised to move current text, spells and emotes data in
creature_movement fields as these fields are strictly no longer needed and may
be fully removed in the future.

YTDB 322

+ All fixes from forum;
+ fix spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ fix loot in Vault of Archavon (Full)
+ processed 187 caches (3.3.3a)

[DjAligator]

Mangos 9892 - 9901
Cleanups for BattleGroundEY code
Also prevent send uninitilized mark data in case BATTLEGROUND_EY end.
Simplify related code.
Fixed some spelling typos in function/structure names.
Move GetCastingTimeForBonus and some other code to
GetSpellCastTimeForBonus.

Important changes:

* Chaged way caluclation "-5% of total per any additional effect" to percent
apply instead use raw value that correct only for 3500 cast time spells.
* GetSpellCastTimeForBonus result now alwasy not applied to creature casted
spells
Before it not applied only to instant spells. Please test if this ok in all
cases.
* Leech effect modify spell casting time move into GetCastingTimeForBonus and
then called
also for melee spells. But only creature spells exist with melee class damage
and its
not affected by GetCastingTimeForBonus anyway now.
Move DotFactor+GetSpellCastTimeForBonus call to
CalculateDefaultCoefficient

* This coeff used if not spell_bonus_data provided for spell
* Continue prev. commit line expected that creature casts not affected by
DotFactor
Cleanup spell bonus coeff use code

* Avoid coeff calculation if target value is 0.0f
* Avoid use spell_bonus_data coeffs for creature damage.
Avoid multiply AP bonus coeff. with spell power bonus.

Problem exist in original code before recent commits.
Implement redundent values check in `spell_bonus_data`

Also do table content cleanup base at added feature.

Original check code provided by nos4r2zod.
Fixed sql update for ptrev. commit.
Fix SPELL_MOD_SPELL_BONUS_DAMAGE applying
Second attempt fix sql update :/
Implement 71342 mount selection


Also added
mangos_scriptname_full
scriptdev2_script_full

[DjAligator]

Long time no updates.


Mangos 9903 - 9972
Fixed build problem at *nix.
Add new config option for wait mode at startup error.

Note: it not applied to crashes and shutdowns after mangosd/relamd startup
completed.
You can continue without delay (as now) and fast exist, or wait <Enter>, or some
secs
for continue. Last can be helpful for see for example not applied sql update
revision
data and etc.
Correct SMSG_INSTANCE_DIFFICULTY structure (fixes raid difficulty
display).
More user friendly output at DB version check fail.
Make comment really proccessed by doc generator.
Add missing break. Not affect current code work.
Prevent SQL injection in equipment sets code.

Author of original verison: Machiavelli
Implement expected from 3.2.x time limit for BattleGroundWS.

With updates and fixes from zergtmn.
Check script using and existance at `creature_movement_scripts` load.
Partly revert [9911] :/
Fix TARGET_SCRIPT searcher and also look for objects that are Pet*

Pet (guardian, mini-pet) may also be the target of TARGET_SCRIPT, and are not
considered a grid object.

Add script effect of spell 51864, 51889 and 51910

In addition, dummy effect of spell 51866 and 51872 and dummy aura effect of
spell 51870.
Dummy effect of 51866 might need additional work (see comments).

Code expect additional spell cast by AI (summon dummy at death of related quest
target creatures).
Clarify game_event field values and fix typos.

Thanks to BrightStone for pointing to ;)
Fixed .account onlinelist work.
Fixes in loot roll timer work and related cleanups.

* Changes include (in fact as part cleanup) fix got NeedBeforeGreed locked item
after expire roll timer
suggested by [email protected].
* Added cancel rolling at creatuer corpse remove.
* For NeedBeforeGreed and GroupLoot sued common code for prepare item roll.
Fixed player's tapped creature loot access by group in diff cases

* If player tap creature in group and leave then group will have access to
creature loot if not disbanded
* If player tap creature and after join to group then creature loot will
accesable only by player
* Also RewardPlayerAndGroupAtKill divided to simgle player and group reward
versions used for group tap
and single player tap cases.
Output player name in ObjectGuid player output string.
Restore group rewarding at player kill.
In case player who tap creature in group leave group it must anyway
rewarded with group.
Rename BG_WS_UNK1 -> BG_WS_TIME_ENABLED
Fixed typo in prev commit.
Implement .server log filter and .server log level comamnds.

* .server log filter comamnd let temporary (until config reload or restart)
set log filters state. Or look at filters state.
* .server log level renamed from .server set loglevel but now let look at log
level also.
Add more log filters

* damage - different direct damage calculation tracing
* combat - combat state updates, roll attack result and etc
* spell_cast - spell cast progress and aura apply
Typos in Unit::DealDamageMods

Can be source very strange damage/absorb and any near stored/calculated in
memory values. and crashes also.
Support new raid allowed quest types.
Fix build...
Move apply spell coeffs and level penalties code to new function.

* No reson have 6 copies near to exactly same code.

* This fix problem with apply attack power bonus in some case.
Thanks to Wowka321 for find and reseach problem.
Move enum QuestTypes to QuestDef.h where it only used.

This is also fix build at GCC
After 3.2.0 expected AllowTwoSide.Accounts = 1 for any realm type by
default.
Change AllowTwoSide.Accounts default in code also.

And update config version.

Also note: it not has been propertly updated in prev. time
when config version in .conf.in changed. It must be sync changed in
*.conf.in and in SystemConfig.h.in
Call DealDamageMods for leech DoTs damage
Skinning related fixes

* Show skinning tooltip only after creature loot
(when creature can be explcitly skinned).
* Allow reopen skinning loot if still have not looted items.
ACE realmd, thanks to Zor and Vladimir for windows.
Remove sockets library from UNIX build
Added copyright notice.
Correct premature call of TalkedToCreature.

Only use TalkedToCreature when gossip does not have any following sub menu (and
of course when the prepared npc options does not include any gossip)
Sockets library use finally dropped

Specially thanks to Derex for make this possible! :)
Fix typo in AuthSocket.cpp
Add additional check for UNIT_NPC_FLAG_GOSSIP before using
TalkedToCreature
Output ACE version at realmd start.
Add a small delay for npc despawn related to spell 51840

This will solve problem with summoned GO that does not appear before later, but
does not solve problem with visual effects (which is a generic problem with many
spells).
Implement spell 633 and ranks self casting restrictions in 3.3.x
Update mangos_spell_check.sql

* Add all data from Spell.cpp
* Add missing data from recent commist for added parts of SpellEffect.cpp
More skinning fixes.

* Restore work with money loot.
* Old code sometime generate empty loot windows for normal loot and sometime
skip its.
Code changed to be more consistent. Added new option Corpse.EmptyLootShow that
control
show empty normal loot window in some cases enabled by default:
- if creature expected to be lootable but loot generated empty by some
reasons.
- if creature can be skinnable
If option disabled thne code attempt avoid empty normal loot windows for empty
cases.
* Possible fixed case instant despawn non-skinable creature after normal loot
complete.
Remove a few not needed checks in spell script effect
Add target for TARGET_DUELVSPLAYER_COORDINATES only if not provided by
another way.

This fix for exmple unexpected empry heal if targeted by spell 48438 and ranks.
Fixed crash at .gobject turn command (at *nix at least)
Fixed bug with raid subgroup size update at move member to another.

Also some code cleanups
Allow update subgroup in raid for offline players.

Also prevent crash and wrong subgroup number send from client.
Remove two not needed cast to Creature* and make code more safe
Lost socket.vcxproj referecne in VS projects.

Thanks to j4r0d for catch this.
Prevent negetive proc events from possitive effects of negative spells.

Some negative spells have positive effects with targets not affected by negative
effects of spell.
For example spell 45524 cast negative effecst to target and possitive effect to
caster self.
For like possitive only target of negetive spell will not triggered negative
proc events.
In last cases will avoid triggering glyph 43537 at caster at spell 43537 cast.
Spell 45524 expected apply debuf 55095 to target at cast.
Alow sell item for money and extanded coset without momey in same time.

npc_vendor.ExtandedCost can be negative now that meaning:
price excluded default item BuyPrice and use only abs(ExtandedCost) items).
For example expected used for item 36908.
Implement item 34753, 43015, 43478, 43480, 46887.
Fixed resent radnom problem with looting related to skinning code
changes.

Thanks to boxa for help in research problem.
Implement glyph 43390.

Chance unknown and seelcted by more recent comments.
Restore work talent 18213 and ranks.

Thanks also to insider42 for updating.
Modify way 4x damage bonus claculated for spell 1120 and ranks.

* Now apply 4x bonus dependent from target health in time spell cast,
not from current health in tick.
* 4x bonus applied to own spell damage value, not to total taken damage.
Implement per-tick chance for shard for spell 1120 and ranks.
Implement Treshold in Masterloot.
Fixed triggering of spell 55095 by 45524.

(based on insider42's repo commit 90de00d)

It include reverts commit ca99760e884d82219fff63ecf5f2ca87b02b5924
with less clean implemetation.

[patch 155] Fixed triggering of spell 55095 by 45524. Patch provided by me

(based on commit 90de00d)
Add CharacterDatabaseCleaner to VS2010 filters.
Fix 16164 proc conditions
Allow have reserved entries with empty names in log filters table.
Additional check for HandleAutoBankItemOpcode.
Fixed array free in vmap code
Typo in BattleGroundQueue::AddGroup arg name
Move CharacterDatabaseCleaner.* to Tools group as for VS100 done.


YTDB 323

+ All fixes from forum;
+ fix spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ update fields "*_template" by WDB
+ filling table "creature_movement_scripts"
+ processed 221 caches (3.3.3a)

[demand]

Nice work

[DjAligator]

Mangos 9973 - 9999
Fixed selection BG map difficulty.

Thanks to insider42 for help in research problem.
Restore raid functionality broken after one from 3.3.x switches.

* Fixed typo in raid converting code that triggering raid disband at server
restart.
* Fixed current subgroup show for character and update group memebers data at
move its
in diff subgroups.
Use special function for honored/xp kill check
Fixed typo in recently added group enums.
Update talent 16180 and ranks work.
Add explicit AP damage bonus for spells 55095, 55095.

Original patch provided johonson.
Update max cooldown length req. for spell casting at arena.
Remove target guid in spell with TARGET_FLAG_DEST_LOCATION

Corrects spell animations and visual going in weird directions for these kind of
spells
For non-player at "offline" delete hostile references.

This must fix porblem with call message broadcast from unit destructor.
Group out of range member must based at client existances.
Also move empty mask check from build function to caller.
Leave at AFK applied only to battlegrounds (not arena)
Also restore build...
Implement item 43214 work.

* Original version suggested by timmit.
* Required DB support for target requirement.
Send SMSG_CORPSE_NOT_IN_INSTANCE if player in ghost form tries to enter an
instance without player's corpse.
Talent 51459 and ranks affect only melee auto-attacks.
Restore work talent 12311 and ranks.

Thanks to insider42 for prepare patch for mangos.
Add correct spell chain data for 61024 and 61316.
Use unix styoe line ends in soem files
Use more correct data for prev. sql update.
Next step in fix SMSG_GROUP_LIST structure.

Now assistant/main tank/main assistant show properly
for viewer character also.

Thanks to insider42 for posting patch in Under review section.
Fixed MSG_PARTY_ASSIGNMENT processing.
Limit spell 50988, 59870 targets amounts to expected.
Fixed a bug/typo that prevent to summon a special flying mount.
Move GridMap class (and related structs/enums) to separate cpp/h.

Also rename some structs/enums and fix some code style.
Remove grid state debugging code and move state machine to MapManager.
Some changes in HashMapHolder.

* Use ACE_RW_Thread_Mutex, since there's much more reading than writing.
* Use read lock in Find(), and write lock in Insert() and Remove().
* Correctly lock the hashmap on outside calls.
Fix *nix build.
Remove a piece of trailing whitespace.

YTDB 324

+ All fixes from forum;
+ fix spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ update fields "*_template" by WDB
+ processed 245 caches (3.3.3a)

[DjAligator]

Mangos 10000 - 10011


Redundent empty line.
Rename current version sql updates (0.16/root dir) to 5 digits format
rev.

* order guards not affected in sql updates so this not affect sql guards work.
* TO DEVS: in next sql update commit please check carefully generated by git_is
-s
sql guards for correctness
Fixed map loading .map build checks.

Bug exist long time before recent code moves.
But it not affect in cases proper .map files.
Fixed unix* install.

I forgot update sql updatenames in Makefile.am after its rename.
Add script effect of spell 43365, 50217, 50218 and 50238.
Add script effect of spell 41055 and 45206.
Fixed typo in mangos.sql
Fix wrongly initialized value
Fix sqls
Fix realmd to accept more than 64 connections on windows.
Use schoolmask enum in struct SpellNonMeleeDamage, some indents fix.
Check redundent procFlags value in `spell_proc_event`.

[DjAligator]

All .NetFramework versions has been added

[DjAligator]

Added a program for x86, this one must work if .NetFramework didn't work for you.

[Apple]

nice , keep it up mate :)

[DjAligator]

Mangos 10012 - 10025


Fix charges taking for 16246
Implement CONDITION_QUESTTARGET

For cases when loot dependent from some quest objective complete state.
Revert "[10013] Implement CONDITION_QUESTTARGET"

This reverts commit 4e460746c0947f6cfc1f1150a8eb90257819eae2.
More redundant data check in `spell_proc_event`
Remove unused RewardSinglePlayerAtKill result.
Make spell_proc_event.SchoolMask unsigned.

Also use byte length hex for school mask in mangos.sql data.
Add 16246 proc to mangos.sql
Implement glyph 45623.

Thanks to Most_Mangos, DonTomika, darkstalker for dollution research.
Drop unused member in VisibleNotifier structure and related functions

(based on SilverIce's repo commit e678555)
Also applied mangos code style to GridNotifiersImpl.h
Move item disenchanting static req. checks to server start.
Fix damage for 14278 and 16511 and ranks when dagger is equipped
Change HandleLearnAllMySpellsCommand to learn only player's spells
New LogFilter_DbStrictedCheck filter for DB devs

It's enable by default (prevent show related output) but
in disbled case allow show useful for DB developers different
more stricted DB check output at server loading, including

* Absent GO trap template referecned in some another GO template
* Not set (0) unit class in creature_template
* Absent disenchanting loot for items marked as disanchantble

This all cases can or hard fixed in one step or show false cases y different
reasons.
That why filter active by default.
Fixed unexpected C++ code parsing with *FILTER_LOG in 'if'


YTDB 325


+ all fixes from forum;
+ fix spawn;
+ quest scripts;
+ mob's gossip menues;
+ new teplates from WDB;
+ fix stats of NPC: Alterac Valley
+ fix data "disenchant_loot_template"
+ update tables "*_template" by WDB
+ processed 280 caches

[DjAligator]

Mangos 10026 - 10032


PDump code fixes and cleanups

* At pdump creating will propertly saved NULL field values.
* At pdump loading will skipped adding `character_declinedname`
if name in some way will be changed (explicly or at loading)
SPELL_AURA_ADD_TARGET_TRIGGER long time not use spellmod for work.

Drop dead code.
Reward group for shareable quests at cast event to creature/go.
Clarify client dependence for some MeleeHitOutcome values
Add aura remove modes for expire and absorb shield break cases and use
GetTarget()/GetSpellProto() instead of m_target/m_spellProto
Replace hard coded quest dialog status value with enum value

Some minor code cleanup for readability.
Remove not needed local declaration of dialog status and rename some to
clarify.

Additional cleanup for readability.

[DjAligator]

Mangos 10033 - 10049


Use sometime stored in spell data triggred spell info for dummy auras.
In case unknown triggered spell output more known info for location
problem.
Additinal reqs for spell 49219/51459 and ranks triggering.

* Only at melee attack or spell 56815 hit.
* Spell 49219 and ranks also ignore offhand attack.
Fixed health restore and triggering cooldown for talent 30881 and ranks.
Fixed poison consume by spell 32645 and ranks.

It will consume only caster casted poisons.
Prevent double triggering heal from 63534 and ranks.
Also use more simple and safe checks for added in [10035].
Partly revert [10033] for spell 44394 and ranks related code.

Not all ranks of spell have proper triggered spell info.
Return to old more explicit code.
Expected RAP bonus to damage for spell 1510 and ranks.
Use for spell 49145 and ranks for decrease SPELL_DIRECT_DAMAGE damage.
Implement CONDITION_QUESTAVAILABLE.

Also do come constatification of quest status check functions
and fix one unsafe use std::map operator[].
Never never use std::map operator [] for _read_ access.
Good chance corrupt related structure state ;)
Not in found case but in general.
Fixed share quest in case completed objectives.

* Also fixed CONDITION_QUESTTAKEN for same case.
* Aslo fixed exclusive prev quests check.
Generate talent related spell_chain data instead storing its in table.

* Drop now redundant part of data from `spell_chain`.
* Allow store in spell_proc_event cusom ranks data for ppm for chained ranks.
* Drop now redundant part of data from `spell_proc_event`.
Frop unexpected custom rank data for 26016.

This make spell rank use first rank data.
Store guids instead slot data for trade items.
Fixed show wrapped gifts in trade windows.

Also some fixes for trading related not full read packet spam.
Move trade data to dynamic created structure.

Also possible fix old bug with spam trade cancel after logout.
Fix SPELL_AURA_MOD_HEALING_DONE healing bonus with 0 misc value


YTDB 326


+ all fixes from forum;
+ fix spawn;
+ quest scripts;
+ mob's gossip menues;
+ new teplates from WDB;
+ update tables "*_template" by WDB
+ fix spawn for scripts: "Halls of Reflection", "Pit of Saron", "The Forge of Souls"
+ processed 304 caches

[DjAligator]

Mangos 10050 - 10059


Implement apply non-trade slot item enchanting at trade complete.

Base at original patch provided by arrai.
Fixed talent 58426 broken after 3.3.3 switch.

Also cleanup character auras from wrong duration auras.
Camera System

(based on SilverIce's repo commit 4f2f4ab + next 3 more)
Use UNIT_STAT_CONTROLED for mark unit state under direct player control.


* This allow prevent move home/to caster at apply
* Also replace AI and reset movegens at control time
* Also stop combat and clear threat/hostile list at lost control for prevent
combat with freindly units.
Fix crash when not saved action buttons are removed during spec switch
Use creature equipment from normal _template when id is not set for
difficulty

creature_template of difficulty_entry_N then only need equipment_id when
equipment should be different from the normal creature entry.
Re-add spell proc sql data from [7879].

* It not has been added in commit time to mangos.sql
* It alsow required data updating in family masks.

Thank you to NoFantasy for reseatch problem :)
Type in UNIT_STAT_CONTROLLED
Add to mangos.sql data from 09720_01_mangos_spell_proc_event.sql

Thank you to NoFantasy for pointing to inconsistance.
Cleanup in Player::m_mover uses

* Also fix triggered by related checks unread packet tail spam cases.
* Fix one case when expected death at fall controlled player
under ground has been possible avoided

[DjAligator]

Mangos 10060 - 10075


Drop unused ACE_Stack_Trace in Error.h

This also can fix possible build problem in case use at system old ACE version.
Implement 49220 and ranks
Added missing return statement.
Revision increase.

I am sorry, i forget to apply git_id :(
Removed wrong method const.
Cleanup recent added code.
Fixed recently show up crash in Unit::StopMoving.
Some return values fixes.
Some tuning in consts.
Allow item INVTYPE_RELIC to be equipped by npc from
creature_equip_template
Fixes in pet movments

* Use proper stop packet as expected. In case 0 trevel time used before move
packet
can generate infinity move forward (at client side).
* Avoid reset top movegen before add idle in pet stay command.
* Avoid assign random move to player owned creatures as default movegen.
* Finish follow movegen init including need-stay case.
Really do "Avoid assign random move to player owned creatures as default
movegen."
Remove old, commented code no longer needed in SendMonsterMove
Not need add new cases inline for in-class function definition.

This is redundant from current C++ standart point.
More methods for access/modify ObjectGuid update fields.

* Some related cleanups.
* Also drop unused Player::SetFarSightGUID decalration as reported by LordJZ.
Make object active at applying view on it

also isActiveObject check moved to WorldObject - all worldobjects are inactive
by default, excluding players
this is a final part of cameras implementation
(based on commit efc9623)
Also remove template-way code selection for object for
Map::AddToActive/Map::RemoveFromActive.
This simplify function use from not Map code.
Add IsPassive(SpellEntry*) function and use in cases wjern entry already
known.

Some other small code cleanups
Attempt use more expected by result buffs downranking algo.

* In small rate more fast
* Not affect non-buff ranked spells like 10909


YTDB 327


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new teplates from WDB
+ update table "*_template" by WDB
+ processed 333 caches (3.3.3a)

[DjAligator]

Mangos 10076 - 10091


Fixed crash at remove from world pet under SPELL_AURA_MOD_POSSESS_PET

* Prevent crash at camera list update at attempt increment end() iterator.
* Properly do unapply SPELL_AURA_MOD_POSSESS_PET (GetPet() can return NULL at
call, and not need checked)
* Propertly call unapply at delete auras cases for auras that set player-caster
mover pointer.
Add delayed far teleports for opcode handlers

Some opcode handlers have many code with possible deep calling
far teleports by some reason (death, quest script, etc).
This can be triggering unexpected lost Map context and crashs result.

Note: player login opcode still have disbled delayed teleports (old way work)
just becase Player object created in it and not have flag set.
Calling point look not 100% safe but at this commit this way not chnages for
while.
Use const referecne to opcode handle.
Don't allow cancel passive spells
Fixed ghost teleport and cleanup code.
Use ACE config library instead dotconfpp

NOTE: all config versions update because in old state
it's not compatible with new way loading.
Look for *.conf.dist.in chnages in commit for update configs.
Drop now unused dotconfpp lib code.
Made some Spell.h dependences more explicit.
Resync. opcode names in Opcodes.cpp/.h
Allow loot roll value 100
Implement use .go command with shiftlinks or player name.

* Now if for .go command provided no X Y Z args command will not teleport player
to nowhere.
* Instead command allow used with player name and work as simplifed .goname
(teleport to player _point_ in user instance binding, not to player instance)
* Also command can be used with diferent point coordinates provided shift-links:

- player (result for example .lookup player account)
- creature (result .list creature command)
- gameobject (result .list object command)
- tele (result .lookup tele)
- taxinode (result .lookup taxinode)
Move table in more expected mangos.sql part
Restore work of 1120 and ranks. (Revert of [9962])
Change in event system work with pool system.

* `game_event_pool` dropped and related in momory data generated
based by another pool tables content.

* Pool work with spawed at event and despawned at event object now different.
- If object listed in `game_event_*` as spawned at event start and it's part
of some pool
then all other pool object must be listed as spawned with this event start,
and more,
if pool has mother pool, then all mother pool members must have objects
spawned at this
event start. More short: all object of some top (not have mother pool) mitbe
or listed for some event start spawn,
or not listed for any event start spawn.
- If object listed in `game_event_*` as DEspawned at event start and it's part
of some pool
then nothing special required for other pool objects. Event systemwil
command to pool system exclude for spawning and despawn referenced
object until event end.

* Many checks has been added at event/pool data loading.
* Changes fix crashes related to event/pool common work.

Thanks to NoFantasy for help in research original problems and ways for improve
code.
Really output log level at ".server log level" command.
Use ACE for command line options parse.

Note: "--service run" renamed to "-s run"
in consistence with other serrvice options.

[Dimman]

Gosh :o keep it up Dj =)

[DjAligator]

Mangos 10092 - 10116


Correct 3 more auras to check AURA_REMOVE_BY_EXPIRE mode after change in
10030
Sort functions and cleanup InstanceSave delete code.
Extract instance reset scheduler from InstanceSaveMgr

Reset scheduler code not need explicit access to instance saves,
and no reson mix it with instance save managment code in single class
Fixed typo in function name.
Allow negative X coordinate in .go command
Update G3D up to v8.0b4

+ Got rid of zip lib requirement in G3D...
Still can re-enable code by defining _HAVE_ZIP...

+ Remove silly X11 lib dependency from G3D
Code doesn't seem to do anything yet anyway, and even if, we don't want it :p

+ Fix another weird G3D build problem...

+ Remove some __asm usage in g3d, which is not available on Win64
My editor also decided to remove a ton of trailing white spaces...tss...

+ Reapply G3D fixes for 64bit VC

+ not use SSE specific header when SSE not enabled in *nix

+ Updated project files

+ New vmap_assembler VC90/VC80 Project

+ vmap assembler binaries updates

NOTE: Old vmap fikes expected work (as tests show) with new library version.
But better use new generated versions. Its different in small parts to bad
or good...

(based on Lynx3d's repo commit 44798d3)
Re-apply to ACE hack for support utf8 config files

It has been applied in past to old config loading code.
Prevent retunr mails to not existed characters.

Thanks to laviniu for find bug.
Fixed some cases assign low guid to full guid update field.
List G3D update in NEWS
Rename loginDatabase for consistence with other global db object names
More cleanups in InstanceSave

* Use single function for erase element from save list.
* Make lock bool checks class local (it need be replaced by normal lock object
in future)
* Remove redundent now friend class declarations.
Cleaned up WorldObject::HasInArc
Condition CONDITION_ZONEID (4) extanded way work.

* Condition CONDITION_ZONEID renamed CONDITION_AREAID and now work also with
subzone area ids
* Second arg of condition cna be 0 or 1 now in in case 1 check "not in area"
case
* Also all condition related error output include condition id.
More modes for .go commands

* Now '.go' command can be used with creature_entry/gameobject_entry shift links
(output of .lookup creature/object commands)
* Now '.go object' command sipport id-mode and name part mode similar .go
creature case: .go object id #gameobject_id or .go object $namepart.
* HandleGoHelper use in more commands also.
Pool/event info in .npc info and .gobject target commands
Prevent access to out of range [0] element of empty string at utf8
convertion.
Add and use actual bounding_radius/combat_reach per model for
characters.

Data are stored in same table as for creature (like dbc models data), and
provides the default values for playable races.
Currently the bounding and reach are applied only at creation and load. Note
that these values are modified by scale. For player case, scale is always 1.0 as
default.

For later, auras and spell effects that change scale and/or modelid must in
addition make sure bounding_radius are updated accordingly to the new scale
and/or model (combat_reach does not seem to be affected by such changes, and is
always 1.5 for players).
Add function Get/SetObjectScale and update code where scale is set.
Move code for initialize player model data and scale to same function,
InitDisplayIds
Rename GetObjectSize function to GetObjectBoundingRadius

To reflect better what the function should actually return and also to clarify
when used in misc calculations.
Some cleanups in Instance loading code.

* Remove reduncent chekc and args for MapInstanced::CreateInstance(const uint32
mapId, Player * player)
* Rename for avoid name duplication raw InstanceMap creating to
MapInstanced::CreateInstanceMap
* Move lookup code of player/group bounde instance save to
Player::GetBoundInstanceSaveForSelfOrGroup
Store associated InstanceSave for dungeon map in Map object
Add function to update model_info at changes to scale or model.

* At every change to model or scale, the related data
(bounding_radius/combat_reach) is now updated accordingly (note that player
combat_reach are not changed like creature).
* UpdateModelData is called from within SetDisplayId while changes to scale has
explicit call to UpdateModelData after new scale is set (mostly for aura scale)

* The updated values are calculated by
(scale*bounding_radius)/(scale*combat_reach)
* Database values for bounding_radius/combat_reach are expected to be relative
to scale like 1.0
Remove some wrongly initialized fields for dynamic object.

This will correct visual appearance of spells like for example id 26573.

YTDB 328


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new teplates from WDB
+ update table "*_template" by WDB
+ fix ICC (sniffer)
+ processed 361 caches (3.3.3a)

[brotalnia]

I have a problem with mangosd.exe and realmd.exe. Ive downloaded the latest ones but when i start them they shut down immediately. There is no error message or anything, they just shut down as soon as i start them. What can be the reason for this issue?

[DjAligator]

Mangos 10117 - 10131


New config option set min size of auction deposit fee.
Check gameobject scale at loading (strict DB error filter)

This let avoid check scale value at it
Add model data for undead player that got lost for rev 10109
Check expected `creature_model_info` data for player races
Add a few comments about DYNAMICOBJECT_BYTES + fix typo in one.
Avoid use EquippedItemInventoryTypeMask mask for not item targeted
spells check.
Fixed recent problem with enter to dungeons in group.

Problem related to implicit get map id from player in Group::GetBoundInstance
when in some cases check done before player mapid update.
Fixed typo in mangos.conf.in comment.
Add pool/event ids to diff creature/gameobject list output commands.
Code style cleanup in Level2&3.cpp
Double damage reduction as expected in 3.3.x
Since 3.3 pets receive 100% of master's resilience

(based on zergtmn's repo commit 21eba43)
Add cooldown marker for talent 56342 and ranks triggering spell.

(based on zergtmn's repo commit 87d1309)
Proper stacking 30108/348 anr ranks from 3.2.x

(based on zergtmn's repo commit 7588ca9)
Fix spellpower bonus received by 54181



YTDB 330


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new teplates from WDB
+ update table "*_template" by WDB
+ data from sniffs
+ processed 374 caches (3.3.3a)

[DjAligator]

Mangos 10132 - 10144


Cleanup code for Group::_homebindIfInstance
Fix targetmap of spell 53434 and 70893

Thanks to Blaymoira for 70893
MaNGOS 0.16 release.
Bump for 0.17.0 development.
Update build checks for mangosd/realmd.
Switch to support client 3.3.5a (build 12340)

Merge branch '335'

You need regenerate dbc/map/vmap files.

Special thanks to TOM_RUS for continue work at next client versions support :)
Fixed item/go checks for active raid quests.
Include openssl libpath in MANGOS_LIBS for later proper lib search

Also fix typo in ax_check_openssl.m4
Fix camera iteration in CameraCall function also dropped not needed for
now viewpoint's member

(based on SilverIce's repo commit 885724b)
Reuse GiveQuestSourceItem code for check case

Also show correct amount added item in case partly existed amount.
Fixed commented part of SpellRangeEntry structure
Read/write time as uint64 in [character_]account_data

Client currently expected uint32 value and time_t fit but
in DB time_t stored for portability as uint64 for this and other tables.
Set correct real caster for 48181 and ranks
Fix movement impairing effects remove for 65547

[DjAligator]

Mangos 10145 - 10154


Use better (but still hack) way for gameobject size calculation

* This is also hack because some float with unknown exactly value used as 'size'

* Another not resolved problem: go size used in creature target autoselection,
so for large 'virtual' go
creature can seelct strange points near in attempt select 'free' place near
target.
Implement SCRIPT_COMMAND_PLAY_MOVIE (19)
Dynamic objects not have interactive size.
Improve .gm ingame command

Thanks to Vladimir for suggestions
Build tbb on linux/unix

Unix specific notes:
* Use --with-std-malloc in configure to disable tbb, if you have problems or you
want to use the default or another allocator.
* Even if you disable tbb, the library will still be built and installed, so you
can still use it manually.
Disableand exclude code use for gui promt from G3D

* It mostly useless becase we use console error reporting way for other cases
* It have porblem with G3D_OSX based build

Original patch provided by Imbecile.
Prevent autostoring not empty bags

Thanks to The_Game_Master for detailed information about the bug.
Useless use 'std::string' for temporary store 'char const*'
Add GOSSIP_ICON_* for id 11 to 20

Note that all may not be in use(or exist), and needs more research

Adjust one enum creature type flag to CREATURE_TYPEFLAGS_CAN_ASSIST
Adjust one enum item flags to ITEM_FLAGS_INDESTRUCTIBLE
Fixed crash at loot item and etc after recent check add.

[DjAligator]

added
maps 3.3.5
buildings 3.3.5
dbc 3.3.5

[DjAligator]

Mangos 10155 - 10168


Add script effect of spell 66744
Add shared object for auras of same spell and move spell proc code to
its own file, also spread procs by auras and effect indexes.
Fix makefile and make gcc happy.
Fixed 2 format args errors in debug output.
clean-up after recent changes
Fix sql for character_aura and pet_aura
Add bzip2
Added libmpq to dep/

This is from official repo (SVN rev. 300)

Additionally includes free implementation of stdint.h and dirent.h for VC++,
aswell as Visual Studio project files.

Special thanks to faramir118 for Windows support.
Update vmap_extractor to support new vmap implementation.

Note: This is not compatible with current assembler, wait for upcoming commits

* Now also supports Linux (CMake) and Visual Studio 2010,
see README for build and use instructions
* Uses libmpq for now, since at project start stormlib did not work
properly on 64bit linux.
* Should be a lot faster, a few badly written lines ate most CPU time for
nothing...

Special thanks to arrai and faramir118 for additional code and fixes
Update vmap_assembler to upcoming new implementation

* Note: vmap_assembler tool will not compile until final commit of new vmap
system
* Now also comes with Visual Studio 2010 project files and CMake files
New collission system (vmap) implementation

Important:
* You have to re-extract and assemble vmaps
* Update your config file, new option 'vmap.enableIndoorCheck' added

New features:
* Include WMO+DBC area information for correct subarea identification and indoor
check
* Support for WMO liquid (fishing/swimming in cities, instances and oterh WMO
based environments)

Technical changes:
* New Bounding Interval Hierarchy (BIH) data structure for better performance
* Referenced model data for reduced memory usage,
needs more files, but reduces overall file size from ~1.9GB to ~550MB

Additional Authors:
arrai (DBC handling and indoor detection)
faramir118 (windows support and bug investigation)
And of course thanks Vladimir for a lot of patience and support!
Romve now unused Stormlib, it also included a redundant copy of zlib.

Note that WoW 4.x support for libmpq still unclear, but in any case
this Stormlib version is outdated too and will not support it either,
even if we need to switch back.
Bump vmap extractor version to 3.00
Add dummy aura effect of spell 32045, 32051 and 32052.


YTDB 331


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new teplates from WDB
+ update table "*_template" by WDB
+ data from sniffs
+ processed 437 caches (3.3.3a)
+ processed 15 caches (3.3.5a)


added

Reamld sql full
characters sql full

[DjAligator]

Mangos 10169 - 10189


New config option Quests.IgnoreRaid

It allow if enabled (disbled by default) do non-raids quests in raid.
Fixed typo in prev commit :/
Clarify acoount password/lock command errors.
Make git and users happy with contrib/vmap_extract_assembler_bin/make
vmaps.bat

* Unix encoding
* Never never use in any cases not only mangos filenames with spaces. Tools can
generate
expected nightmare level without like help from your side ;)
Fix infinity loop in 31884 spell code
Fix special targeting for spells 812/9347.
Fix incorrectly blocked line of sight in certain locations.

I really should know by now that floats are not infinitely precise...
Use std::isnan in the hope more non-MS platforms provide it.

Note that G3D::isNaN() is simply wrong IMHO...and not even inlined.
One day, there will be a usable C++ standard not light-years behind good old
C...
Add custom code for triggered part of spell 39105
Clean up some comments and align/indent as done for similar spell code.
Add "missing" spells in commented form for Aura::TriggerSpell()
Implement ITEM_FLAGS_NO_EQUIP_COOLDOWN support.

Also server side check for ITEM_FLAGS_INDESTRUCTIBLE
Fix spell 55681. Thanks Danstahr.
Allow stacking some tracking bufs, and prevent stacking some other.

For example item 25548 buff expected to be allowed stacking
but spell 19885 not allowed.
Better tracking stack checks with include one not catched non-stacking
case.

Spell 41446 expected to be non-stacking with other trackers.
And tradition typos :(
fix auras adding to previously added holder
Fixed SMSG_BATTLEFIELD_STATUS packet.
Fixed visibility constant refresh problem with pet direct control
spells.
2 non-sense code lines cleanup.
Add missing locales to vmap extractor.
Update realmd opcode list.

Thanks to Phazerz for helping with research.

[isevendeuce]

Thanks for this YTDB is the best!

[DjAligator]

Mangos 10190 - 10227


Fix another numerical corner case...

...hopefully the last one.
Slightly different approach to tree bound intersection.
Update vmaps extractor/assembler binaries using vs2008.

* This make some ppl happy who not have installed VS2010 runtime.
* Also vmap assembler include recent fix for absend locale support,
that ofc only affect ppl who before can't use assembler with this locales
supporting client.
* Also small update for vmap extarctor project .gitignore
Small cleanups related target effectMask check.
Use for Transport::Update arg uint32 type as for other world objects
Fix "Documentation" filter in ACE VC 10.0 project
Some gender dependent spells
Use enum for instance reset event types, some related cleanup code.
Fixed typo in enum value name.
Add to `playercreateinfo` original player orientation field.

It still not filled. Patch with correct values welcomed ;)
Partly revert old changes in load instance reset time.

* Its has been added for raid/heroic instances in time adding
support MapDifficulty.dbc. Its wrongly assign reset events
for each instance instaed use generic event for map/difficulty pair.
In result at this event triggering instance can be attempt resetted
multiply time.
* Also comment this in InstanceResetEvent fields notes
Fix 33763 and ranks final heal and mana return on dispel and on expire
Correct function call sequence in possess aura handlers

also removed not needed ResetView call in dummy aura handler

(based on SilverIce's repo commit c3f02ed)
Broadcast packets only if worldobject is in world

There is no sense to do that for objects that not in world - those objects are
unknown for clients
and their packets will be ignored

(based on SilverIce's repo commit 6305402)
Rename isInFlight() to IsTaxiFlying() and UNIT_STAT_IN_FLIGHT to
UNIT_STAT_TAXI_FLIGHT.

Also add IsFreeFlying() function to Player class.
Rename `item_template`.Faction to Flags2 and define some values for it.

Thanks to Shauren for research flag ITEM_FLAGS2_COST_REQUIRES_GOLD meaning
and inspiring in general what must be done long time ago with field rename
and other enum values listing.
Add one more known value for item flags2.
Correctly implement flying mount restrictions in zone 4395 by use of
special area flag.

Also drop existing spell_area entries if exist, workaround not needed anymore.
Implement ITEM_FLAGS2_HORDE_ONLY and ITEM_FLAGS2_ALLIANCE_ONLY

* Check item_template data
* Check at equip/use
* Skip at loot if not compatible
* Skip in vendor list if not compatible
Implement ITEM_FLAGS2_EXT_COST_REQUIRES_GOLD use instead sign of
ExtendedCost field.
Add proper data for character orientation at creating.
Output leaned before disabled ranks at talent re-learn or spec swith in
proper order.
Do unmount at expire restricted flight zone debuf if still in restricted
zone/etc.
Fix aura procs for spells with auras that can't trigger
Fix iterator update in Unit::RemoveNotOwnSingleTargetAuras
Implement ITEM_FLAGS2_NEED_ROLL_DISABLED.
Small final (as i think ;) ) fixes for restricted flight zone

* Fixed my horriable typo in 58600 effect code. Thanks to zergtmn for pointing
to it.
* Remove redundent cast 45472 in 58600 effect code (it casted from 58601
already). Thanks to porteyoplait.
* Prevent restart 58600 debuf timer at temporary leave zone and return to it.
Implement ROLL_VOTE_DISENCHANT disable

* for player without reqired enchanting skill
* for item without disenchanting possibility
Re-implement ROLL_VOTE_DISENCHANT disable case

Also implement NEED_BEFORE_GREED disabling ROLL_VOTE_MASK_NEED
instead skip item as expected in recent client changes.

Thanks to TOM_RUS for help in understanding proper way work.
Hmm, maybe i still do wrong something... ^^

Also count disenchnt roll as greed in ACHIEVEMENT_CRITERIA_TYPE_ROLL_GREED
Update playercreateinfo_action/playercreateinfo_spell

* Drop some food action buttons
* Drop attack spells for caster classes
* Use expected simlifed spell version 20154 (it replaced by full version at
learn spell 53408 and similar)
In code used helper code for support 2 versions as fake non-stacking ranks.
* Some other old "max ranks" of talents and spells now are permanent bonuses
known from start (only "max rank" for spell exist)
Restore trinket procs when no specific spell is defined for proc
Fix spell 36032 stacking and procs
Fixed typos in mangos.sql

* Typos in `1playercreateinfo_*` tables. Thanks to Astoria.
* Lost recent field rename in `item_template`. Thanks to bobi88.
Fixed visual bug that some deleted auras still show at client side

(based on commit b10058e)
Restore proc events at full miss/immune spells to target.
Implement spell 44572 affect to permament stun immuned targets.

This also fix unexpected triggering effect any unrelated spell casts.
Small code style cleanup.
Propertly show empty vendor list for empty item list.
Fixed GO_JUST_DEACTIVATED for despawned by default gameobject.
Generate gameobject loot only at open spawned gameobject.


YTDB 332


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ "quest_template" for 3.3.5a - FULL sniffs
+ "quest_poi" for 3.3.5a - FULL sniffs
+ "quest_poi_points" for 3.3.5a - FULL sniffs
+ processed 40 caches (3.3.5a)

[DjAligator]

Mangos 10228 - 10246


Missing send packet in empty vendor item list case.
Small cleanup in taxi related checks
Avoid use enum valuse/define like naming style for enum type name.
Use VMAP::VMAPLoadResult instead raw int loadMap result.
Fix mechanic-related check, thanks to VladimirMangos
Fixed check in SpellAuraHolder::HasMechanicMask
Fix typo in IsNoStackAuraDueToAura()
Cleanup in pet stable handlers
Implement SPELL_AURA_OPEN_STABLE (292).

(based on Wowka321's repo commit 213ceb0)
Implement additional damage proc on hit for Spell 8024 and ranks.
Set flag for offhand melee spells to allow proper triggering of
weapon-specific effects.
Fix mangos.sql

I just had to forget one thing...
Fix some spells proc from spells that don't deal damage/heal
Fix expired spell interrupt
Rewrite internal work chat command system.

* Use single command search function with recursion and reuse it in now more
simple
and consistent for execute/help/loading
* Add intergiry checks for hardcoded part of commands list. Fix some cases base
at it.
* Fixed diff small problems in past code:
- in console single symbol commands rejected (without dot start)
- .help not output propertly subcommands list for not found subcommand
- some other...
Traditional crash fix :/
Implement .stable gm command for open pet stable anywhere.

Maybe command not so useful for stable case because spell can be learned,
but it example how can be packet allowed depndent from player possibility
when some functionality base at many packets recieved from client.
Same way possible can be used for auction anywhere, maybe some other cases.

Also it will very usefull for 2.x/1.x branches where no another way... ;)
Allow have custom starting area team/personal rating.
Restore work killCredit and kill achievements in regular difficulty
instances.


YTDB 334


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ processed 73 caches (3.3.5a)

[DjAligator]

Mangos 10247 - 10269


Prevent lost items at problems with auction loading.

This will prevent adding to DD item data garbage not accessable from anywhere.
Now item will mailed back to owner.
Implement applying proper penalty spell when making use of talent 46917.
Don't interrupt area effects for channeled spells from target side
Select auction store by house id only.

After this commit auction auctioneer guid used only for select auction house in
packet or loading.
Next task replace it in DB by houseid, dependence DB data from creature guid
isn't good.
Clarify error message for one from redundent `commamd` data case.
Implement reputation_reward_rate for quests and creatures

* In addition, implement "flat" reputation for quests, where a value in
RewRepValueN is given. Human diplomacy will not affect the total. The rate
however will be applied, where a faction is defined with a rate for quests.
Value in database are expected to be *100 of the actual value given (before rate
are applied).
* New database storage can contain rates for quest/creature/spell reputation and
will affect the base value given as reward. When for example the quest reward
for a faction should receive 30% more reputation points, the rate can be set to
1.3.
* This will fix issues with certain quests that are using the expected
RewRepValueId but where the outcome has been lower than expected.
* Note that if the rate is set to 0.0 it will disable reputation gain for the
faction and type.
* Reputation rate for spells (spell effect) is not yet implemented
Small cleanup in Unit::HasAura() to prevent redundant upper_bound calls.
Remove dependence auction data from auctioneer guid.

* Field `auctioneerguid` replaced by `houseid` and table reanmed to `auction`
(it list auctions and `id` is auction id).
* Update related code.

* SQL update fill `houseid` field by old `auctioneerguid`
BUT: SQL update expect that you world DB named `mangos`.
If this not true for your case you need modify SQL update BEFORE APPLY
in 2 placed in part "mangos.creature AS c, mangos.creature_template AS ct"

* Another small possitive result: now possible easy select auctions related
to some auction store (1-3 is one team actions, 4-6 another team auction,
and 7 is neutral auction store for both teams
Fix aura remove in Unit:: _UpdateSpells
New `auction` command with subcommands for look different auction stores
from anywhere.
Fixed typo in "alliance" in recent commit changes.
Correct old typo in GetReputationOnKillEntry function name
Fix some iterator in Aura::HandleAuraModShapeshift
Move pre-0.16 release sql updates to subdir
Revert [10259] -_-
Fixed table `auction` name in characters.sql
Not allow listing pool elements in more one pool.

NOTE: sql update remove forbided by commit duplicates from pool_* tables in
random way.
So for more porper results DB better manually check and fix before apply
it.
This is mostly note for DB projects devs.
Fixed build at Unix after auction changes.
Add comments for fields in struct FactionEntry, related to rep spillover
Implement CONDITION_ACHIEVEMENT and CONDITION_ACHIEVEMENT_REALM
Fixed typo in comment.

Also thanks to SkirnirMaNGOS for pointing to this long existed patch.
If schoolMask present for proc, ignore SpellFamilyFlags check
Fixed typo in CONDITION_QUESTAVAILABLE fail case.

Not affect mostly code work, because used only for not existed quest data,
that checked at loading. So only possible at reload quest templates with
drop related quest.

[DjAligator]

Mangos 10270 - 10279


Implement basic system for reputation spillover

* Database table needs data for each faction that should give spillover to other
faction(s). One faction may give spillover to max 4 other spillover factions.
* The spillover rate is multiplied with the points after bonuses and reward rate
is set, Rate is given as: 0.5 for 50% gain, -1.0 for 100% loss, etc
* It is possible to restrict spillover faction by rank. If player has a higher
rank with the spillover faction given in database, no spillover will be given
towards this faction
Include ObjectMgr.h to reputationMgr, helping *nix compilers to know
what to do
Add option for search distance to getHeight() functions and make
Creature::FallGround() use VMaps properly.

This finally prevents flying creatures from falling to infinity (basically
instantly diappearing) in several instances,
aswell as prevent creatures from falling inside larger solid object around the
world.

Default height search is untouched, needs more research on how creature AI etc.
will be affected.
Avoid some redundent and recursive calls to SpellMgr singleton.
Make gcc happy after last commits. Restore Unix build.
Fix initialization of DoSpellBonuses
Use more appropriate vector container instead of list as container for
CreatureEventAI holders

vector container provides less time to access to contained elements
Use typedef CreatureEventAIList, some other code style cleanups in
EventAI code.
Reserve space for EventAIHolder container
Unused function declarations after aura holders.

[marko94]

Bad post :)

[DjAligator]

Mangos 10280 - 10309


Implement glyph 43425
Send proper account amount in guild in SMSG_GUILD_INFO packet.

Data seen for example in client command /guildinfo output.
Fixed typo in function name
Note: prev. commit of same author (Toinan67 is alt. nick name ;) )
Also added some more checks in ref. function.
Fix some typo in mangosd config file

This typo forces config to be saved as UTF8 in some text editors.
Clarify related table in error message for unknown mangos string entries
Fixed memory leaks at guild unload/disband
Also drop redundent m_PurchasedTabs field
Use lazy computition for Guild::GetAccountsNumber
Use unsigned type for `creature_addon`.`guid`
Fixed crash in result double deleting auras in some cases.

Pre-aura holder code always remove auras from diff lists before un-apply aura
affect call.
Restore this way work for new aura holder code. This prevent different strange
affects
when aura find by search when it already expected to be removed from target,
including case when in
result som un-apply called code aura deleted 2 times.
Unsummon pet if pet direct control spell expire out of visibility range
from owner.
Adjust creature models system

This change will:
* make it easier to use cached data directly without any modifications
* correct issues regarding invisible models
* simplify certain aspects of model selection itself and make it somehow easier
to control and maintain special cases.

Two new fields added to creature_model_info, to store modelid_alternative and
modelid_other_team
* _alternative holds an alt. model, for cases where gender are the same, or is
not male/female.
* _other_team is generally used for totem models, but may have future use.

This commit will possibly break a few things (visually) and will require DB
projects to update their creature_template models data.
It is advised to use cache data as-is, and in addition fill creature_model_info
for certain models, totems in particular, for expected appearance.
Simplify startup check for creature models
Use new fast/safe way for access aura in drink item spells.

Access useing aura->holder->some_effect_aura let have always pointer to exactly
expected aura from same cast if this need.
Fixed typo in mangosd.conf comment.
Correct a not exitan...non-existin... a word that is often spelled wrong
Add dummy aura effect of spell 47190 (part w/ buff(transform))
Add dummy effect of spell 24930
Move ChooseDisplayId to Creature class for access from script side
Drop CMSG_SET_FACTION_CHEAT support.

No reported long time and now finaly broken by spillover rep changes.
Clear tavern rest when leaving building and prevent forced unmount when
in GM mode.
Add new script call ProcessEventId

Let script library know when some event is about to start. Event id's may be
found in several sources, such as spells, GO's and transport/taxi paths.
Database scripts may be prevented by returning true from script side whenever
needed. If false, DB script will run like normal.
New database table event_id_scripts will need a ScriptName for the event id, in
same way as for example areatrigger_scripts.
Fixed some strange GetAura arg values.
Init guild create date at create in same value in memory and DB.
Add dummy aura effect of spell 31606

Note: it is expected that script side update player displayId at end of related
taxi path. If not, player will be stuck with the model.
Clarify bool used for script call ProcessEventId

isStart is default true. For transport/taxi cases, it may be false for event
id's at arrival (event id ending)
Use loop instead repeating code in models check.
Add additional AddMenuItem function for GossipMenu

This version allows using id of some text from database instead of text itself,
and will then simplify locales especially from script side.

Thanks to Vladimir who woke up to hundreds of questions and lines of weird test
code, helping me out with all the stuff i didn't understand (which was about 75%
of the changes done in here :P )
Restore spell boosts apply.

It has been broken in srange way at moving function to SpellAuraHolder :/
Must restore work many additional auras affects
Rename two tables to prefix scripted_, making the tables have consistent
names

Both tables (areatrigger / event_id) are used explicit to store ScriptName for
script library use.
In addition rename to ScriptName in instance_template
Fixed mangos.sql after recent changes.
Make AreaTriggerEntry passed in script call const.

YTDB 336


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ "creature_template" for 3.3.5a - FULL sniffs
+ The Ruby Sanctum (full)
+ processed 73 caches (3.3.5a)

[Avidgamer]

Good work mate, keep it up.

[DjAligator]

Mangos 10310 - 10326


Clarify argument in emote related functions, expecting emote id
Prevent lost sql update content at git_id -s use in some cases.

To devs: please update git_id binaries
Allow store in DB same spell auras from different casters.

This fix errors at auras save to DB for like cases.
Drop now unused Aura::m_deleted.

Most functionality move to similar flag of AuraHolder.
Implement commands for work with areatriggers in game.

* all teleport commands support new areatrigger and areatriger-target shiftlinks

* .go trigger now let select areatrigger or areatrigger target as teleport point

* New commands:
.trigger - show detail info about areatrigger including all
requirements
for teleport with shift-links to items/keys/quest
.trigger active - show all currently activated by character areatriggers
.trigger near - show near areatriggers

* .lookup item now show [usable] postfix if item can be used/equipped by
selected character.
Make AuraHolder::IsDeleted() really work.

In fact it has been broken originally when added in Aura long before move it to
AuraHolder.
Make gcc happy once more...
Rogue's energy rate in mangos.conf
Gender field in SMSG_WHO packet.

Also fix warning in class declaration forward

Prevent double remove aura holder at stacking limit.

If aura holder have 2 or 3 auras with fit to aura type stacking limitation
code can attempt deleted old aura holder 2/3 times.
Reserve mangos string ranges for old client specific strings.
Share some code for faction related commands.
In chat command handlers use char* arg instead "const char*"

We in any case modify args string content at parsing in commands,
so cast it to char* early. This let avoid lot later casts.

Some other code style exist in related code.
Implement achivement view commands.

This is fist part for achievement related command set.
Edition commands will added in some later commits when ready.

Two command added:

* .lookup achievment $partname - show fit achievements
(id, shiftlink, complete date for selected player).
shiftlink included similar data as generated by client for achievement
shift-link
(complete state, complete date, marked completed criteria).

* .character achievements [$playername] - show completed achievements for
selected player
Implement new basic functions for chat command parsing.

* Now can be used as quotes any strings with symbols ' " [] around.
For example can be used: .additem [Tourch] or .additem "Tourch".
And in similar cases wher before [] or "" only canbe used in commands.

* New functions support propertly extraction shift-links as optional first args
* Also added more safe functions for extraction int32/uint32/float values.

For more wide use new functuons specialized extraction functions also need
chnaged to same way work.
This is goal for future work at this part code.
Improve process for Use() of GAMEOBJECT_TYPE_SUMMONING_RITUAL

This allow GO's not summoned by any to be processed and use the spells as
defined in GO template as expected.
In addition some new checks to determine if GO should despawn and if group
membership should be checked or not to allow use.
Process GAMEOBJECT_TYPE_FISHINGHOLE in normal way as for other GO's


YTDB 337


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ correction fields "RewMoneyMaxLevel" and "RewOrReqMoney" in "quest_template" from sniffs
+ processed 96 caches (3.3.5a)

[DjAligator]

Mangos 10327 - 10351


Implement reputation rates and aura effects for
Spell::EffectReputation().

Also apply rates after percentage aura modifiers, so auras always
give expected percentage of final value independant of "hidden" rates.
Avoid explcit client max level use for selction bg/arena bracket.

This allow use brackets like 85-89 existed for some maps
if at server allowed levels > 80. Before like players placed
into bracket for level 80 always.
Improve target selection for spell_script_target creature targets

Fixes a problem where database has more than one entry for a spell and target is
explicitly provided by script side.
Add dummy aura effect of spell 10255 and dummy effect of 10254
More basic chat command parsing functions and its uses.

* Commands .debug update and .modify bit removed as redundent
* Command .debug getvalue now can output values in float/int/hex/bitstring
formats
* Command .debug setvalue now ca accept values in int/float/hex/bitstring formats

* Command .debug mod32value renamed to modvaue and can add int/float or apply hex
mask
(in 3 modes: |= &= &=~ ) to value in update field
* Command .debug moditemvalue added similar .debug modvalue for item case.
* Command .npc set movetype now propertly update spawned in world creature state.

* Command .modify spell renamed to .debug spellmods and restored to working
state.
* Commands .account password and .account set password now allow use quoted
strings
for passwords and then now possible set from chat/console passwords with white
spaces.
* Many commands converted to new functions without modify functionality
except better error detection in some cases at wrong command syntax use.

* Also fixed warnings in reload commands after prev. chat commit. Thanks to
SkirnirMaNGOS for reporting.
Save cast item guid for auras also.

This must fix another way duplicate aura adding to DB error.
It also prevent wrong stacking work for weapon equip bufs
in cases when its allowed for both wepoan indepndently apply.
Traditional post-commit typo fix :(
Update shift-link related functions for chat command parsing.

Also

* Better single | detection as non-link case (doubled by client)
* Commands .pdump now allow quoted filename (usefull if filename path include
whitespaces)
Make sure DynamicObjectUpdater::VisitHelper does not overwrite existing
PersistentAreaAura and leave orphaned aura in m_modAuras.
Server side checks for casting non-combat spells in combat.

Interrupt casting non combat spell spell at neter to combat
and prevent it casting in combat (last checked by client
but better recheck at server for prevent cheating).
Correctly handle auras with infinite duration in code added by [10335]...
Create Map version for GetPlayer/GetUnit fucntions

* This let make map local way access for cases when player/all units
expected to be at same map (for scripts cases for example).
Ofc, still exist many places where code expect world wide player search.
Spell casting for support far target cases, groups/guilds/chat/etc packets

* Function Unit::GetUnit depricated and will removed soon.
* Function GetCreatureOrPetOrVehicle renamed to less horriable GetAnyTypeCreature
name.
Restore lines ends in Player.cpp :/
Some fixes for recent chat code changes.

* Fixed crash at absent optional literal. Thanks to MysteriousSouL for reproting.

* Converted mode commands use new way parsing functions with fixing posible crash
cases.
Fixed typo in .ticket code
Cleanup achievement code and add new commands.

* .achievement - let see achievement state and list criteria with progress data.
It provide criteria ids/shift-links for other commands.
* .achievement add - let complete achivement (set all criteria progress to max)
with related events.
* .achievement remove - let reset achievement criteria progress and undo
complete state for achievement.
Command also partly remove rewards (title part).
* .achievement criteria add - let increase criteria progress at specific amount
or to complete state
* .achievement criteria remove - let reset/descrease criteria progress and undo
criteria and related achivement complete state if need.
Correct order of spell id's in dummy aura effect
Fixed typo in LANG_COMMAND_ACHIEVEMENT_CRITERIA.
Fix passive spells that are active without shapeshift and certain
shapeshift forms only.

Currently, 63411 is the only affected spell, but implementation is hopefully
generic enough to cover future cases.
Fixed crash in .send items

Also fixed some missed cases from prev. typo fix.
Fixed wrong ACHIEVEMENT_CRITERIA_TYPE_GAIN_REPUTATION (46) check.

In result wrong check characters complete
exalted reputation achievements at create or any reputation change event
with negative reputation. Fix prevent new cases but not do anything with
already wrongly recieved ahcievements.

Also:
* Avoid use PROGRESS_SET at normal achievment criteria progress update
becase achivement/counter in normal way can't decrease.
* At achievment criteria progress loading check that progress counter less
or equal max counter value.
Add missing Player check in unapply part of [10345]

Yes copy&paste is evil...
Implement work item 50351 and 50706.
Fixed some typos.
For item 50351 and 50706 fixed work in case no offhand weapon.


YTDB 338


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ processed 107 caches (3.3.5a)

[DjAligator]

Mangos 10352 - 10361


Implement support explcitly started timed achievements.

* Player::StartTimedAchievementCriteria can be used for activate timer
for specific explicitly starting timed achievement by timedRequirementId
in script.

* for ACHIEVEMENT_CRITERIA_TYPE_COMPLETE_QUEST this done in core.
Avoid access to DB at view GM tickets by chat commands.

Also
* Show response text if added at view.
* Show tickets amount at console .ticket use instead unexpected no player error.
* Allow use ticket number in .ticket respond case.
* Some code cleanups.
Use time constants instead of hard coded values for STOP_TIME_FOR_PLAYER
Correctly clearUnitState at Interrupt of WaypointMovementGenerator for creature
Drop unneeded groupFlag and rename it properly

(based on Schmoozerd's repo commit 1e8c842)

Also drop `achievement_criteria_requirement` data use at start timed achivement:
its will be checked at criteria update (and complete) case. So wrong criteria will
started maybe (timer set but always fail - progress not updated.
PacketLog.* not used in core some time already so drop it.
A small spoon of changes and cleanup for WaypointMovementGenerator

* Initialization to ensure destination is always set (prevent evade problem)
* Simplify how behavior for node is processed, incl fix MovementInform script call (based on idea/past code from Quriq14)
* Make sure last node is also processed correct (DB script for last node will now work as expected)

As usual if any problems occur, you can call our toll free customer support number.
Implement spell 45449.
Restore triggered auras cleanup at main aura expire after auraholders adding.
Send proper error message at password check fail.

It specailly fix 1.x client case that not understande used for later clients 4-byte message.
Remove trailing space.

[DjAligator]

Mangos 10362 - 10380


Implement creature_movement_template

Template can be used for several cases:
* Unique creature that are already spawned in database (requires creature.MovementType=2 like guid based creature_movement)
* Summoned creature that has a pre-defined path (requires creature_template.MovementType=2)

Note that creature_template.MovementType=2 should be used with care, and must not be used for creatures that may be summoned in random locations in world.

Added additional startup checks for existing creature_movement-table
More wide use ObjectGuid in way remove MAKE_NEW_GUID uses.

Also
* Fixed some amount wrong uses low guids as full player guids.
* Add private without body ObjectGuid(uint32 const&) for catch wrong assigns low guids to ObjectGuid.
In some cases need assign "0" guid, then use ObjectGuid() instead.
* Fixed .pdump commands work.
Restore build with gcc and cleanup includes a bit.
Implement ACTION_T_MOUNT_TO_ENTRY_OR_MODEL (43) for creature eventAI.

Read doc/EventAI.txt for details.
SQL query to update existing scripts are included (convert from using ACTION_T_SET_UNIT_FIELD, field 68)
Add portable way for hash specialization adding.

Use it for ObjectGuid hash specialization
Making sure CreaturesAddon are re-loaded after creature evade
Use AI function DoCastSpellIfCan for eventAI ACTION_T_CAST
Implement UNORDERED_SET support.

Signed-off-by: VladimirMangos <[email protected]>

Also added compatibility code for old Visual Studio versions
for non standard way hash calculation for hash_set.

Thanks to Lynx3D for help in Unix side testing.
Rename UnorderedMap.h -> UnorderedMapSet.h
More wide use ObjectGuid in group code.

Also drop some unused functions.
And fix some uint32 -> uint6 guid assigns.
Implement EFLAG_RANDOM_ACTION

It allow execute one random action from EventAI event actions
instead each action from event actions.
Drop unused team-argument in ChooseDisplayId -function
Fixes for EFLAG_RANDOM_ACTION

* Field limited to uint8 so use proper flag mask (0x20 now)
* Search of selected action code also fixed.
Updated MySQL client libs to 5.1.49
Fixed build at VS90 with TR1

As problems show VS90 with TR1 different from VS100 by expected namespaces.
Simplify use Guild::BroadcastEvent
Avoid double lookup member slot in guild operations.

Also more wide use ObjectGuid in guild code
and fixed some uint32->uint64 guid assigns.
More wide use ObjectGuid in arena team code.

As always in this commits line fixes for uint32->uint64 guid assigns.
Finaly drop MAKE_NEW_GUID.

This meaning that ObjectGuid only proper way create guid from lowguid now.
But packet handlers still generate uint64 guids. Some DB fields also loaded uint64 values.

Also possible existed not catches et uint32->uint64 assigns.


YTDB 339


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ processed 117 caches (3.3.5a)

[TheCwalk]

I have downloaded all the files , can I run server with that ? Or I need scripts ?

[DjAligator]

yes you can run the server.

[DjAligator]

Mangos 10381 - 10403


Implement generic system for racial model selection

Table creature_model_info store creature entry to use model from (or explicit model). The selection is based on a base modelId and racemask.

Hacks for shapeshift models removed (data included in SQL update)
Dropped no longer needed creature_model_info.modelid_other_team, as creature_model_info can and should be used instead (sorry, this is what happen when author doesn't do full research :) )
Add missing holiday id<->battleground id definitions for AB
Store guid instaed pointer for first user of GAMEOBJECT_TYPE_SUMMONING_RITUAL

This is more safe way in pointer store comparison with.
LAso Some related code cleanups.
Fixed reset time calculation for some cases.

Most real fix suggested by Schmoozerd and Toinan67
and some my code style part coding ;)
Traditional post-commit typo fix.
Remove Unit::GetUnit and update it callers.
Correct creature entry selection for raid difficulties

Original patch provided by False.Genesis.
Fixed quote parsing after optional arg in chat commands.

This is restore work .guid commands for example.
Make spawntime arg really optional as before for .gobject add
Typo fixes
(based on Darkrulerz's repo commit 758f4c7)
Add several new script calls for InstanceData

OnCreature Evade/Death/EnterCombat and in addition OnPlayerLeave
The functions are intended to help doing instance related tasks (in other words, not for the general AI of creatures).
Restore build at Unix after Unit::GetUnit drop.
Small correction in SetReputation to avoid confusion
Add script call for InstanceData, OnPlayerDeath

Called when a player really dies and also unrelated to the source of the death (for example a player can die indirectly from some mob ability, but must be registered. Achievements, other special events)
Remove redundant use of this-> in recent implemented script calls

Thanks porteyoplait for pointing it out /bonk author
No debug log output when a certain ability is active
Send GMTicket to SendGMTicketGetTicket instead text.
Fixed wrong difficulty selection and possible crash.
Fix mixed up FactionEntry to lookup in SetReputation
Fixed typo in doc/EventAI.txt
Fixed crash in .aura command for spell without auras.
Some code style cleanups.
Use ObjectGuid in packets and fix some uint32 guids cases.
Stricted name check at chat command data loading from 'command' table.

[DjAligator]

Mangos 10404 - 10422


Additional checks for call assist.
Restore remove spell affect 58427 after stealth fade.

(based on Wowka321's repo commit 45c5757)
Fixed work .learn and other spell commands with unlearned talent shift-link.

Unlearned talent have -1 as rank in shift-link, return instead first rank.
Add -o <outfile> option to genrevision.

This gives more flexibility to build systems that don't run genrevision with desired destination as working dir.
For example a build system may run:
build/tools/genrevision -o build/src/shared/revision.h
Fix mistake in recent debug log output change (ref 10395)
Restore work of 47230 and ranks
Fix wrong sql
fix broken sqls for spell_proc_event..
add a BindIP warning to worldd/realmd config files
Add some missing class/struct forward declarations and includes.
Constantify some functions in InstanceSave.
Sort triggered spell chains 44203 and 42231 in proper place `spell_chain` data.
fix 71611 proc and remove check for family name if no spell_proc_event is defined
Fix Battle/Guardian elixirs stacking
Merge not-skill linked spell lists in `spell_chain`
Check redundant single rank spell data in `spell_chain`.

Also, add empty lines to end of file and apply code style tosome sql updates.
Avoid send stop packet in PointMovementGenerator when unit is not moving

Also never send stop packet when destinationHolder hasArrived, it's expected that unit is already not moving.
Correct typo in function name.
Fix 71642 proc conditions

YTDB 340


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ processed 130 caches (3.3.5a)

[DjAligator]

Mangos 10423 - 10446


Load most spell chains data from SkillLineAbility.dbc

* Output error for redundent data in table
* Drop detected data from `spell_chain`
Fix 50334 additional targets part
Add comment in Aura::CanProcFrom
Remove not needed checks from IsNoStackAuraDueToAura
Drop redundant data from `spell_proc_event` after recent spell chain changes.
Fix line ends :/
some format string fixes
Improve detection removed ranks for spell in `spell_chain`
Correcting issues with flying creatures falling to ground at death.

Simplified the way FallGround works and death states are set in a more logical way when a mob is in fact DEAD_FALLING.
Visual will in some cases not be correct. Notes in code for details.

Thanks to Lynx fixing Map::GetHeight
It now return mapHeight as last resort, making FallGround work as expected.
This fix reveal one (known) bug, and therefore a temp hack is added in TargetedMovegen, to be sure Z is not the ground Z for a creature that are able to fly.
Other creatures will follow by the ground level Z (in other words, they will no longer follow in the air).
Rename ASSERT -> MANGOS_ASSERT and related fixes

ASSERT hard use in predictable way because diff. 3rd party libs code
redefine it inf different ways and hard make sure that used in end
of mangos define version. This is real detected problem make some
expected assert checks ignored and so bugs not detected as expected from code.

In addition made related changes:
* Common.h header expected to be first include in any src/game/header except most simple cases.
* Related FILE.h header expected to be first include in FILE.cpp
* Fixed some absent includes and type forwards for safe build without PCH enabled.
* Avoid using MANGOS_ASSERT in src/framework code
Implement EVENT_T_MISSING_BUFF for self buff check

Also added amount spell stack checks at loading
for EVENT_T_BUFFED and EVENT_T_TARGET_BUFFED.
Add missing braces - should fix 51664 and ranks
Fix recently added uint64 use for query in char deleted commands.

In mangos DB we store full guids only in *_aura tables for caster.
Fix typos in invisibility aura handlers
Fix engineering bonus for injectors
Fix GetHeight() to return height within actual search distance only.

Good news: Fixes fishing bobber
Bad news: Mobs follow into the air again unless larger search distance is used
Increase search distance at height search if we know expected limit.

When we know that point above .map ground search at least until ground level for vmap height.

Good news: Fishing bobber still fixed ;)
Good news: Mobs not follow into the air again
Implement spell 55680
Fix 64962 bonus for 47541 and ranks
Fix armor bonus part of talent 33853 and ranks
Fixed expected packet size for SMSG_SET_PROFICIENCY
Fixed scripted AI init for TemporarySummon/Totem summon code

Call AIM_Initialize before adding to map instead after calling.
This make this call order similar other cases.

Re-implement in more safe way single cast spell targets system.

It also fix case when target can unexpected lost single target aura at phase switch
in case when target still visible in new phase (pet for example)
Small fix for single target auras: remove caster only auras

Avoid remove different caster aura if target have similar diff caster auras
in case when auras from diff casters allowed for spell.

[DjAligator]

Mangos 10447 - 10489


Certain compilers refuse to erase const_iterator...
Use base run speed * 2 as fall speed.

It equal to base flight speed and not dependent from real creature speed as expected.
Typos in enum names and comments

Also typos find by darkstalker and Neo2003
Skip wrong guid movement packets.

Also fix src/game/SharedDefines.h line ends corrupted in prev. commit. :/
Replace ASSERT by MANGOS_ASSERT
Typo in World field.
Fix disease consume part of 49020 and ranks
Fix 54821 proc
Add missing break, thanks to nos4r2zod
Implement 60764
Fix proc of 51692 and ranks
Changes to corpse decay/respawn times for creatures

*CORPSE_DECAY values adjusted (Rare/RareElite values are guessed) with more proper.
*RATE_CORPSE_DECAY_LOOTED is now 0.0 as default and a modifier of the creatures spawntimesecs are used for corpse decay.

Respawn time for creature is now set at death (result: database spawntimesecs are in most cases the time it takes from kill to respawn)

Overall, this will affect four things:
* corpse will stay visible longer before looted
* corpse will stay visible longer after looted, when creature has long respawn time
* creature without loot will "skip" the default decay times and then fix a "should respawn almost instant" -problem
* creature with loot and very short respawn time may respawn instantly after looted
Restore update area aura values at caster/around targets.

For example, at related improvement talent learn by caster.
It has been disabled in aura holder code changes.
Fixed unexpected area aura stacking from same caster at spellmods reapply.

In fact it general problem possible with area auras if it re-casted
non-standard way from code. But known only test case for mangos-0.12 branch.

Thanks to ciphercom for reportand original research of problem source.
Fix error message in extractor tool
Implement spell 6495

Also implement proper work CMSG_FAR_SIGHT.
This packet control switch view point from far sight object to caster
and back wihtout modify far sight object seelction.
Clean up the .gitignore files.

* Move the settings for VS and CMake files to /.gitignore
* Drop now unused .gitignore files
Revert a part of [10463] and move them back to the .gitignore file in the sub-directory
Implement SPELL_EFFECT_REDIRECT_THREAT

Note: all spells with effect expect additional code for redirection reset.
Until code adding redirection work longer that expected.
Patch partly rewrited with move new data into HostileRefManager
and added redirection to threatAssist. Also bug fixed with
redirection threat to unit not in hostile list yet.
Proper reset threat rediraction for existed spells.

In 3.5.5a this is: 34477, 57934, 59665 and triggered spells.
Implement proper triggering for spell 34477, 57934
Also fixed charges amount (1) for main spell auras.
Typos in comments in recent patches.
Rename some opcode handler to better follow used naming style
Fixed totem owner faction/level set for creature onwer case.

When totem created creature owner alos not in world yet.
Drop vmap_debugger.

After new vmaps version it not work and useless.
Implement SPELL_AURA_MOD_PET_AOE_DAMAGE_AVOIDANCE (310)

Original patch provided by rsa
Fix structure SMSG_SPELLHEALLOG for 3.5.5

This also fix proper show critical heals
Cleanup vmap_assembler

* Drop dead code
* Use std::string instead of char*
* Use std::cout instead of printf()
Implement SPELL_AURA_HEAL_ABSORB (301)

Used for example in spells 66237 and 70659.

Also rename CalculateAbsorbAndResist -> CalculateDamageAbsorbAndResist
Fix 31228 and ranks
Fixed heal amount for some cases heal absorb
Implement item 49623 visual effects.

Original patch provided by Darkruler.
Implement heak absorb for periodic heal

Also fix SMSG_PERIODICAURALOG for periodic heal for 3.5.5
Fix a bug causing creature dynamic flags to be removed at normal loot preparation.

In addition add use of UNIT_DYNFLAG_TAPPED_BY_PLAYER
Added check to see if creature is tapped for isAllowedToLoot()
Use prefix m_ for member variable in motionMaster

Some additional code style cleanup.
Add basic function MoveWaypoint() to manually start creature waypoint path
Finally add README to vmap_assembler

Use for auraholde/aura GetStackAmount uint32 result.

uint32 result used in most expressions for stack calculation/compare
Alos uint8implicitly casted to int by C++ in expressions that generate unexpected
signed/unsigned warnings in comparisons (uint8 +1) > uint32 and similar.
Check school mask for SPELL_AURA_MOD_AOE_DAMAGE_AVOIDANCE

* Some spells expect this.
* Check SPELL_AURA_MOD_PET_AOE_DAMAGE_AVOIDANCE just for similarity,
currently no spels with aura 310 with special school masks.
Use casterGUID check for delaying holder since possible stacking same spell from different casters
Implement SCRIPT_COMMAND_MOVEMENT(20) to start/change movement

datalong can be 0:idle, 2:random, 3:waypoint. In case 3, creature must have a existing creature_movement_template.
Command start movement for source of script. If source is not creature but target is, it will apply to target.
Optionally creature entry can be defined (datalong2) and start movement for this if found nearby (search radius defined in datalong3).
Fix checking text id's for creature_movement_template
Correct some typos in comments for SCRIPT_COMMAND*


YTDB 342


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ processed 130 caches (3.3.5a)

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ The Ruby Sanctum: fix of physical damage from parses
+ Event: "Zalazane's Fall" - sniffs (require support script)
+ Event: "Operation: Gnomeregan" - sniffs (require support script)
+ processed 168 caches (3.3.5a)

[Dimman]

Thanks for the update, been a while since the last :) Keep going!

[DjAligator]

Mangos 10490 - 10502


Arena ratings chnages is signed, fix debug string accordingly.
Search player in player list in update fields data prepare is bad idea.
Fixed crash in debug output for some data.

It well known at account data loading if character/account have
in account data string look like pritf format string (with %s for example)
Implement EVENT_T_TARGET_MISSING_BUFF
Really allow proccesing buff events in EventAI.
Clarify not working state for target buf events in EventAI

Unclear how provide target for event...
Re-work struct ScriptInfo and use union for data fields.

Enumerate SCRIPT_COMMAND_* and move it away from world.h
Add a crude documentation of script command processing

It is mostly copied from source files and should be subject for further improvement.
Arrange case SCRIPT_COMMAND_* so that they come in correct order.
Fixed typo at copy-paste in ArenaTeam::BroadcastEvent
Extend SCRIPT_COMMAND_TALK to support random selected text

In addition to adding fields for text id storage (in total 4 text id's), also added a comments field for developers notes in scripts (it may help those being old of age to remember what goes on in a script).

Correct wrong character in mangos.sql
Correct comment for ACTION_T_FORCE_DESPAWN, action do have param

[DjAligator]

Mangos 10503 - 10512


Move `*_respawn` tables to `characters` DB.

This allow have in `mangos` DB only world static state data.
Prevent damage player in sanctuary by pet or other controlled unit.
Remove unused stuff
Implement 5 new SCRIPT_COMMAND_*

All commands can only have creature as the affected by command
*_SET_ACTIVEOBJECT - switch activeObject state on/off
*_SET_FACTION - changes faction
*_MORPH_TO_ENTRY_OR_MODEL - changes model to model from creature_template entry or model id explicit
*_MOUNT_TO_ENTRY_OR_MODEL - mounts on model from creature_template entry or model id explicit
*_SET_RUN - switch walkmode on/off
Extend SCRIPT_COMMAND_TALK with option to set language for text
Arrange case SCRIPT_COMMAND_ in correct order, also in ObjectMgr

Some additional code style corrections.
Fix some "foo initialized after bar" gcc warnings and remove some unused variables.
Reimplement aura stack checking EventAI events.

* In consistent with other EVENT_T_TARGET_* apply event
to current combat target.
Fixed SPELL_AURA_MOD_COMBAT_RESULT_CHANCE dodge chance apply to auto-attacks result.
Fixed cast item remove at trade enchanting in some cases

Also nit allow item use spels casts if item in trade.



Added
Buildings 3.3.5
Maps 3.3.5
DBC 3.3.5

[GGAMERR]

I want to apologize I can not write English correctly.
I mean I hope you understand.

When you update problem before coming to boss Ins (example: Ins Raxx) when the hidden cluster are close to them.
Please help Me ...!:confused:

[DjAligator]

That's is a scriptdev or ytdb problem. But i don't know where is Cluster close to, to give you a correct information.

[GGAMERR]

Mr.DjAligator you have a question ...
You better mangos or trinitycore?:confused:

[DjAligator]

I didn't use trinity so i don't know how it is but i think mangos is better.

[GGAMERR]

I tried using the mangos, but I was always a lot of bugs, or maybe I just did SQLFile ancestry, but always right and order of commands I use the forum. Amber even close I still use it in Boss·hay saw a lot of bugs.
You bug closed without explanation or proper to complete the server has a mango?:confused:
I have an Iranian (but not terrorists;)) and the English have a problem I'm typing.I hope you understand my order.
(Again thank you)

[DjAligator]

I quit having server because i can't host them 24/7 so i don't know a lot about mangos bugs. It also depends on scriptdev for npcs spells and on ytdb for quests npc items and so on it could also be the problem and from them not all from mangos.

[DjAligator]

Mangos 10513 - 10524


Clear grid *Check/*Searcher clases use

* Check class considered have all info select object in world from suggested but grid walker list in some grid.
This also meaning that Check must always have focus object around that (and in same phase) fit objects must be.
* Searcher only must ask Check and know how from all objects fiting to Check select result object(s).

For this reason and for better compatibility removed first arg (searcher) form all Searcher classes.
Instead expected used Check::GetFocusObject() object if need ( by always need check and simolify Check classes
phase checked in Search classes). This also restore source code compatibilty in related lines with prev.client
version branches code.

* While focus object adding fixed possible wrong phase object selection at stealth detection and at corpse searches.
New option PetUnsummonAtMount

Make possible disable pet unsummon for non-fly mounts (1.x way work)
Default value set line lost
Fix small typo in class ExplodeCorpseObjectCheck
Remove wrong comment, reputation rate for spell is implemented.
Prevent emotes animation in feign death state.

In 3.x this has been posisble only with cheating tool.
Fix delaying spell with 2 or more persistent area auras and store ObjectGuid instead of Unit* on DynamicObject affected set
Implement CONDITION_QUEST_NONE

For case when need check that quest not taken and not completed in past.
Fix iterator update, thanks to VladimirMangos
Fix periodic procs - spells that require periodic healing to proc need to be defined in spell_proc_event with procEx PROC_EX_PERIODIC_POSITIVE, by default all procs without it are negative
Fix proc from periodic crits
Fix compilation for UNIX-likes


YTDB 343


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ processed 180 caches (3.3.5a)

[GGAMERR]

thanks...!+rep

[DjAligator]

Mangos 10525 - 10554


Add missing () to expressing for proper prio.
Implement server side global cooldown check.
Also pet/controlled unit global cooldown code replaced by new placed in charmInfo structure.

Thanks to nos4r2zod for testing and gcd range check implement.
Disable CombatSpell check for triggered spells
Run creature_movement_scripts also at first waypoint
Water level in movement use fixes.

* Move selection allowed upper and lower heights for target point
into near point core function used for contact/close point selection.
Selection base at possibility target point searcher fly/swim(or walk by water bottom).
* Use vamp water level data so have proper water level in instances in movements.
* Use increased ground search distance for water level case.
Fixed client reject any login attempt after WOW_FAIL_INCORRECT_PASSWORD receive.

Problem similar all all client versions.
Spells with SPELL_ATTR_EX6_NO_DMG_PERCENT_MODS must ignore all damage mods
Aura SPELL_AURA_ALLOW_ONLY_ABILITY not prevent auto-attacks.
Revert [10528], simply wrong (scriptId already called properly)
Fixed second and later resets schedule for raid/heroic after server restart.
Add optional argument to SummonCreature, summon as active object

When true, the summoned will be able to load grids as needed.
Extend SCRIPT_COMMAND_TEMP_SUMMON_CREATURE to set summoned as active object

Field data_flags 0x01 will enable active state
Fixe typo in command help text.
Fixing some comments in mangos.sql

Not all sql tools like the mix of comment styles in import of dump, so using inline style.
Use more near for final point coordinates for Z calcualtion.
Fixed structure SMSG_RESYNC_RUNES
Allow set afk/dnd message in afk/dnd state
Fixed ObjectGuid::IsUnit

Also some better string format for pet guid case.

Thanks to zergtmn for find problem.
Fix handling of spell 14157 and 14189 so they really apply combo points after current spell finished.

Also spell 70802 from new item set needs same treatment.
Output debug only note for known not implemented packets

This is packets that have allowed to receive setting (not STATUS_NEVER)
and WorldSession::Handle_NULL handler.

Mark some packets in this way.
Better way mark not implemented packets.
Fixed EffectActivateRune activate only expected runes amount of some rune type.
More correctly check delay time for spell with speed.
Implement missing part spell 47568 functionality.

Original patch prowided by False.Genesis.
At schedule second reset update real reset time.

Missing part of prev. related commit.

Also without this code at second reset after restart server will go to infinity loop.
Fixed field types in mangos.sql in consistant with related sql updates.
Fix 55880 proc
Add some vehicle flags, thanks to zergtmn and community
Two more cases where AURA_REMOVE_BY_EXPIRE mode can be used
Fix wrong procs when spell hits with no damage

[DjAligator]

Mangos 10555 - 10577


Remove not existed function declaration.
Add frand function for random floats with min/max, similar to urand
Add optionial arg to Unit::SetFacingTo which is passed to SendMessageToSet
Fix spell "Spinning" (64385) for item "Unusual Compass" (45984)
Add world state id in comments for all hard coded state id's
Remove reundenant spell store for temporary unsummoned pet.

We not use this data and now always have proeprtly save current pet
when it temporary unsummoned and avoid it overwrite by another cases.
Avoid ask AI for direct controlled creature at attack.
Also fix warrning double->float in recent commited code.
Cleanup WorldSession::HandlePetAction

Also fixed attack target seelction base at packet content instead direct player selection.
Remove unneded arg for Unit::SendPetAIReaction.
Implement CMSG_PET_STOP_ATTACK.
Not allow charmed by player creatures have threat list.

Original patch provided by zergtmn.
Fixed loaded DBC count.
Implement SMSG_SPELLINSTAKILLLOG
Revert VS90/game.vcproj changes in [10551]
Drop unused column 'realmid' from the table 'character_tutorial'
Don't save holders from channeled spells
Store spell entry of triggering spell on triggered, original patch provided by insider42
Properly remove dual-wield flag at spell unlearn.
Drop unused Spell::m_triggeringContainer
Add end file empty line to some files.
Fixed non-weapon offhand equip after my recent commit.
Fix world states related to arena season.

Replace the "in progress" option in config (as no such thing exist) with the expected "previous arena season id".
Prevent diseases to be dispelled while 50536 is on target
'shuttingdown' -> 'shutting down' in log

YTDB 344


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ processed 186 caches (3.3.5a)

[DjAligator]

Mangos 10578 - 10589


Use static call for IsBGWeekend in BattleGroundAV
Better wording in log for shutdown cancelled case.
TARGET_ALL_RAID_AROUND_CASTER include caster only for positive spells.
Rename some local variables in random move generator for easier reading
Add spell_proc_event data for some relic related spells.

Missing ones were 67356, 67363, 67365, 67379, 67381, 67384, 67386, 67389, 67392.
Remove dual ERROR in logs
Prevent lost aura connection with item at Aura::ReapplyAffectedPassiveAuras

Thanks to Lynx3d for research problem and testing.
Make GO type 10 become nice and shiny: sparkling animation and jingle bells

When GO is active for quest, same as GO type 3.
Also add comments for future development of gameobject dynamic flags
Update taxi mask size for 3.3.5a
Make GO type 5 sparkle at related quest active
Make GO type 8 activate and sparkle at related quest active
Always activate GO type 3 when quest id is defined (and active)

GO may be "lootless", but events at looting can happen


YTDB 345


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ repopulation of fishing holes
+ processed 192 caches (3.3.5a)

[DjAligator]

Mangos 10590 - 10610


Check if GO is requirement of quest to activate sparkle if it is
Simplify LoadGameObjectForQuests for case GO type 3
Make GO type 2 activate/deactivate

As with similar GO's that are not interactable (gameobject_template.flags|4) as default, GO's of type 2 becomes active when player can take a quest (or deliver quest).
Cleaning up code a bit, in related functions for recent commits
Use equal_range instead of lower_bound/upper_bound pairs

(based on zergtmn's repo commit 0499169)
Add new functions to Set/RemoveShortFlag (uint16, lo and high part of uint32)
Apply restrictions to vmap options.

After switch to new vmap version and later height check code chnages
some vmap related options now outdated.

* Option vmap.ignoreMapIds removed. You can't now diable vmaps use for selected maps.
* Option vmap.enableHeight must be always enabled for normal work server and server
at startup now pring error if it's diabled. Option still supported just for special
work cases (debug, new clients testing, etc).

Possible soon option vmap.ignoreSpellIds also will be removed, because like los ignore checks
must be in spell code instead options.
Enable by default vmap.enableHeight and vmap.enableLOS

mangosd.conf version updated.
Create enum GameObjectDynamicLowFlags and use instead of hard coded
Attempt fix data corruption for some localization structures with GCC use.

By unknown reason GCC generate wrong code for locale structures declared in header after pack pragma.
Correct size of animprogress for GO Create()

Add a default define and use it instead of hard coded value.
Some additional minor corrections for transport GO's
Amother attemp fix locale structures corruption.

Possible real source of problem: existing in code mixed
std:: structure templates instanting under pack pragma and out.
And this incompatible structure layouts wrongly mixed used by GCC.

So all std:: strcutures used moved out from pack pragma guards.
Add GO_DYNFLAG_LO_ACTIVATE to GAMEOBJECT_TYPE_GENERIC and merge similar cases.
Replace one hard coded value w/enum name. Additional code style cleanup
A couple more spell_proc_event entries for relics.

Missing items were 38360, 40714, 45509, 45144, 50454, 50455, 50456, 50457, 50458, 50459, 50460, 50461, 50462, 50464.
Fixed infinity loop at grid loading

this also probably solves the problem that object tries to be loaded twice
Fix loot for victims being creature type critter
Handle GAMEOBJECT_TYPE_GENERIC at Use() to trigger despawn of GO

In addition, a check is added to prevent unexpected call to Use() at received opcode. Despawn of this type GO can then only be used with explicit call to Use()
Update melee miss chance calculations...finally.

Also thanks to Revils for correcting effective skill for spells that don't use weapon despite being melee/ranged ability.
I consider it proven that all classes shall benefit from intellect for weapon skill increase.

But better formula for chance would still welcome...
I consider it proven that all classes shall benefit from intellect for weapon skill increase.

But better formula for chance would still welcome...

YTDB 346


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ fix spawn "Pit of Saron" from sniffs
+ processed 205 caches (3.3.5a)

[DjAligator]

Mangos 10611 - 10636


Made some values const
Revert "[10611] Made some values const"

Reason: It makes no sense to make a local variable const.

This reverts commit 49e3184d69056738701bc15d9b7f982bf11d7bbc.
A bit of cleanup in ByteBuffer::hexlike
Replace ACE_ASSERT with MANGOS_ASSERT
Add script effect of spell 66741
Simplified trade distance checks, GROUP_UPDATE_FLAG_POSITION flag handling moved out of Map

note: need avoid Map::PlayerRelocation calls now and use Player::SetPosition instead
Fixed array access in SCRIPT_COMMAND_TALK loading check.
Properly update objects usable state at GM-mode on/off.
Clarify premade groups mode config option.

Also prevent mark group as premade with 0 time wait.
It's any way useless becase at next tick group moved to normal team mode.
Fixed MSG_MOVE_HEARTBEAT structure.

Thx Wojta for pointing.
Add new field RequiredClasses for quest_template

* SkillOrClass is converted to RequiredSkill (and then field can contain skill id only)
* Field ZoneOrSort has no longer a function in quest requirement, and RequiredClasses must be used instead where class limits are expected.

To restrict a quest to one class or more, use bitmask of class in RequiredClasses. RequiredSkill works like before.
Set respawn delay for BG creatures before set dead state.

This prevent save to DB wrong respawn time and unexpected in wrong event state spawn BG creatures.
Make .respawn work correctly with BG event spawns
Fix quests w/QuestFlags QUEST_FLAGS_AUTO_REWARDED
Implement SPELL_EFFECT_CLEAR_QUEST (139)
Fix bad bandate check.
Fix logic in FillRaidOrPartyManaPriorityTargets and FillRaidOrPartyHealthPriorityTargets
Use ObjectGuid for player's selection and unit's target
SQL update for prev. commit
Drop function GuidHigh2TypeId

Added ObjectGuid version Aura::GetCasterGuid()

But for prevent big problen with backporting AuraHolder
to mangos-0.12 in most cases still used old uint64 version
Aura::GetCasterGUID.

Recommended use new version where possible in clean way
as done for some cases in commit already.
Convert Set(Get)ChannelObjectGuid to ObjectGuid way.

Also fix typo in debug output for prev. commit.
Small code style cleanup in quest related functions
Small comment style fix in mangosd.conf
Correct behavior for completion of quest objectives.

Rename related function to SendQuestCompleteEvent for clarification of when it's expected to be used.
Include non-percent mana cost in EffectDestroyAllTotems mana return.

Also small speedup for no-return spells.
Convert many opcode handlers to ObjectGuid use.

Also re-enabled anticheating check for bank window open
base at .bank command access rights.
Ignore another map target for text emote.
Implement server side check combo points req. for spell cast.

Thanks to nos4r2zod for problem research.

YTDB 347


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ processed 220 caches (3.3.5a)

[DjAligator]

Mangos 10637 - 10658


Better totem summon cases selection.

But added check still not allways work. Unclear better way selections for summon prop id 61
More appropriate for warrior spell fail result for combo point check fail.
Making dummy effect of spell 54530 be positive effect.
Implement instance guids with proper HIGHGUID_INSTANCE use.
Fixed use item dynamic/item proto flags.

* List its independelty. Each from this 2 fields have own flags. Cleanup lists.
* Not copy proto flags to item flags update field. This fix heroic item versions
show in client in result mixed use ITEM_DYNFLAG_WRAPPED (0x8) with ITEM_FLAG_HEROIC (0x8)
* Update uses to proto case use for some cases where before wrongly has been used item dyn.flags
* For ITEM_DYNFLAG_UNLOCKED (0x4) set for item at unlock and check for prevent re-unlocking.
This mostly for future case when will be implemented partly loting items support.
* For ITEM_FLAG_LOOTABLE (0x4) check loot absent or conflicting setting with containers/casted at use items.
Report wrong cases art loading.
* Better check related loot tables content using ITEM_FLAG_PROSPECTABLE and ITEM_FLAG_MILLABLE
Implement spell 56826
Update the ACE part we use to 5.8.2
Remove wrong check preventing lootable itesm have at-use spell casts.

But note: like at use spells cast at loot open not implemnted yet.

Also fixed typo in ITEM_DYNFLAG_READABLE.
Use more make sense corpse expire check timer period.

Use 3 hours timer when bones really expired by Corpse::I***pired code each 1 hr
just lol ;) So restore old 20 min time used long time ago.

Thanks to TGM for pointing to patch.
Preserve creature dynamic flags at UpdateEntry
Show die animation at totem destroy.

Or any creature type die with linked unsummon.

Original patch provided by Eggxp.
Typos in mangosd.conf.dist.in

Also thanks to Marik for additional typo fix and diff preparing
Enchanted spell 8017 and ranks should apply to weapon by client auto selection
One more typo in mangosd.conf.dist.in
Fixed combat log being bugged by pets without name
Allow set pvp flags from creatures *_addon data
Implemented MSG_MOVE_KNOCK_BACK opcode

* Player's knockback movement now smooth and doesn't looks like teleporting
* Cleanup WorldSession::HandleMovementOpcodes, separated opcode specific and generic movement handlers code
* Handle Feign Death aura interrupting into more appropriate place
Allow creature to offer same quest for more than one game event
Add support for monthly quests

Quest that can repeated each month are set by quest_template.SpecialFlags |0x04 flag
Quest are reset at midnight the first day of each month.
Note: for the time being, quest must also be set repeatable (SpecialFlags |0x01)
Rename quest function HasFlag to HasQuestFlag
Separate quest_template.QuestFlags from SpecialFlags

Create enum for SpecialFlags (database flags and internally computed)
Added related functions for specialFlags and update code accordingly.
Add enum as argument for quest special/flags functions

YTDB 348


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

[DjAligator]

Long time no updates


Mangos 10659 - 10737


Fixed mistake in [10653] that causes player to fall from the transport at teleporting to another map
Make quest for game event be independent of source

Create new table and convert existing data.
Simplify how game event quests are activated during event by adding generic function to set quest active/inactive.
Any quest in game_event_quest are disabled until event start (and deactivated once stopped)
Update VC10 filers for new ACE
Implement partly item looting

* Not deleted normal item loot at first loot window close.
* Save current item loot content to DB for later continue looting.
* Cleanup spell effect SPELL_EFFECT_OPEN_LOCK check code
* Cleanup Player::AutoStoreLoot calls
Fix totem animation at normal unsummon.
Rename arena_team_stats fields for better fit to stored values.
Allow use faction data for cases raceMask==0

Also some related code cleanup
Implement ACHIEVEMENT_CRITERIA_TYPE_HIGHEST_*_RATING
Timed Achievements, Fail-Support and Opcodes
Implement CONDITION_*ITEM_WITH_BANK conditions.

Similar CONDITION_*ITEM but including character bank content in counting.
Fixed mana amount for overheal case for talent 31785 and ranks.

Also thanks to Wojta for patch code improvements.
Restore build at real C++ compilers after recent timed achievements commit.
Convert some Unit owner/etc guids to ObjectGuid way.
Allow damage own pet in sanctuary.

Also mome repeating code to new function.
Include `item_loot` into pdumps
Show some SPELL_AURA_MOD_DODGE_PERCENT auras as debufs as expected.
Ignore BOA items reputation requirements at use.

Item reputation requirements checked at buy, and in quest case
related quests expected to have own reputation requirements
preventing rewarding items with not fit reputation requirements.
Fix repeating looting for milling/prospecting.
Send to creature/etc Update call real diff from last update and use it.

Now in case when creature/etc some tices not updates in result stay
in not active (no near players or active objects) cell some important
timers (corpse decay, summon timers, group loot expire, aura durations, etc) will
updates at real diff time from last prev. update call.

For some systems added exclude use real diff time because current limitations
like move generators. So its stay use last tick diff and considered freeze and
skip all time while creature in not active map part.
Revert "[10675] Ignore BOA items reputation requirements at use."

This reverts commit 4ce902e5d9c3cfc635c0eff1ba3552da5ecd0c5b.

Check done at client side so useless skip it at server side.
Proper fix expect show diff items in vendor list depndent from required reputation.
New table `npc_vendor_template` for comon item data for diff vendors.

In vendor list show own vedor items + template ites if any.
Vendor template item lists selected by id stored in creature_template.vendor_id
Update item buy code for new way vendor item lists work.
Added new Cell::Visit* functions to visit grids with center in (x,y) coords

* This fixes possible problems with Spell::FillAreaTargets(center of search should be (x,y) position, not spell caster's position)
* Cleanup Cell class, removed old and unused code
New table 'item_convert' for convertion items.

* Implment vendor at show replace BoA item with reputation requirement
by identical item without rep. reqs for player that fit this requirements
of original item.

* Table also can be used for store item convertion data form one team items
to similar other team items. This case not impement but added function easy
used for it.

* Note: strict single convert for item not created problem for both way use:
item converted for same team or all, can't be original item for conversion to
another team.
Revert "[10677] Send to creature/etc Update call real diff from last update and use it."

This reverts commit 10784a8c7cc81c468b5411e973d36ecf31de9603.

Main reason: impossibility for me as commiter test problem and fix all corner cases problems.
Fixed mangos.sql `creature_template` default content after adding vendor_id
Fixed creature_template loading after vendor changes.

Thanks to insider42 for problem research.
Update outdated comment
UInt32 timer class copies instead using time_t timers for mstime cases.

Also cleanup weather update code and some random code cleanups.
New version of patch for send real diff from last update.

In new version last update time stopred for specific Cell that store all world objects
placed in it. All objects of Cell updated (or not updated) in same time.

Original version provided by ciphercom.
Restore some item checkes for temporary loot case.
Fixed *nix build problem after recent commits.
Add dummy effect of spell 53475, 53487 and 54015
Fixed some GCC warnings and code errors.

Thanks to freghar for provide cleaned list of warning messages.
Fixed wrongly use %d for guids in DB queries.

This can affect correct result in cases big guid values
(out of range for possitive part of int32 range) at x86 platforms.

Some other cases addded in addition to original patch fixes
where %d wrongly/unsafe used for unsigned values.
Update SpellEntry based on the work of TOM_RUS
Use portable ACE way msecs time value calculation

Avoid use unsafe code for non-Windows platforms
Thanks to Marik for research the problem and Ambal for helping me with this patch
Cleanup some death state enums usage.
Avoid selection despawned creatures as spell autoselected targets.

Original patch provided by virusav.
Less strict check for update at war state for factions

Clarify in comments of recent added spell dummy effect
Compute cell area bounds for active objects in the same way like it done for players
Add debug note for not implemented summon property group
Remove unused structure GridUpdater.
Correct check percent spell costs in AI::CanCast

Also use uint32 for spell cost fields/results
Fixed loading mails broken after [10692]
Check SPELL_ATTR_IMPOSSIBLE_DODGE_PARRY_BLOCK for special attacks.
Add the option to close gossip window in gossip system

Field action_menu_id in gossip_menu_option table can be set to -1 where close gossip is expected, instead of sending a new menu.
Simplify CellArea calculation
Implement talent 30326 for spell 5138.
Move Glancing Blow early in melee outcome results.
Update ACHIEVEMENT_CRITERIA_TYPE_LOOT_* with group roll.
Prevent wrongly use transport guid as unittarget in spell targets
Fixed typos in my previous commit
Check localization data for existance main table entres.

Data will skipped for nonexistent entries, and reported with
disabled LogFilter_DbStrictedCheck filter.
Startup checks for `gossip_menu` and `gosip_menu_option` table data.

Existance `gosup_menu` id refercned from gameobject field and unused meni ids
activated only with disabled LogFilter_DbStrictedCheck.
player/group instance binding fixes.

* Use anum instead raw uint8 type in args
* Fixed crash when gm at continent invite to group gm in instance
and then teleport to instance using .goname.
When group leader teleport to instance it must get group bind instead solo bind.
* In other semilar cases detection report error as before but replace solo by group bind instead
assert crash at enter to map.
Avoid unexpected error at action_menu_id < 0 after recent loading checks adding.
Fixed move in inventory items with ItemLimitCategory.
Typo show commit before revet all realddiff one more time.

Typos show that in fact "working" has been result typos diabled state for relamd.
Cell-based way have not avoidable problems with case when object added to not active
long time Cell. If someone find more working sollution it can be readded ofc.
Revert "[10716][10688] New version of patch for send real diff from last update."

This reverts commit 8398a55fa274471daae115e00c627b299a3fdbbd.
This reverts commit 06e2d6859ba3d7fd47be72c23a64e68ae039701f.
Partly revert "[10687] UInt32 timer class copies instead using time_t timers for mstime cases."

This reverts commit 967877fefd91e00895f9790dc006b532b94d41b7
in part MapManager/World timers.

Main reason: unclear source cases wrong mstime diff generation at WorldRunnable level at *nix systems.
So need have existed in past hacks that skip its.
Implement proper calculation quest honor reward.

Now server side rewar same as reported at client side.

Also thanks to KiriX for patch prepering to commit and testing.
Implement check `gossip_menu_option`.`npc_option_npcflag`.

For cases main menu options used by creature but impossible show in result absent
related npcflags for any creatures used that menu.
Use required_quest instead of _heroic for non_instance areatrigger teleport
Fill target map for TARGET_RANDOM_NEARBY_DEST(b) cases.

Corrects ~35 spells, where most has summon effects.
Backports from 400 branch.
Add dummy aura effect of 51405 and dummy effect of 51420
Fixed wrong error message for quest related areatriggers.
Fix TARGET_AREAEFFECT_CUSTOM, need to obey type when DB target entry exist
Add a few comments for SUMMON_PROP_TYPE_CRITTER
Correct one SQL in tools, table was renamed.
Map system re-engineered. Special thanks to Blueboy for tests.
Fix Deathly Stare spell
Add dummy aura effect of spell 47178 and dummy effect of 47176

Note: see comments in code for spell 47176
Check if Pet's target is a valid target (isTargetableForAttack)
Remove redundant isAlive-check, thanks LordJZ for notice
Not send session fields as args into HandleMoverRelocation/VerifyMovementInfo.

Also mark args as constant where expected in this functions.
Implement defencive guardians pet type for creatures like 28120
Rename and clarify SummonPropertiesEntry.Type->Title field meaning.

This also show why we have some problems with sorting sumons by types base at this field.

Thanks to TOM_RUS for research.
Fixed spell 51420 work by use recently added protector pets as expected.

Thanks to NoFantasy for problem research (and prev. new pet type adding case research aslo) ;)
Fixed unexpected typo in prev. commit.


YTDB 351


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

[axeii1]

well I can not understand why as I put all the updates and still does not start server gives me these errors here

http://mmopro.net/forums/attachments/f112/498d1289948898-start-mangosd-exe-problem-58366492-jpg

I have to put YTDB 351 update ?

[DjAligator]

you missed some updates or i dunno whtat you did.

[axeii1]

Well can you tell me who to put the updates to go I'm MaNGOS/0.17.0-DEV / Revision 10677 | TRM CU 0079 YTDB Acid 349 39 10 677 MaNGOS ScriptDev2 1854

[DjAligator]

Mangos 10738 - 10777


In fact set pet name to empety state redundent.

Client work propertly also if used default name from creature template (set in create code).
Cleanup pet remove code and some fixes.

* Merge Player::RemovePet and Pet::Remove function code to Pet::Unsummon
This let be sure that in all cases all required steps doen. For example this fix
creature's guardians propertly remove from guardians list.
* Add new pet save mode PET_SAVE_REAGENTS as replacement PET_SAVE_NOT_IN_SLOT+true-arg stable pair in old function args
This will avoid use reagent save arg with wrong different save modes.
* Fixed recently added code with absent check for re-summon protector pet call.
Cleanups in spell effects names.
Add AI function OwnerKilledUnit for protector pets (when owner kills unit)
Add `spell_bonus_data`.`spell_bonus_data` field and support for RAP bonuses use for spells damage from table.

Thanks to insider42 for prepering patch for mangos repo.
Also added loading check for redundant ap/ap_dot data in table.
Add AP/RAP bonus data to `spell_bonus_data`.

Also remove related hardcoded cases.
Prevent equip/unequip items in process logout
Use ObjectGuid in spellauraholders instead uint64

(based on rsa's repo commit 06342c1)
Use objetguid for other .list auras command part
Some other aura caster object guid use cases.
Convert MonsterSay/Say and similar functions to ObjectGuid use.
Convert Gameobject owner to objectguid use.
Convert Gameobject owner to objectguid use.
Use objectguids in item code.

Also
* Fixed unexpected container updated state after inventory load
* Make .debug getitemstate command more friendly by args.
Convert to objetguids map scripts and finally drop IS_PLAYER_GUID.
Lost mangos.sql changes in one from recent commits.
Use UNIT_FIELD_CRITTER for store minipet guid.

Also move related code to Unit and allow summon minipets by creatures.
Also fix creature's totems unsummon at owner remove from world.
Use class specific combat rating factors from gtOCTClassCombatRatingScalarStore.dbc

* Some classes had effect of melee haste buffed
* Change to armor penetration rating was hidden there too
Implement armor penetration limitations

The tool-tip says "up to X%" for a reason...
Implement zone limited pets unsummon at leave allowed zones.

* Also remove redundant zone/area args for zone/area update function like UpdateZoneDependentAuras.
* Merge Player::*AllControlledUnits functions to Unit version with replace option args by mask arg.
* Unit::*AllControlledUnits guardian iteration make working with internal unsummon call suport for guardians case.
Fixed typo in CONTROLED_*
Correctly reset mob orientation upon reaching spawn point. Should also improve visualisation of mob orientation on clients
Remove unneeded non-player Say et al.

Now expected direct use non-player WorldObject::MonsterSay/etc version
Basic support for target-name in MonsterSay/etc

Change MonsterSay's target to pointer.
Implement SPELL_AURA_IGNORE_UNIT_STATE (252).

Original patch provided by Wojta

Note: From patch excluded talent 44543 and ranks stacking code.
It look like need another implemention different from suggested,
or at least more research.
In patch added enum IgnoreUnitState and related checks now more cheating protected.
Move comments at 61 line, no functional changes.
Implement talent 44543 and ranks charges work.
Also fix IGNORE_UNIT_TARGET_NON_FROZEN in part allow casting spell that required frozen target.
Implement SPELL_AURA_MOD_PERIODIC_HEAL (259)
Allow AURA_FORCE_MOVE_FORWARD to work on creatures and vehicles. For example, it fixes spell [68284]
Show <overkill> value in combat logs.
Remove useless code in PetAI::_stopAttack()

Those are all processed elsewhere and _stopAttack() can not be called when pet is not alive.
Fixed trainer flags uses for pet trainers.

* Not exclude trainer flags for client for pet trainers.
* Not report error for pet trianers empty spell lists.

TODO:
* Add check for redundent trainer spell data for pet trainers at server startup
* Need hide train gossip option for pet trainers, but currently without it gossip
window not open for pet trainer by some unknown reason.
Fixed auction items filering by quality.
Explictly include Threading.h into WorldRunnable.h

Instead dependent from includes order in mangosd\WorldRunnable.cpp and mangosd\Master.cpp
Fixed build for different PostgreSQL version at diff platforms.

* Fixed Problem in different place define OID enums.
Enums hardcoded in mangos code now as done for many other projects using PostgreSQL

* Other PostgreSQL detection fixes.
Fixed crash at empty build list in realm string.
Implement more generic reputation spillover

* Also fixes factions 1037 and 1052
* More correct client output when reputation assigned to parent faction
* reputation_spillover_template can still be used to override spillover from dbc
Use separate vars to indicate whether reputation needs to be sent or needs to be saved.
Not mark `reputation_spillover_template` empty state as error

Now expected by default data used from dbc fields.
Explictly include Threading.h into CliRunnable.h

[DjAligator]

Mangos 10778 - 10792


Make AI call OwnerKilledUnit() more proper.

Affect any pet that are not being controlled (minipet/guardian/protector) and will also apply to pets owned by another creature.
Allow ITEM_ENCHANTMENT_TYPE_COMBAT_SPELL to proc on special attacks too.
Fixed warning in ReputationMgr::SetReputation.
Use BattleGround(AV)TeamIndex enum types in AV battleground code.

* Added BattleGroundAVTeamIndex enum type for 3-case special team list fo AV.
* Rename BattleGroundTeamId -> BattleGroundTeamIndex for clarify
* Some safe checks added and dropped bogus call RewardReputationToTeam in BattleGroundAV::HandleQuestComplete
for BattleGroundTeamIndex as faction. Unclear for what it expected used so dropped.
Use Team enum types in all appropriate cases and catches bug in result fix.

* Fixed wrong arenaid use at leave arena queue.
* Fixed memory lost and etc at not virtual EndBattleground call
* Fixed crash at arena join with fake data from client.
* Code cleanups.
Fixed comment in characters.sql
Restrict items with generated loot really to single character only.
Fixed warnings at comparison BattleGroundTeamIndex and BattleGroundAVTeamIndex

Maybe adding special operator== or != can be more nice way but for small used cases this
not look so need really.
A bit spell proc housekeeping

* PPM values for enchanting spells 13898, 20029, 20032, 44524, 44576
* Correct cooldown for enchanting spell 59625
* Add procEx and cooldown for item 50198
Add explicitly header dependences for Database/QueryResult.h
Replace bytes in single field `bytes2` by independent fields for `creature_addon`.
Allow use old non-builting ACE versions (pre-ACE-5.5.4) at Unix-side.

This fix build error in relamd code in result
nonexistence ACE_OFF_T in old ACE versions.
Moved vmap code from shared to game project

After this, realmd code does not contain anymore vmap code
Small cleanup in VC100 filter about vmap files
Fixed more warnings with BattleGroundTeamIndex/BattleGroundAVTeamIndex mixed use.
Fixed warnings and need in redundent char* casts in database access code.

YTDB 354


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

[DjAligator]

Mangos 10793 - 10834


Fixed build problems for vc90 after recent vmaps dir move.

VC80/VC100 not affected by this.
Player.h expected DBCStores.h including.

So make it direct.
I must less press random buttons before push in monkey mode.
Use regular map case in all trigger checks.
Check for valid sheath state in creature addon at startup.
Some more warning fixes related to BattleGroundTeamIndex/BattleGroundAVTeamIndex.
Add GetGuidStr() short call for GetObjectGuid().GetString() and use it.
Use ObjectGuid in some battleground structures.

Also fix some catches bugs in code in result.
More ObjectGuid uses in battleground code.
Use ObjectGuid in Mail code.

Some catched bugs fixed in mixed uint32/guid values using cases.
Use ObjectGuid in player loading code.
Restore build at *nix.
Remove code duplication in visibility distance check.

at_same_transport already include player checks at assign and
it move to common if make 3 distance cases exactly same.
Fixed typo in m_PrematureCountDownTimer initila value set.

Just fo note: in fact initial value assign not used because
m_PrematureCountDownTimer always init and used only in case
m_PrematureCountDonw == true
Typo fix and memory layout optimization.
Small cleanup and optimization in transport current point update.
Remove diplicate World::GetQueueSize and rename functions to consistence naming
More ObjectGuids specially in petition code.

Some uint64<->uin32 bugs fixed at read guids from DB in petition code.

Still exist 29 GUID_LOPART uses in code.
Use ObjectGuids in chat commands.

Still exist 15 GUID_LOPART uses in code.
Use ObjectGuid for corpse owner guid.

Still exist 9 GUID_LOPART uses in code.
Use ObjectGuid for aura holder cast item guid.

Still exist 7 GUID_LOPART uses in code.
Convert to ObjectGuid aura cast item guid access function.
Use in social lists API ObjectGuid form.

0 GUID_LOPART uses in code. :)
Remove GUID_LOPART/GUID_HIPART

* Now no correct way access to internal structure of guid in uint64 form.
For this always must be used ObjectGuid form.
* Guids in uint64 form still used in some cases (many) but it uses as-is
Main source of uint64 guids is non-converted opcode handlers.
* Also ofc, possible cases wrong created uint64 guids by assign uint32 to uint64.
For catch all cases need finish convertion to ObjectGuid all non-converted yet code.
Add explicit include for ObjectGuid.h in AchievementMgr.h.
Add dummy effect of spell 47170
Fixed creature's speed recalculation, forgotten DB speed mods are used now

Also properly update speeds at creature entry change(in case there are aura speed bonuses), thanks to Vladimir for pointing
Speedup and cleanup quest counters update code.

* Always use QuestStatus data for current counters set
This let be sure that that we not have non sync values in client view and server state.
* Remove some access functions for quest update fields that expected to be only updated/set.
Restore anti-cheating check work at buy item
Fixed "unsigned is never < 0" warning.
Clear way access/set UNIT_FIELD_BYTES_*/PLAYER_BYTES* byte fields.

Fix some bugs when all uint32 field modified instead byte parts.
In some cases added byte way set/get but code line itself need additinal reserch/fix
for use correctness in line pos.
Fixed copy-paste typo in prev. commit.
Move specific SQLStorage defines to game dir

This let have in shared dir only generic declarations of class SQLStorage
Not game specific details.
Fix vmap_assembler compilation after vmap folder move

Also make vmap_assembler compile sucessfuly with VC80.
Add VC80 projects and solutions files where missing like vmap_extractor
Fix warnings for TBB projects compilation using Visual Studio 10

Also fix a small typo in prev commit.
Update SpellFamily check functions.

* Move SPELLFAMILY_* to DBCEnums.h and name it as SpellFamily
* Use enum in Unit::GetAura, move family mask code to new SpellEntry helper function.
* Avoid all auras scan in search of triggred spell for 20243.
Prevent spell_proc_event entries to proc on any spell cast when SpellFamilyName is zero.

Now only spells that actually deal damage or heal will trigger
when neither SpellFamilyName nor ProcEx & PROC_EX_EX_TRIGGER_ALWAYS are set.
Before, setting a SchoolMask would override this check, causing many bogus procs.
Fixed crash at send mail from console

Inspired by patch from rsa.
Spawn pool at aura 63471 dispel in water.
Avoid use unsafe remove auras in aura apply code.

Specailly example Aura::HandleModCharm code where old code
call RemoveSpellsCausingAura or (a) dead and not called,
or (b) will remove aura self at call.

* Added safe for aura holder context version of RemoveSpellsCausingAura
* Cleanup old simple RemoveSpellsCausingAura code also.
Cleanup shapeshift form code.

YTDB 355


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ processed 46 caches (4.0.1)

[DjAligator]

Mangos 10835 - 10866


Add/correct a couple more spell_proc_event entries for trinket related spells

*Affected items: 45131, 45219, 50359, 50366, 50360, 50365,
50353, 50348, 50362, 50363, 50342, 50343, 50358
Again ignore EffectSpellClassMask when SchoolMask given in spell_proc_event.

There's just too much garbage in dbc...
Should restore some damage school based talents broken with [10830],
hopefully without excessively triggering other spells again that shouldn't.
Implement script effect of spell 26218.

Also do small spells ordering around.
Not report error for missing reqs for some quest timed achievements.

This achievements in fact not required any additional checks.
At far teleport fail retunr player to source point instead homebind.
Implement server side part of SPELL_AURA_ADD_MECHANIC_ABILITIES (293) work.

Also fix stealth/invisibility visual affect flags changed at some 3.x switch.
Implement charges counting for magnet target auras.

Also implement skip spell effects redirecting if magnet target can't be
targeted by this spell effect base at spell effect target data requirements.
Allow fill DB table spell_script_target for TARGET_AREAEFFECT_INSTANT(7)

Without any database entries for spell, spell will work like before.
Valid targets filled to database can only be creature type (corpse or alive).
Fix AuraType 138 to not affect ranged haste, and rename to SPELL_AURA_MOD_MELEE_HASTE.

Also type 192 had misleading name, rename to SPELL_AURA_MOD_MELEE_RANGED_HASTE.
Remove small redundency in magnet spell charges checks.
Add dummy effect of spell 49634 and dummy aura of spell 56511

note* spell will need data in spell_script_target to work properly.
note* the effect of 56511 does not work, see comment in code for details (code added in any case, to not forget the problem)
Add dummy aura of spell 43874 (indirectly related to spell/effect 50133)
Unsummon guardians at second item use for items without cooldown.
New system for parallelizing client packet processing. Handle WorldSession updates in Map::Update() where we are safe to proceed. Thank you for all your feedback!
Fix build with gcc.
Move common check part for recently added filter classes to helper function.

This is more safe have expected tio be same check in one function.

Also apply some code style fixes.
Small function order in sources update.
Fixed typo in [10847]
Report about GM invisible state at login if enable.
Fixed crash at .character erase command use.
Add TARGET_AREAEFFECT_GO_AROUND_DEST(52) (renamed from TARGET_AREAEFFECT_CUSTOM_2)

Target selects all gameobject around destination, limited by adding spell with a corresponding gameobject entry in database table spell_script_target.
Correct two whitespace errors
Complete set Byte/ShortFlag value functions and use it for PLAYER_FIELD_BYTES proper access.

Not expected any changes in work.
Add triggered spell part for dummy effect of spell 43572
Search for linked GO using the original used GO as base of the search

Add some comments for future improvements of this function.
Handle GAMEOBJECT_TYPE_TRAP in Use, as done for other GO types.

This just move parts of existing code from TriggeringLinkedGameObject and does not affect summoned trap type GO's (or related to summoned).
Large flightless birds (emu) think they are invisible, even when they are not.

Only if _not_ isGMVisible, invisible notification can be sent :)
Fixed not show and lost mail items in returned expire mails.

Also
* Use typename for mail item info vector.
* Include tools/characters_mail_items_cleanup.sql for cleanup lost mail items.
It also included as sql update part. Sql update also fix receiver for stored
in DB expired mail items.
Fixed triggering/use effects for item 54589, 54573, 37734, 32500, 28590.
Implement itemsets 881, 882 at heal/damage target effect.
Make DB code thread-safe. Original patch by Machiavelli and Kero99.
Unsummon guardians at re-cast only for non-triggered case.

YTDB 356


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB

[DjAligator]

Mangos 10867 - 10894


Implement templates for trainer spell data in `npc_trainer_template`.

New table let avoid duplication similar trainer spells for different trainers.
Fixed spell 53479.

(based on insider42's repo commit b0343e1)
Fixed typo in mangos.sql added in recent commit.
Properly remove deleted character from friends of online players.
Avoid lost arena match at leave queue (before invite to match)
Grr, restore code style.
Fixed crash for case when trainer have only data in npc_trainer_template.

Good know base at report that this feature so quick start used actively ;)
Update ACE to v5.8.3

(based on zergtmn's repo commit 3a8c259)
(based on zergtmn's repo commit 946c1a8)
Update ACE version in NEWS/ChangeLog
Really fix crash in SendTrainerList :/
Traditional 'Waypoint' post-fix in mangos.sql
Update achievement at maximize skill level by command or config option.
Remove support unused option SocketSelectTime in mangosd.conf
Avoid constant re-save BG entry data at each save for player at bg/arena.
Lost important line in prev. commit.
No error output for empty npc_trainer* tables
Implement item 49982, 50641 equip effect
Pet with same level as owner must have xp = 0

Thanks to Click for original patch and problem description.
Hunter pet can't have < owner-5 level
Also make tame time check call safe.
Fixed crash at GO use in case GO owner/first user offline state.
Add dummy aura effect of spell 42515
Use 0.0f in one function and prevent some compiler warnings.
Add dummy aura effect of spell 42517
Merge apply/remove cases for recently added dummy auras.
Access for core/scripts to creature race info in model dbc
Fix load creature *addon data from database
Speedup check code at `gossip_menu_option` loading.
Fixed problems with new ACE lib on Darwin systems

(based on cipherCOM's repo commit ce2638f)

YTDB 357


+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

[Anima]

This is a new site for developers of private servers for online game World of Warcraft. This site is under construction and filling content. Wanted moderators, writers, news, and just good people.

This site is located on the home computer, after its completion wakes moved to hosting.

Link:

World of Warcraft Cataclysm Development (http://wowcataclysm.no-ip.org/forum/forum.php)

[Persisting]

Thanks :P